Commit 0ebc259
committed
fix(sidecar): use bare process_tags for RC Target to keep hash consistent
The `Target` struct in datadog-remote-config derives Hash over all
fields including process_tags. Both the sidecar (RC write side) and
the tracer (RC read side via ddog_remote_configs_service_env_change)
must agree on the Target hash, and the tracer passes the bare
process_tags Vec.
Augmenting only the sidecar side with svc.* via
`process_tags_with_svc_source()` made the Target hashes diverge,
orphaning RC configs in SHM (probes never installed, dynamic config
never applied).
For now revert this single call site to bare process_tags. A proper
follow-up should either exclude process_tags from Target's Hash/Eq
impl, or separate Target's identity fields from the payload metadata
fields. Trace + telemetry svc.* injection is unaffected.1 parent 975e3af commit 0ebc259
1 file changed
Lines changed: 4 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
142 | 142 | | |
143 | 143 | | |
144 | 144 | | |
145 | | - | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
146 | 149 | | |
147 | 150 | | |
148 | 151 | | |
| |||
0 commit comments