Commit 4360dbb
fix(ci): skip thread counting test (#1841)
# What does this PR do?
`test_count_active_threads` run on centos7 are [flaking](https://github.com/DataDog/libdatadog/actions/runs/23868297465/job/69593217671?pr=1839) as such:
```
stdout ───
running 1 test
running 1 test
thread 'test_utils::tests::test_count_active_threads' (70243) panicked at libdd-common/src/test_utils.rs:564:13:
Expected thread count to return to 2 or 3 after join, got 4
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
test test_utils::tests::test_count_active_threads ... FAILED
failures:
failures:
test_utils::tests::test_count_active_threads
test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 112 filtered out; finished in 0.05s
stderr ───
thread 'test_utils::tests::test_count_active_threads' (70241) panicked at /usr/local/cargo/registry/src/index.crates.io-1949cf8c6b5b557f/rusty-fork-0.3.1/src/fork_test.rs:135:9:
child exited unsuccessfully with exit status: 70
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
```
This is because some platforms, such as CentOS, spawn helper threads
# Motivation
Its been extremely flaky over the past two months
# Additional Notes
This test test a helper that is used for another test. The actual thread counting functionality seems sound, but the testing of thread counting with hard assertions on the # of threads is flaky because it is dependent on platform and sync state
# How to test the change?
Describe here in detail how the change can be validated.
Co-authored-by: edmund.kump <edmund.kump@datadoghq.com>1 parent eb3c39b commit 4360dbb
3 files changed
Lines changed: 47 additions & 53 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
89 | 89 | | |
90 | 90 | | |
91 | 91 | | |
92 | | - | |
93 | 92 | | |
94 | 93 | | |
95 | 94 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
419 | 419 | | |
420 | 420 | | |
421 | 421 | | |
422 | | - | |
423 | 422 | | |
424 | 423 | | |
425 | 424 | | |
| |||
516 | 515 | | |
517 | 516 | | |
518 | 517 | | |
519 | | - | |
520 | | - | |
521 | | - | |
522 | | - | |
523 | | - | |
524 | | - | |
525 | | - | |
526 | | - | |
527 | | - | |
528 | | - | |
529 | | - | |
530 | | - | |
531 | | - | |
532 | | - | |
533 | | - | |
534 | | - | |
535 | | - | |
536 | | - | |
537 | | - | |
538 | | - | |
539 | | - | |
540 | | - | |
541 | | - | |
542 | | - | |
543 | | - | |
544 | | - | |
| 518 | + | |
| 519 | + | |
| 520 | + | |
| 521 | + | |
| 522 | + | |
| 523 | + | |
| 524 | + | |
| 525 | + | |
| 526 | + | |
| 527 | + | |
| 528 | + | |
| 529 | + | |
| 530 | + | |
| 531 | + | |
| 532 | + | |
| 533 | + | |
| 534 | + | |
| 535 | + | |
| 536 | + | |
| 537 | + | |
| 538 | + | |
| 539 | + | |
| 540 | + | |
545 | 541 | | |
546 | | - | |
547 | | - | |
548 | | - | |
549 | | - | |
550 | | - | |
551 | | - | |
552 | | - | |
553 | | - | |
554 | | - | |
555 | | - | |
556 | | - | |
557 | | - | |
558 | | - | |
559 | | - | |
560 | | - | |
| 542 | + | |
| 543 | + | |
| 544 | + | |
| 545 | + | |
| 546 | + | |
| 547 | + | |
| 548 | + | |
| 549 | + | |
| 550 | + | |
| 551 | + | |
| 552 | + | |
| 553 | + | |
561 | 554 | | |
562 | | - | |
563 | | - | |
564 | | - | |
565 | | - | |
566 | | - | |
567 | | - | |
568 | | - | |
569 | | - | |
570 | | - | |
| 555 | + | |
| 556 | + | |
571 | 557 | | |
| 558 | + | |
| 559 | + | |
| 560 | + | |
| 561 | + | |
| 562 | + | |
| 563 | + | |
| 564 | + | |
| 565 | + | |
| 566 | + | |
| 567 | + | |
572 | 568 | | |
573 | 569 | | |
0 commit comments