Commit 5beaea5
authored
chore: bump 'pyo3' to v0.28 (#1847)
https://datadoghq.atlassian.net/browse/PROF-14200
# What does this PR do?
Bumps `pyo3` from `0.27.2` to `0.28` in `datadog-ffe/Cargo.toml`. This is a version
pin change only — the code changes required by the 0.28 API (`type Error` associated
type on `FromPyObject` impls) are already present on main.
# Motivation
`dd-trace-py` links `datadog-ffe` into its native extension (`_native`). Cargo requires
all crates in the dependency graph that link the native `python` library to agree on a
single pyo3 version. With `datadog-ffe` pinned to `0.27.2`, bumping pyo3 in `dd-trace-py`
to `0.28` produces a hard link conflict:
```
error: package pyo3-ffi links to the native library python, but it conflicts
with a previous package which links to python as well: pyo3-ffi v0.27.2
(from datadog-ffe via libdatadog)
```
pyo3 0.28 is the first release with native Python 3.15 support. Until this is resolved,
`dd-trace-py` cannot install on Python 3.15, blocking the profiler's 3.15 CI matrix
and all pytest tests on that version.
# Additional Notes
Migrating `dd-trace-py` (profiling) to Python v3.15: DataDog/dd-trace-py#17294.
# How to test the change?
```bash
$ cd datadog-ffe
$ cargo check --features pyo3
$ cargo test --features pyo3
...
test result: ok. 10 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 1.56s
```
Co-authored-by: vlad.scherbich <vlad.scherbich@datadoghq.com>1 parent 5b6dffc commit 5beaea5
3 files changed
+11
-31
lines changedSome generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
203 | 203 | | |
204 | 204 | | |
205 | 205 | | |
206 | | - | |
207 | 206 | | |
208 | 207 | | |
209 | 208 | | |
| |||
467 | 466 | | |
468 | 467 | | |
469 | 468 | | |
470 | | - | |
471 | 469 | | |
472 | 470 | | |
473 | 471 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
26 | | - | |
| 26 | + | |
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
| |||
0 commit comments