chore: review fixes

Author: apiarian-datadog

.github/workflows/lint.yml

@@ -45,10 +45,10 @@ jobs:
         shell: bash
         run: |
           if [[ "${{ matrix.platform }}" == "windows-latest" ]]; then
-            export AWS_LC_FIPS_SYS_NO_ASM=1;
-          fi;
+            export AWS_LC_FIPS_SYS_NO_ASM=1
+          fi
           # shellcheck disable=SC2046
-          cargo clippy --workspace --all-targets --all-features -- -D warnings $([ ${{ matrix.rust_version }} = 1.78.0 ] || [ ${{ matrix.rust_version }} = stable ] && echo -Aunknown-lints -Ainvalid_reference_casting -Aclippy::redundant-closure-call);
+          cargo clippy --workspace --all-targets --all-features -- -D warnings $([ ${{ matrix.rust_version }} = 1.78.0 ] || [ ${{ matrix.rust_version }} = stable ] && echo -Aunknown-lints -Ainvalid_reference_casting -Aclippy::redundant-closure-call)
 
   licensecheck:
     runs-on: ubuntu-latest

ddcommon/Cargo.toml

@@ -80,4 +80,12 @@ cgroup_testing = []
 fips = ["https", "hyper-rustls/fips"]
 
 [lints.rust]
+# We run coverage checks in our github actions. These checks are run with
+# --all-features which is incompatible with our fips feature. The crypto
+# provider default needs to be set by the caller in fips mode. For now, we want
+# to make sure that the coverage tests use the non-fips version of the crypto
+# provider initialization logic, so we added a coverage cfg check on the
+# function in src/connector/mod.rs. The coverage config is actually not used in
+# normal environments, so we need to let the rust linter know that it is in
+# fact a real thing, though one that shows up only in some situations.
 unexpected_cfgs = { level = "warn", check-cfg = ['cfg(coverage)'] }

ddcommon/src/connector/mod.rs

@@ -110,8 +110,8 @@ mod https {
         });
     }
 
-    // This this actually needs to be done by the user somewhere in their own main.
-    // This will only be active on Unix platforms
+    // This actually needs to be done by the user somewhere in their own main. This will only
+    // be active on Unix platforms
     #[cfg(all(feature = "fips", not(coverage)))]
     fn ensure_crypto_provider_initialized() {}
 

local-linux.Dockerfile

@@ -14,8 +14,10 @@ RUN apt-get update && \
     docker.io \
     sudo \
     wget \
-    && rm -rf /var/lib/apt/lists/* \
-    && wget -O go1.24.2.linux-arm64.tar.gz https://go.dev/dl/go1.24.2.linux-arm64.tar.gz \
+    && rm -rf /var/lib/apt/lists/*
+
+# We need go in order to build aws-lc-fips-sys
+RUN wget -O go1.24.2.linux-arm64.tar.gz https://go.dev/dl/go1.24.2.linux-arm64.tar.gz \
     && tar -C /usr/local -xzf go1.24.2.linux-arm64.tar.gz
 
 # Docker-in-Docker configuration (necessary for integration tests)