chore: reduce symbol visibility and streamlime symbol reexporting

Author: hoolioh

libdd-data-pipeline-ffi/src/error.rs

@@ -1,7 +1,7 @@
 // Copyright 2024-Present Datadog, Inc. https://www.datadoghq.com/
 // SPDX-License-Identifier: Apache-2.0
 
-use libdd_data_pipeline::trace_exporter::error::{
+use libdd_data_pipeline::trace_exporter::{
     AgentErrorKind, BuilderErrorKind, InternalErrorKind, NetworkErrorKind, TraceExporterError,
 };
 use std::ffi::{c_char, CString};

libdd-data-pipeline-ffi/src/response.rs

@@ -3,7 +3,7 @@
 
 //! Define FFI compatible AgentResponse struct
 
-use libdd_data_pipeline::trace_exporter::agent_response::AgentResponse;
+use libdd_data_pipeline::trace_exporter::AgentResponse;
 use std::ptr::null;
 
 /// Structure containing the agent response to a trace payload

libdd-data-pipeline-ffi/src/trace_exporter.rs

@@ -11,7 +11,7 @@ use libdd_common_ffi::{
 };
 
 #[cfg(feature = "telemetry")]
-use libdd_data_pipeline::telemetry::TelemetryConfig;
+use libdd_data_pipeline::trace_exporter::TelemetryConfig;
 use libdd_data_pipeline::trace_exporter::{
     TraceExporter as GenericTraceExporter, TraceExporterInputFormat, TraceExporterOutputFormat,
 };

libdd-data-pipeline/src/lib.rs

@@ -16,7 +16,7 @@ pub(crate) mod otlp;
 #[cfg(not(target_arch = "wasm32"))]
 mod pausable_worker;
 #[allow(missing_docs)]
-pub mod stats_exporter;
+pub(crate) mod stats_exporter;
 pub mod telemetry;
 #[allow(missing_docs)]
 pub mod trace_exporter;

libdd-data-pipeline/src/stats_exporter.rs

@@ -21,8 +21,6 @@ use tokio::select;
 use tokio_util::sync::CancellationToken;
 use tracing::error;
 
-const STATS_ENDPOINT_PATH: &str = "/v0.6/stats";
-
 /// An exporter that concentrates and sends stats to the agent.
 ///
 /// `H` is the HTTP client implementation, see [`HttpClientTrait`]. Leaf crates
@@ -193,13 +191,6 @@ fn encode_stats_payload(
     }
 }
 
-/// Return the stats endpoint url to send stats to the agent at `agent_url`
-pub fn stats_url_from_agent_url(agent_url: &str) -> anyhow::Result<http::Uri> {
-    let mut parts = agent_url.parse::<http::Uri>()?.into_parts();
-    parts.path_and_query = Some(http::uri::PathAndQuery::from_static(STATS_ENDPOINT_PATH));
-    Ok(http::Uri::from_parts(parts)?)
-}
-
 #[cfg(test)]
 mod tests {
     use super::*;
@@ -211,11 +202,21 @@ mod tests {
     use time::Duration;
     use time::SystemTime;
 
+    const STATS_ENDPOINT_PATH: &str = "/v0.6/stats";
+
     fn is_send<T: Send>() {}
     fn is_sync<T: Sync>() {}
 
     const BUCKETS_DURATION: Duration = Duration::from_secs(10);
 
+    /// Return the stats endpoint url to send stats to the agent at `agent_url`
+    fn stats_url_from_agent_url(agent_url: &str) -> anyhow::Result<http::Uri> {
+        let mut parts = agent_url.parse::<http::Uri>()?.into_parts();
+        parts.path_and_query = Some(http::uri::PathAndQuery::from_static(STATS_ENDPOINT_PATH));
+        Ok(http::Uri::from_parts(parts)?)
+    }
+
+
     /// Fails to compile if stats exporter is not Send and Sync
     #[test]
     fn test_stats_exporter_sync_send() {

libdd-data-pipeline/src/trace_exporter/mod.rs

@@ -3,14 +3,18 @@
 pub mod agent_response;
 pub mod builder;
 pub mod error;
-pub mod metrics;
-pub mod stats;
+pub(crate) mod metrics;
+pub(crate) mod stats;
 mod trace_serializer;
 
-// Re-export the builder
+// Re-export commonly used types for convenience
+pub use agent_response::AgentResponse;
 pub use builder::TraceExporterBuilder;
+pub use crate::telemetry::TelemetryConfig;
+pub use error::{
+    AgentErrorKind, BuilderErrorKind, InternalErrorKind, NetworkErrorKind, TraceExporterError,
+};
 
-use self::agent_response::AgentResponse;
 use self::metrics::MetricsEmitter;
 use self::stats::StatsComputationStatus;
 use self::trace_serializer::TraceSerializer;
@@ -22,8 +26,7 @@ use crate::telemetry::{SendPayloadTelemetry, TelemetryClient};
 use crate::trace_exporter::agent_response::{
     AgentResponsePayloadVersion, DATADOG_RATES_PAYLOAD_VERSION,
 };
-use crate::trace_exporter::error::InternalErrorKind;
-use crate::trace_exporter::error::{RequestError, TraceExporterError};
+use crate::trace_exporter::error::RequestError;
 use crate::{
     agent_info::{self, schema::AgentInfo},
     health_metrics,