Skip to content

Commit ddece1d

Browse files
committed
Avoid TracerHeaderMap
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
1 parent 205a42e commit ddece1d

File tree

5 files changed

+14
-24
lines changed

5 files changed

+14
-24
lines changed

datadog-ipc/src/platform/windows/mem_handle.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ impl NamedShmHandle {
151151
handle: unsafe { PlatformHandle::from_raw_handle(handle) },
152152
size,
153153
},
154-
path: Some(ShmPath { name }).map(Box::new).into(),
154+
path: Some(Box::new(ShmPath { name })).into(),
155155
})
156156
}
157157
}

datadog-sidecar/src/service/stats_flusher.rs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -176,10 +176,7 @@ pub async fn run_stats_flush_loop(
176176
{
177177
let mut guard = arc.lock_or_panic();
178178
// Only remove our entry — a fresher one may have been inserted already.
179-
if guard
180-
.get(&map_key)
181-
.map_or(false, |s| Arc::ptr_eq(s, &state))
182-
{
179+
if guard.get(&map_key).is_some_and(|s| Arc::ptr_eq(s, &state)) {
183180
guard.remove(&map_key);
184181
}
185182
}

libdd-data-pipeline/src/trace_exporter/stats.rs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -266,9 +266,6 @@ impl From<TracerMetadata> for StatsMetadata {
266266
app_version: m.app_version,
267267
runtime_id: m.runtime_id,
268268
language: m.language,
269-
lang_version: m.language_version,
270-
lang_interpreter: m.language_interpreter,
271-
lang_vendor: m.language_interpreter_vendor,
272269
tracer_version: m.tracer_version,
273270
git_commit_sha: m.git_commit_sha,
274271
process_tags: m.process_tags,

libdd-trace-stats/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ anyhow = "1.0"
1414
libdd-capabilities = { path = "../libdd-capabilities", version = "0.1.0" }
1515
libdd-common = { version = "3.0.2", path = "../libdd-common", default-features = false }
1616
libdd-ddsketch = { version = "1.0.1", path = "../libdd-ddsketch" }
17-
libdd-shared-runtime = { version = "1.0.0", path = "../libdd-shared-runtime" }
17+
libdd-shared-runtime = { version = "0.1.0", path = "../libdd-shared-runtime" }
1818
libdd-trace-protobuf = { version = "3.0.1", path = "../libdd-trace-protobuf" }
1919
libdd-trace-utils = { version = "3.0.1", path = "../libdd-trace-utils", default-features = false }
2020
hashbrown = { version = "0.15" }

libdd-trace-stats/src/stats_exporter.rs

Lines changed: 11 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ use libdd_common::Endpoint;
1616
use libdd_shared_runtime::Worker;
1717
use libdd_trace_protobuf::pb;
1818
use libdd_trace_utils::send_with_retry::{send_with_retry, RetryStrategy};
19-
use libdd_trace_utils::trace_utils::TracerHeaderTags;
2019
use std::fmt::Debug;
2120
use tracing::error;
2221

@@ -30,25 +29,23 @@ pub struct StatsMetadata {
3029
pub app_version: String,
3130
pub runtime_id: String,
3231
pub language: String,
33-
pub lang_version: String,
34-
pub lang_interpreter: String,
35-
pub lang_vendor: String,
3632
pub tracer_version: String,
3733
pub git_commit_sha: String,
3834
pub process_tags: String,
3935
pub service: String,
4036
}
4137

42-
impl<'a> From<&'a StatsMetadata> for TracerHeaderTags<'a> {
43-
fn from(m: &'a StatsMetadata) -> TracerHeaderTags<'a> {
44-
TracerHeaderTags {
45-
lang: &m.language,
46-
lang_version: &m.lang_version,
47-
lang_interpreter: &m.lang_interpreter,
48-
lang_vendor: &m.lang_vendor,
49-
tracer_version: &m.tracer_version,
50-
..Default::default()
38+
impl StatsMetadata {
39+
/// Build the HTTP headers accepted by the agent's `/v0.6/stats` endpoint.
40+
pub fn to_stats_headers(&self) -> http::HeaderMap {
41+
let mut map = http::HeaderMap::new();
42+
if let Ok(v) = self.language.parse() {
43+
map.insert("Datadog-Tracer-Language", v);
44+
}
45+
if let Ok(v) = self.tracer_version.parse() {
46+
map.insert("Datadog-Tracer-Version", v);
5147
}
48+
map
5249
}
5350
}
5451

@@ -116,8 +113,7 @@ impl<H: HttpClientTrait, C: FlushableConcentrator> StatsExporter<H, C> {
116113
}
117114
let body = rmp_serde::encode::to_vec_named(&payload)?;
118115

119-
let mut headers: http::HeaderMap = TracerHeaderTags::from(&self.meta).into();
120-
116+
let mut headers = self.meta.to_stats_headers();
121117
headers.insert(
122118
http::header::CONTENT_TYPE,
123119
libdd_common::header::APPLICATION_MSGPACK,

0 commit comments

Comments
 (0)