chore: make the fips feature unix-only

Author: apiarian-datadog

ddcommon/Cargo.toml

@@ -76,5 +76,5 @@ use_webpki_roots = ["hyper-rustls/webpki-roots"]
 # Enable this feature to enable stubbing of cgroup
 # php directly import this crate and uses functions gated by this feature for their test
 cgroup_testing = []
-# FIPS mode uses the FIPS-compliant cryptographic provider
+# FIPS mode uses the FIPS-compliant cryptographic provider (Unix only)
 fips = ["https", "hyper-rustls/fips"]

ddcommon/src/connector/mod.rs

@@ -97,7 +97,7 @@ mod https {
     /// happens here.  On non-unix platforms, ddcommon uses `ring` instead, which handles this
     /// at rustls initialization. TODO: Move to the more ergonomic LazyLock when MSRV is 1.80
     /// In fips mode we expect someone to have done this already.
-    #[cfg(not(feature = "fips"))]
+    #[cfg(not(all(unix, feature = "fips")))]
     fn ensure_crypto_provider_initialized() {
         use std::sync::OnceLock;
         static INIT_CRYPTO_PROVIDER: OnceLock<()> = OnceLock::new();
@@ -111,7 +111,8 @@ mod https {
     }
 
     // This this actually needs to be done by the user somewhere in their own main.
-    #[cfg(feature = "fips")]
+    // This will only be active on Unix platforms
+    #[cfg(all(unix, feature = "fips"))]
     fn ensure_crypto_provider_initialized() {}
 
     #[cfg(feature = "use_webpki_roots")]

trace-utils/Cargo.toml

@@ -76,5 +76,5 @@ test-utils = [
 ]
 proxy = ["hyper-http-proxy"]
 compression = ["zstd", "flate2"]
-# FIPS mode uses the FIPS-compliant cryptographic provider
+# FIPS mode uses the FIPS-compliant cryptographic provider (Unix only)
 fips = ["ddcommon/fips"]