Skip to content

feat(crashtracking)!: collect all threads#1878

Draft
gyuheon0h wants to merge 4 commits intomainfrom
gyuheon0h/PROF-14275-collect-all-threads
Draft

feat(crashtracking)!: collect all threads#1878
gyuheon0h wants to merge 4 commits intomainfrom
gyuheon0h/PROF-14275-collect-all-threads

Conversation

@gyuheon0h
Copy link
Copy Markdown
Contributor

@gyuheon0h gyuheon0h commented Apr 14, 2026 •
edited
Loading

What does this PR do?

"threads": [
        {
          "crashed": false,
          "name": "ct_worker_0",
          "stack": {
            "format": "Datadog Crashtracker 1.0",
            "frames": [
              {
                "build_id": "4f7b0c955c3d81d7cac1501a2498b69d1d82bfe7",
                "build_id_type": "GNU",
                "column": 7,
                "file": "./time/../sysdeps/unix/sysv/linux/clock_nanosleep.c",
                "file_type": "ELF",
                "function": "__GI___clock_nanosleep",
                "ip": "0x7f66747167f8",
                "line": 78,
                "path": "/usr/lib/x86_64-linux-gnu/libc.so.6",
                "relative_address": "0x00000000000e57f8",
                "sp": "0x7f667461cc20"
              },
              {
                "build_id": "4f7b0c955c3d81d7cac1501a2498b69d1d82bfe7",
                "build_id_type": "GNU",
                "column": 6,
                "file": "./posix/../sysdeps/unix/sysv/linux/nanosleep.c",
                "file_type": "ELF",
                "function": "__GI___nanosleep",
                "ip": "0x7f667471b677",
                "line": 26,
                "path": "/usr/lib/x86_64-linux-gnu/libc.so.6",
                "relative_address": "0x00000000000ea677",
                "sp": "0x7f667461cca0"
              },
              {
                "build_id": "b10b0322a537ba24c56ac2c6d47f6f4535678851",
                "build_id_type": "GNU",
                "column": 5,
                "file": "/rustc/ded5c06cf21d2b93bffd5d884aa6e96934ee4234/library/std/src/thread/mod.rs",
                "file_type": "ELF",
                "function": "std::thread::sleep",
                "ip": "0x6498ceabe090",
                "line": 889,
                "path": "/home/bits/go/src/github.com/DataDog/libdatadog/target/release/crashtracker_bin_test",
                "relative_address": "0x0000000000085090",
                "sp": "0x7f667461ccb0"
              },
              {
                "build_id": "b10b0322a537ba24c56ac2c6d47f6f4535678851",
                "build_id_type": "GNU",
                "column": 2,
                "file": "/home/bits/go/src/github.com/DataDog/libdatadog/bin_tests/src/modes/unix/test_017_multi_thread_collection.rs",
                "file_type": "ELF",
                "function": "wait_for_work_0",
                "ip": "0x6498cea6fab7",
                "line": 30,
                "path": "/home/bits/go/src/github.com/DataDog/libdatadog/target/release/crashtracker_bin_test",
                "relative_address": "0x0000000000036ab7",
                "sp": "0x7f667461cd30"
              },
              {
                "build_id": "b10b0322a537ba24c56ac2c6d47f6f4535678851",
                "build_id_type": "GNU",
                "column": 2,
                "file": "/home/bits/go/src/github.com/DataDog/libdatadog/bin_tests/src/modes/unix/test_017_multi_thread_collection.rs",
                "file_type": "ELF",
                "function": "worker_entry_0",
                "ip": "0x6498cea6fa9e",
                "line": 36,
                "path": "/home/bits/go/src/github.com/DataDog/libdatadog/target/release/crashtracker_bin_test",
                "relative_address": "0x0000000000036a9e",
                "sp": "0x7f667461cd40"
              },
              {
                "build_id": "b10b0322a537ba24c56ac2c6d47f6f4535678851",
                "build_id_type": "GNU",
                "column": 18,
                "file": "/home/bits/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/sys/backtrace.rs",
                "file_type": "ELF",
                "function": "__rust_begin_short_backtrace<bin_tests::modes::unix::test_017_multi_thread_collection::{impl#0}::post::{closure_env#1}, ()>",
                "ip": "0x6498cea6fa05",
                "line": 158,
                "path": "/home/bits/go/src/github.com/DataDog/libdatadog/target/release/crashtracker_bin_test",
                "relative_address": "0x0000000000036a05",
                "sp": "0x7f667461cd50"
              },
              {
                "build_id": "b10b0322a537ba24c56ac2c6d47f6f4535678851",
                "build_id_type": "GNU",
                "column": 5,
                "file": "/home/bits/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/ops/function.rs",
                "file_type": "ELF",
                "function": "call_once<std::thread::{impl#0}::spawn_unchecked_::{closure_env#1}<bin_tests::modes::unix::test_017_multi_thread_collection::{impl#0}::post::{closure_env#1}, ()>, ()>",
                "ip": "0x6498cea6f83c",
                "line": 250,
                "path": "/home/bits/go/src/github.com/DataDog/libdatadog/target/release/crashtracker_bin_test",
                "relative_address": "0x000000000003683c",
                "sp": "0x7f667461cd70"
              },
              {
                "build_id": "b10b0322a537ba24c56ac2c6d47f6f4535678851",
                "build_id_type": "GNU",
                "column": 17,
                "file": "/rustc/ded5c06cf21d2b93bffd5d884aa6e96934ee4234/library/std/src/sys/thread/unix.rs",
                "file_type": "ELF",
                "function": "std::sys::thread::unix::Thread::new::thread_start",
                "ip": "0x6498ceabd0ff",
                "line": 126,
                "path": "/home/bits/go/src/github.com/DataDog/libdatadog/target/release/crashtracker_bin_test",
                "relative_address": "0x00000000000840ff",
                "sp": "0x7f667461cdf0"
              },
              {
                "build_id": "4f7b0c955c3d81d7cac1501a2498b69d1d82bfe7",
                "build_id_type": "GNU",
                "column": 8,
                "file": "./nptl/pthread_create.c",
                "file_type": "ELF",
                "function": "start_thread",
                "ip": "0x7f66746c5ac3",
                "line": 442,
                "path": "/usr/lib/x86_64-linux-gnu/libc.so.6",
                "relative_address": "0x0000000000094ac3",
                "sp": "0x7f667461ce20"
              },
              {
                "build_id": "4f7b0c955c3d81d7cac1501a2498b69d1d82bfe7",
                "build_id_type": "GNU",
                "column": 0,
                "file": "./misc/../sysdeps/unix/sysv/linux/x86_64/clone3.S",
                "file_type": "ELF",
                "function": "__clone3",
                "ip": "0x7f66747578c0",
                "line": 83,
                "path": "/usr/lib/x86_64-linux-gnu/libc.so.6",
                "relative_address": "0x00000000001268c0",
                "sp": "0x7f667461cec0"
              }
            ],
            "incomplete": false
          },
          "state": "S"
        },
        {
          "crashed": false,
          "name": "ct_worker_1",
          "stack": {
            "format": "Datadog Crashtracker 1.0",
            "frames": [
              {
                "build_id": "4f7b0c955c3d81d7cac1501a2498b69d1d82bfe7",
                "build_id_type": "GNU",
                "column": 7,
                "file": "./time/../sysdeps/unix/sysv/linux/clock_nanosleep.c",
                "file_type": "ELF",
                "function": "__GI___clock_nanosleep",
                "ip": "0x7f66747167f8",
                "line": 78,
                "path": "/usr/lib/x86_64-linux-gnu/libc.so.6",
                "relative_address": "0x00000000000e57f8",
                "sp": "0x7f667441bc20"
              },
              {
                "build_id": "4f7b0c955c3d81d7cac1501a2498b69d1d82bfe7",
                "build_id_type": "GNU",
                "column": 6,
                "file": "./posix/../sysdeps/unix/sysv/linux/nanosleep.c",
                "file_type": "ELF",
                "function": "__GI___nanosleep",
                "ip": "0x7f667471b677",
                "line": 26,
                "path": "/usr/lib/x86_64-linux-gnu/libc.so.6",
                "relative_address": "0x00000000000ea677",
                "sp": "0x7f667441bca0"
              },
              {
                "build_id": "b10b0322a537ba24c56ac2c6d47f6f4535678851",
                "build_id_type": "GNU",
                "column": 5,
                "file": "/rustc/ded5c06cf21d2b93bffd5d884aa6e96934ee4234/library/std/src/thread/mod.rs",
                "file_type": "ELF",
                "function": "std::thread::sleep",
                "ip": "0x6498ceabe090",
                "line": 889,
                "path": "/home/bits/go/src/github.com/DataDog/libdatadog/target/release/crashtracker_bin_test",
                "relative_address": "0x0000000000085090",
                "sp": "0x7f667441bcb0"
              },
              {
                "build_id": "b10b0322a537ba24c56ac2c6d47f6f4535678851",
                "build_id_type": "GNU",
                "column": 2,
                "file": "/home/bits/go/src/github.com/DataDog/libdatadog/bin_tests/src/modes/unix/test_017_multi_thread_collection.rs",
                "file_type": "ELF",
                "function": "wait_for_work_0",
                "ip": "0x6498cea6fab7",
                "line": 30,
                "path": "/home/bits/go/src/github.com/DataDog/libdatadog/target/release/crashtracker_bin_test",
                "relative_address": "0x0000000000036ab7",
                "sp": "0x7f667441bd30"
              },
              {
                "build_id": "b10b0322a537ba24c56ac2c6d47f6f4535678851",
                "build_id_type": "GNU",
                "column": 2,
                "file": "/home/bits/go/src/github.com/DataDog/libdatadog/bin_tests/src/modes/unix/test_017_multi_thread_collection.rs",
                "file_type": "ELF",
                "function": "worker_entry_0",
                "ip": "0x6498cea6fa9e",
                "line": 36,
                "path": "/home/bits/go/src/github.com/DataDog/libdatadog/target/release/crashtracker_bin_test",
                "relative_address": "0x0000000000036a9e",
                "sp": "0x7f667441bd40"
              },
              {
                "build_id": "b10b0322a537ba24c56ac2c6d47f6f4535678851",
                "build_id_type": "GNU",
                "column": 18,
                "file": "/home/bits/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/sys/backtrace.rs",
                "file_type": "ELF",
                "function": "__rust_begin_short_backtrace<bin_tests::modes::unix::test_017_multi_thread_collection::{impl#0}::post::{closure_env#1}, ()>",
                "ip": "0x6498cea6fa05",
                "line": 158,
                "path": "/home/bits/go/src/github.com/DataDog/libdatadog/target/release/crashtracker_bin_test",
                "relative_address": "0x0000000000036a05",
                "sp": "0x7f667441bd50"
              },
              {
                "build_id": "b10b0322a537ba24c56ac2c6d47f6f4535678851",
                "build_id_type": "GNU",
                "column": 5,
                "file": "/home/bits/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/ops/function.rs",
                "file_type": "ELF",
                "function": "call_once<std::thread::{impl#0}::spawn_unchecked_::{closure_env#1}<bin_tests::modes::unix::test_017_multi_thread_collection::{impl#0}::post::{closure_env#1}, ()>, ()>",
                "ip": "0x6498cea6f83c",
                "line": 250,
                "path": "/home/bits/go/src/github.com/DataDog/libdatadog/target/release/crashtracker_bin_test",
                "relative_address": "0x000000000003683c",
                "sp": "0x7f667441bd70"
              },
              {
                "build_id": "b10b0322a537ba24c56ac2c6d47f6f4535678851",
                "build_id_type": "GNU",
                "column": 17,
                "file": "/rustc/ded5c06cf21d2b93bffd5d884aa6e96934ee4234/library/std/src/sys/thread/unix.rs",
                "file_type": "ELF",
                "function": "std::sys::thread::unix::Thread::new::thread_start",
                "ip": "0x6498ceabd0ff",
                "line": 126,
                "path": "/home/bits/go/src/github.com/DataDog/libdatadog/target/release/crashtracker_bin_test",
                "relative_address": "0x00000000000840ff",
                "sp": "0x7f667441bdf0"
              },
              {
                "build_id": "4f7b0c955c3d81d7cac1501a2498b69d1d82bfe7",
                "build_id_type": "GNU",
                "column": 8,
                "file": "./nptl/pthread_create.c",
                "file_type": "ELF",
                "function": "start_thread",
                "ip": "0x7f66746c5ac3",
                "line": 442,
                "path": "/usr/lib/x86_64-linux-gnu/libc.so.6",
                "relative_address": "0x0000000000094ac3",
                "sp": "0x7f667441be20"
              },
              {
                "build_id": "4f7b0c955c3d81d7cac1501a2498b69d1d82bfe7",
                "build_id_type": "GNU",
                "column": 0,
                "file": "./misc/../sysdeps/unix/sysv/linux/x86_64/clone3.S",
                "file_type": "ELF",
                "function": "__clone3",
                "ip": "0x7f66747578c0",
                "line": 83,
                "path": "/usr/lib/x86_64-linux-gnu/libc.so.6",
                "relative_address": "0x00000000001268c0",
                "sp": "0x7f667441bec0"
              }
            ],
            "incomplete": false
          },
          "state": "S"
        }
      ]

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

How to test the change?

Describe here in detail how the change can be validated.

@gyuheon0h Graphite App
Copy link
Copy Markdown
Contributor Author

gyuheon0h commented Apr 14, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@gyuheon0h gyuheon0h changed the title Collect all threads first pass feat(crashtracking)!: collect all threads Apr 14, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 14, 2026 •
edited
Loading

📚 Documentation Check Results

⚠️ 2711 documentation warning(s) found

📦 bin_tests - 1649 warning(s)

📦 libdd-crashtracker - 1062 warning(s)

Updated: 2026-04-27 14:25:58 UTC | Commit: f8f7d60 | missing-docs job results

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 14, 2026 •
edited
Loading

Clippy Allow Annotation Report

Comparing clippy allow annotations between branches:

  • Base Branch: origin/main
  • PR Branch: origin/gyuheon0h/PROF-14275-collect-all-threads

Summary by Rule

Rule Base Branch PR Branch Change

Annotation Counts by File

File Base Branch PR Branch Change

Annotation Stats by Crate

Crate Base Branch PR Branch Change
clippy-annotation-reporter 5 5 No change (0%)
datadog-ffe-ffi 1 1 No change (0%)
datadog-ipc 21 21 No change (0%)
datadog-live-debugger 6 6 No change (0%)
datadog-live-debugger-ffi 10 10 No change (0%)
datadog-profiling-replayer 4 4 No change (0%)
datadog-remote-config 3 3 No change (0%)
datadog-sidecar 56 56 No change (0%)
libdd-common 10 10 No change (0%)
libdd-common-ffi 12 12 No change (0%)
libdd-data-pipeline 5 5 No change (0%)
libdd-ddsketch 2 2 No change (0%)
libdd-dogstatsd-client 1 1 No change (0%)
libdd-profiling 13 13 No change (0%)
libdd-telemetry 19 19 No change (0%)
libdd-tinybytes 4 4 No change (0%)
libdd-trace-normalization 2 2 No change (0%)
libdd-trace-obfuscation 8 8 No change (0%)
libdd-trace-stats 1 1 No change (0%)
libdd-trace-utils 15 15 No change (0%)
Total 198 198 No change (0%)

About This Report

This report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 14, 2026 •
edited
Loading

🔒 Cargo Deny Results

⚠️ 8 issue(s) found, showing only errors (advisories, bans, sources)

📦 bin_tests - 4 error(s)

Show output 
error[unsound]: Rand is unsound with a custom logger using `rand::rng()`
    ┌─ /home/runner/work/libdatadog/libdatadog/Cargo.lock:201:1
    │
201 │ rand 0.8.5 registry+https://github.com/rust-lang/crates.io-index
    │ ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ unsound advisory detected
    │
    ├ ID: RUSTSEC-2026-0097
    ├ Advisory: https://rustsec.org/advisories/RUSTSEC-2026-0097
    ├ It has been reported (by @lopopolo) that the `rand` library is [unsound](https://rust-lang.github.io/unsafe-code-guidelines/glossary.html#soundness-of-code--of-a-library) (i.e. that safe code using the public API can cause Undefined Behaviour) when all the following conditions are met:
      
      - The `log` and `thread_rng` features are enabled
      - A [custom logger](https://docs.rs/log/latest/log/#implementing-a-logger) is defined
      - The custom logger accesses `rand::rng()` (previously `rand::thread_rng()`) and calls any `TryRng` (previously `RngCore`) methods on `ThreadRng`
      - The `ThreadRng` (attempts to) reseed while called from the custom logger (this happens every 64 kB of generated data)
      - Trace-level logging is enabled or warn-level logging is enabled and the random source (the `getrandom` crate) is unable to provide a new seed
      
      `TryRng` (previously `RngCore`) methods for `ThreadRng` use `unsafe` code to cast `*mut BlockRng<ReseedingCore>` to `&mut BlockRng<ReseedingCore>`. When all the above conditions are met this results in an aliased mutable reference, violating the Stacked Borrows rules. Miri is able to detect this violation in sample code. Since construction of [aliased mutable references is Undefined Behaviour](https://doc.rust-lang.org/stable/nomicon/references.html), the behaviour of optimized builds is hard to predict.
    ├ Announcement: https://github.com/rust-random/rand/pull/1763
    ├ Solution: Upgrade to >=0.10.1 OR <0.10.0, >=0.9.3 OR <0.9.0, >=0.8.6 (try `cargo update -p rand`)
    ├ rand v0.8.5
      ├── (dev) libdd-common v4.0.0
      │   ├── bin_tests v0.1.0
      │   ├── (build) libdd-crashtracker v1.0.0
      │   │   └── bin_tests v0.1.0 (*)
      │   ├── libdd-profiling v1.0.0
      │   │   ├── bin_tests v0.1.0 (*)
      │   │   └── (dev) libdd-profiling v1.0.0 (*)
      │   ├── libdd-shared-runtime v0.1.0
      │   │   └── libdd-telemetry v4.0.0
      │   │       └── libdd-crashtracker v1.0.0 (*)
      │   └── libdd-telemetry v4.0.0 (*)
      ├── libdd-crashtracker v1.0.0 (*)
      ├── libdd-profiling v1.0.0 (*)
      └── proptest v1.5.0
          └── (dev) libdd-profiling v1.0.0 (*)

error[vulnerability]: Name constraints for URI names were incorrectly accepted
    ┌─ /home/runner/work/libdatadog/libdatadog/Cargo.lock:226:1
    │
226 │ rustls-webpki 0.103.10 registry+https://github.com/rust-lang/crates.io-index
    │ ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ security vulnerability detected
    │
    ├ ID: RUSTSEC-2026-0098
    ├ Advisory: https://rustsec.org/advisories/RUSTSEC-2026-0098
    ├ Name constraints for URI names were ignored and therefore accepted.
      
      Note this library does not provide an API for asserting URI names, and URI name constraints are otherwise not implemented.  URI name constraints are now rejected unconditionally.
      
      Since name constraints are restrictions on otherwise properly-issued certificates, this bug is reachable only after signature verification and requires misissuance to exploit.
      
      This vulnerability is identified as [GHSA-965h-392x-2mh5](https://github.com/rustls/webpki/security/advisories/GHSA-965h-392x-2mh5). Thank you to @1seal for the report.
    ├ Solution: Upgrade to >=0.103.12, <0.104.0-alpha.1 OR >=0.104.0-alpha.6 (try `cargo update -p rustls-webpki`)
    ├ rustls-webpki v0.103.10
      ├── rustls v0.23.37
      │   ├── hyper-rustls v0.27.7
      │   │   ├── libdd-common v4.0.0
      │   │   │   ├── bin_tests v0.1.0
      │   │   │   ├── (build) libdd-crashtracker v1.0.0
      │   │   │   │   └── bin_tests v0.1.0 (*)
      │   │   │   ├── libdd-profiling v1.0.0
      │   │   │   │   ├── bin_tests v0.1.0 (*)
      │   │   │   │   └── (dev) libdd-profiling v1.0.0 (*)
      │   │   │   ├── libdd-shared-runtime v0.1.0
      │   │   │   │   └── libdd-telemetry v4.0.0
      │   │   │   │       └── libdd-crashtracker v1.0.0 (*)
      │   │   │   └── libdd-telemetry v4.0.0 (*)
      │   │   └── reqwest v0.13.2
      │   │       ├── libdd-common v4.0.0 (*)
      │   │       └── libdd-profiling v1.0.0 (*)
      │   ├── libdd-common v4.0.0 (*)
      │   ├── libdd-profiling v1.0.0 (*)
      │   ├── reqwest v0.13.2 (*)
      │   ├── rustls-platform-verifier v0.6.2
      │   │   ├── libdd-profiling v1.0.0 (*)
      │   │   └── reqwest v0.13.2 (*)
      │   └── tokio-rustls v0.26.0
      │       ├── hyper-rustls v0.27.7 (*)
      │       ├── libdd-common v4.0.0 (*)
      │       └── reqwest v0.13.2 (*)
      └── rustls-platform-verifier v0.6.2 (*)

error[vulnerability]: Name constraints were accepted for certificates asserting a wildcard name
    ┌─ /home/runner/work/libdatadog/libdatadog/Cargo.lock:226:1
    │
226 │ rustls-webpki 0.103.10 registry+https://github.com/rust-lang/crates.io-index
    │ ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ security vulnerability detected
    │
    ├ ID: RUSTSEC-2026-0099
    ├ Advisory: https://rustsec.org/advisories/RUSTSEC-2026-0099
    ├ Permitted subtree name constraints for DNS names were accepted for certificates asserting a wildcard name.
      
      This was incorrect because, given a name constraint of `accept.example.com`, `*.example.com` could feasibly allow a name of `reject.example.com` which is outside the constraint.
      This is very similar to [CVE-2025-61727](https://go.dev/issue/76442).
      
      Since name constraints are restrictions on otherwise properly-issued certificates, this bug is reachable only after signature verification and requires misissuance to exploit.
      
      This vulnerability is identified as [GHSA-xgp8-3hg3-c2mh](https://github.com/rustls/webpki/security/advisories/GHSA-xgp8-3hg3-c2mh). Thank you to @1seal for the report.
    ├ Solution: Upgrade to >=0.103.12, <0.104.0-alpha.1 OR >=0.104.0-alpha.6 (try `cargo update -p rustls-webpki`)
    ├ rustls-webpki v0.103.10
      ├── rustls v0.23.37
      │   ├── hyper-rustls v0.27.7
      │   │   ├── libdd-common v4.0.0
      │   │   │   ├── bin_tests v0.1.0
      │   │   │   ├── (build) libdd-crashtracker v1.0.0
      │   │   │   │   └── bin_tests v0.1.0 (*)
      │   │   │   ├── libdd-profiling v1.0.0
      │   │   │   │   ├── bin_tests v0.1.0 (*)
      │   │   │   │   └── (dev) libdd-profiling v1.0.0 (*)
      │   │   │   ├── libdd-shared-runtime v0.1.0
      │   │   │   │   └── libdd-telemetry v4.0.0
      │   │   │   │       └── libdd-crashtracker v1.0.0 (*)
      │   │   │   └── libdd-telemetry v4.0.0 (*)
      │   │   └── reqwest v0.13.2
      │   │       ├── libdd-common v4.0.0 (*)
      │   │       └── libdd-profiling v1.0.0 (*)
      │   ├── libdd-common v4.0.0 (*)
      │   ├── libdd-profiling v1.0.0 (*)
      │   ├── reqwest v0.13.2 (*)
      │   ├── rustls-platform-verifier v0.6.2
      │   │   ├── libdd-profiling v1.0.0 (*)
      │   │   └── reqwest v0.13.2 (*)
      │   └── tokio-rustls v0.26.0
      │       ├── hyper-rustls v0.27.7 (*)
      │       ├── libdd-common v4.0.0 (*)
      │       └── reqwest v0.13.2 (*)
      └── rustls-platform-verifier v0.6.2 (*)

error[vulnerability]: Reachable panic in certificate revocation list parsing
    ┌─ /home/runner/work/libdatadog/libdatadog/Cargo.lock:226:1
    │
226 │ rustls-webpki 0.103.10 registry+https://github.com/rust-lang/crates.io-index
    │ ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ security vulnerability detected
    │
    ├ ID: RUSTSEC-2026-0104
    ├ Advisory: https://rustsec.org/advisories/RUSTSEC-2026-0104
    ├ A panic was reachable when parsing certificate revocation lists via [`BorrowedCertRevocationList::from_der`]
      or [`OwnedCertRevocationList::from_der`].  This was the result of mishandling a syntactically valid empty
      `BIT STRING` appearing in the `onlySomeReasons` element of a `IssuingDistributionPoint` CRL extension.
      
      This panic is reachable prior to a CRL's signature being verified.
      
      Applications that do not use CRLs are not affected.
      
      Thank you to @tynus3 for the report.
    ├ Solution: Upgrade to >=0.103.13, <0.104.0-alpha.1 OR >=0.104.0-alpha.7 (try `cargo update -p rustls-webpki`)
    ├ rustls-webpki v0.103.10
      ├── rustls v0.23.37
      │   ├── hyper-rustls v0.27.7
      │   │   ├── libdd-common v4.0.0
      │   │   │   ├── bin_tests v0.1.0
      │   │   │   ├── (build) libdd-crashtracker v1.0.0
      │   │   │   │   └── bin_tests v0.1.0 (*)
      │   │   │   ├── libdd-profiling v1.0.0
      │   │   │   │   ├── bin_tests v0.1.0 (*)
      │   │   │   │   └── (dev) libdd-profiling v1.0.0 (*)
      │   │   │   ├── libdd-shared-runtime v0.1.0
      │   │   │   │   └── libdd-telemetry v4.0.0
      │   │   │   │       └── libdd-crashtracker v1.0.0 (*)
      │   │   │   └── libdd-telemetry v4.0.0 (*)
      │   │   └── reqwest v0.13.2
      │   │       ├── libdd-common v4.0.0 (*)
      │   │       └── libdd-profiling v1.0.0 (*)
      │   ├── libdd-common v4.0.0 (*)
      │   ├── libdd-profiling v1.0.0 (*)
      │   ├── reqwest v0.13.2 (*)
      │   ├── rustls-platform-verifier v0.6.2
      │   │   ├── libdd-profiling v1.0.0 (*)
      │   │   └── reqwest v0.13.2 (*)
      │   └── tokio-rustls v0.26.0
      │       ├── hyper-rustls v0.27.7 (*)
      │       ├── libdd-common v4.0.0 (*)
      │       └── reqwest v0.13.2 (*)
      └── rustls-platform-verifier v0.6.2 (*)

advisories FAILED, bans ok, sources ok

📦 libdd-crashtracker - 4 error(s)

Show output 
error[unsound]: Rand is unsound with a custom logger using `rand::rng()`
    ┌─ /home/runner/work/libdatadog/libdatadog/Cargo.lock:144:1
    │
144 │ rand 0.8.5 registry+https://github.com/rust-lang/crates.io-index
    │ ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ unsound advisory detected
    │
    ├ ID: RUSTSEC-2026-0097
    ├ Advisory: https://rustsec.org/advisories/RUSTSEC-2026-0097
    ├ It has been reported (by @lopopolo) that the `rand` library is [unsound](https://rust-lang.github.io/unsafe-code-guidelines/glossary.html#soundness-of-code--of-a-library) (i.e. that safe code using the public API can cause Undefined Behaviour) when all the following conditions are met:
      
      - The `log` and `thread_rng` features are enabled
      - A [custom logger](https://docs.rs/log/latest/log/#implementing-a-logger) is defined
      - The custom logger accesses `rand::rng()` (previously `rand::thread_rng()`) and calls any `TryRng` (previously `RngCore`) methods on `ThreadRng`
      - The `ThreadRng` (attempts to) reseed while called from the custom logger (this happens every 64 kB of generated data)
      - Trace-level logging is enabled or warn-level logging is enabled and the random source (the `getrandom` crate) is unable to provide a new seed
      
      `TryRng` (previously `RngCore`) methods for `ThreadRng` use `unsafe` code to cast `*mut BlockRng<ReseedingCore>` to `&mut BlockRng<ReseedingCore>`. When all the above conditions are met this results in an aliased mutable reference, violating the Stacked Borrows rules. Miri is able to detect this violation in sample code. Since construction of [aliased mutable references is Undefined Behaviour](https://doc.rust-lang.org/stable/nomicon/references.html), the behaviour of optimized builds is hard to predict.
    ├ Announcement: https://github.com/rust-random/rand/pull/1763
    ├ Solution: Upgrade to >=0.10.1 OR <0.10.0, >=0.9.3 OR <0.9.0, >=0.8.6 (try `cargo update -p rand`)
    ├ rand v0.8.5
      ├── libdd-common v4.0.0
      │   ├── (build) libdd-crashtracker v1.0.0
      │   ├── libdd-shared-runtime v0.1.0
      │   │   └── libdd-telemetry v4.0.0
      │   │       └── libdd-crashtracker v1.0.0 (*)
      │   └── libdd-telemetry v4.0.0 (*)
      └── libdd-crashtracker v1.0.0 (*)

error[vulnerability]: Name constraints for URI names were incorrectly accepted
    ┌─ /home/runner/work/libdatadog/libdatadog/Cargo.lock:158:1
    │
158 │ rustls-webpki 0.103.10 registry+https://github.com/rust-lang/crates.io-index
    │ ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ security vulnerability detected
    │
    ├ ID: RUSTSEC-2026-0098
    ├ Advisory: https://rustsec.org/advisories/RUSTSEC-2026-0098
    ├ Name constraints for URI names were ignored and therefore accepted.
      
      Note this library does not provide an API for asserting URI names, and URI name constraints are otherwise not implemented.  URI name constraints are now rejected unconditionally.
      
      Since name constraints are restrictions on otherwise properly-issued certificates, this bug is reachable only after signature verification and requires misissuance to exploit.
      
      This vulnerability is identified as [GHSA-965h-392x-2mh5](https://github.com/rustls/webpki/security/advisories/GHSA-965h-392x-2mh5). Thank you to @1seal for the report.
    ├ Solution: Upgrade to >=0.103.12, <0.104.0-alpha.1 OR >=0.104.0-alpha.6 (try `cargo update -p rustls-webpki`)
    ├ rustls-webpki v0.103.10
      └── rustls v0.23.37
          ├── hyper-rustls v0.27.7
          │   └── libdd-common v4.0.0
          │       ├── (build) libdd-crashtracker v1.0.0
          │       ├── libdd-shared-runtime v0.1.0
          │       │   └── libdd-telemetry v4.0.0
          │       │       └── libdd-crashtracker v1.0.0 (*)
          │       └── libdd-telemetry v4.0.0 (*)
          ├── libdd-common v4.0.0 (*)
          └── tokio-rustls v0.26.0
              ├── hyper-rustls v0.27.7 (*)
              └── libdd-common v4.0.0 (*)

error[vulnerability]: Name constraints were accepted for certificates asserting a wildcard name
    ┌─ /home/runner/work/libdatadog/libdatadog/Cargo.lock:158:1
    │
158 │ rustls-webpki 0.103.10 registry+https://github.com/rust-lang/crates.io-index
    │ ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ security vulnerability detected
    │
    ├ ID: RUSTSEC-2026-0099
    ├ Advisory: https://rustsec.org/advisories/RUSTSEC-2026-0099
    ├ Permitted subtree name constraints for DNS names were accepted for certificates asserting a wildcard name.
      
      This was incorrect because, given a name constraint of `accept.example.com`, `*.example.com` could feasibly allow a name of `reject.example.com` which is outside the constraint.
      This is very similar to [CVE-2025-61727](https://go.dev/issue/76442).
      
      Since name constraints are restrictions on otherwise properly-issued certificates, this bug is reachable only after signature verification and requires misissuance to exploit.
      
      This vulnerability is identified as [GHSA-xgp8-3hg3-c2mh](https://github.com/rustls/webpki/security/advisories/GHSA-xgp8-3hg3-c2mh). Thank you to @1seal for the report.
    ├ Solution: Upgrade to >=0.103.12, <0.104.0-alpha.1 OR >=0.104.0-alpha.6 (try `cargo update -p rustls-webpki`)
    ├ rustls-webpki v0.103.10
      └── rustls v0.23.37
          ├── hyper-rustls v0.27.7
          │   └── libdd-common v4.0.0
          │       ├── (build) libdd-crashtracker v1.0.0
          │       ├── libdd-shared-runtime v0.1.0
          │       │   └── libdd-telemetry v4.0.0
          │       │       └── libdd-crashtracker v1.0.0 (*)
          │       └── libdd-telemetry v4.0.0 (*)
          ├── libdd-common v4.0.0 (*)
          └── tokio-rustls v0.26.0
              ├── hyper-rustls v0.27.7 (*)
              └── libdd-common v4.0.0 (*)

error[vulnerability]: Reachable panic in certificate revocation list parsing
    ┌─ /home/runner/work/libdatadog/libdatadog/Cargo.lock:158:1
    │
158 │ rustls-webpki 0.103.10 registry+https://github.com/rust-lang/crates.io-index
    │ ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ security vulnerability detected
    │
    ├ ID: RUSTSEC-2026-0104
    ├ Advisory: https://rustsec.org/advisories/RUSTSEC-2026-0104
    ├ A panic was reachable when parsing certificate revocation lists via [`BorrowedCertRevocationList::from_der`]
      or [`OwnedCertRevocationList::from_der`].  This was the result of mishandling a syntactically valid empty
      `BIT STRING` appearing in the `onlySomeReasons` element of a `IssuingDistributionPoint` CRL extension.
      
      This panic is reachable prior to a CRL's signature being verified.
      
      Applications that do not use CRLs are not affected.
      
      Thank you to @tynus3 for the report.
    ├ Solution: Upgrade to >=0.103.13, <0.104.0-alpha.1 OR >=0.104.0-alpha.7 (try `cargo update -p rustls-webpki`)
    ├ rustls-webpki v0.103.10
      └── rustls v0.23.37
          ├── hyper-rustls v0.27.7
          │   └── libdd-common v4.0.0
          │       ├── (build) libdd-crashtracker v1.0.0
          │       ├── libdd-shared-runtime v0.1.0
          │       │   └── libdd-telemetry v4.0.0
          │       │       └── libdd-crashtracker v1.0.0 (*)
          │       └── libdd-telemetry v4.0.0 (*)
          ├── libdd-common v4.0.0 (*)
          └── tokio-rustls v0.26.0
              ├── hyper-rustls v0.27.7 (*)
              └── libdd-common v4.0.0 (*)

advisories FAILED, bans ok, sources ok

Updated: 2026-04-27 14:25:53 UTC | Commit: f8f7d60 | dependency-check job results

@datadog-datadog-prod-us1

This comment has been minimized.

Sign in to view
@gyuheon0h gyuheon0h force-pushed the gyuheon0h/PROF-14275-collect-all-threads branch 5 times, most recently from 6187d0a to 3f70266 Compare April 14, 2026 18:25
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 14, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 4.28212% with 380 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.38%. Comparing base (243aec1) to head (afee050).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1878      +/-   ##
==========================================
- Coverage   71.73%   71.38%   -0.36%     
==========================================
  Files         434      436       +2     
  Lines       69951    70343     +392     
==========================================
+ Hits        50182    50214      +32     
- Misses      19769    20129     +360
Components Coverage Δ
libdd-crashtracker 63.26% <4.08%> (-2.70%) ⬇️
libdd-crashtracker-ffi 35.75% <ø> (+1.65%) ⬆️
libdd-alloc 98.77% <ø> (ø)
libdd-data-pipeline 85.86% <ø> (+0.21%) ⬆️
libdd-data-pipeline-ffi 71.94% <ø> (+1.23%) ⬆️
libdd-common 79.41% <ø> (ø)
libdd-common-ffi 73.87% <ø> (ø)
libdd-telemetry 68.09% <ø> (+0.02%) ⬆️
libdd-telemetry-ffi 19.37% <ø> (ø)
libdd-dogstatsd-client 82.64% <ø> (ø)
datadog-ipc 76.26% <ø> (-0.05%) ⬇️
libdd-profiling 81.61% <ø> (+0.01%) ⬆️
libdd-profiling-ffi 64.36% <ø> (ø)
datadog-sidecar 28.86% <ø> (-0.27%) ⬇️
datdog-sidecar-ffi 6.12% <ø> (-1.08%) ⬇️
spawn-worker 54.69% <ø> (ø)
libdd-tinybytes 93.16% <ø> (ø)
libdd-trace-normalization 81.71% <ø> (ø)
libdd-trace-obfuscation 87.26% <ø> (ø)
libdd-trace-protobuf 68.25% <ø> (ø)
libdd-trace-utils 89.27% <ø> (ø)
datadog-tracer-flare 86.88% <ø> (ø)
libdd-log 74.69% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented Apr 14, 2026 •
edited
Loading

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 83.32 MB 83.52 MB +.24% (+205.48 KB) 🔍
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 7.63 MB 7.63 MB 0% (0 B) 👌
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 99.40 MB 99.64 MB +.24% (+249.33 KB) 🔍
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 10.10 MB 10.17 MB +.66% (+69.02 KB) 🔍
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 25.18 MB 25.18 MB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 79.90 KB 79.90 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 184.43 MB 184.37 MB --.02% (-56.00 KB) 💪
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 917.54 MB 917.54 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 7.89 MB 7.89 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 79.90 KB 79.90 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 23.67 MB 23.67 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 46.18 MB 46.18 MB 0% (0 B) 👌
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 21.65 MB 21.65 MB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 81.14 KB 81.14 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 188.48 MB 188.46 MB --.01% (-24.00 KB) 💪
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 902.85 MB 902.85 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 6.13 MB 6.13 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 81.14 KB 81.14 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 25.35 MB 25.35 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 43.67 MB 43.67 MB 0% (0 B) 👌
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 74.42 MB 74.62 MB +.26% (+198.28 KB) 🔍
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 8.52 MB 8.54 MB +.18% (+16.00 KB) 🔍
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 91.77 MB 91.99 MB +.23% (+224.86 KB) 🔍
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 10.20 MB 10.22 MB +.22% (+23.49 KB) 🔍

@gyuheon0h gyuheon0h force-pushed the gyuheon0h/PROF-14275-collect-all-threads branch 3 times, most recently from e96cb1a to 42d4665 Compare April 15, 2026 14:29
@gyuheon0h gyuheon0h changed the title feat(crashtracking)!: collect all threads [WIP WIP WIP WIP WIP WIP] feat(crashtracking)!: collect all threads Apr 15, 2026
@gyuheon0h gyuheon0h force-pushed the gyuheon0h/PROF-14275-collect-all-threads branch 4 times, most recently from 25853ed to a4b82cb Compare April 20, 2026 16:55
@gyuheon0h gyuheon0h changed the title [WIP WIP WIP WIP WIP WIP] feat(crashtracking)!: collect all threads feat(crashtracking)!: collect all threads Apr 20, 2026
@gyuheon0h gyuheon0h force-pushed the gyuheon0h/PROF-14275-collect-all-threads branch 4 times, most recently from 4536ffb to 5810ff0 Compare April 24, 2026 17:02
@gyuheon0h gyuheon0h force-pushed the gyuheon0h/PROF-14275-collect-all-threads branch 6 times, most recently from ddd4ab6 to afee050 Compare April 27, 2026 14:24
@gyuheon0h gyuheon0h force-pushed the gyuheon0h/PROF-14275-collect-all-threads branch from afee050 to e5c63df Compare April 27, 2026 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

crashtracker

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gyuheon0h @codecov-commenter