feat(telemetry)!: include dependencies and integrations in app-extended-heartbeat#1962
Conversation
cataphract
force-pushed
the
glopes/fix-extended-hearbeat
branch
from
aef8944 to
c8ebfa9
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aef89441ab
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| self.data | ||
| .dependencies | ||
| .removed_flushed(p.dependencies.len()); | ||
| self.data | ||
| .integrations | ||
| .removed_flushed(p.integrations.len()); |
There was a problem hiding this comment.
When dependencies or integrations are recorded before Lifecycle(Start), build_app_started() now copies them into the app-started payload and this success path immediately removes them from the unflushed queues. Since build_app_events_batch() only emits app-dependencies-loaded/app-integrations-change for items still marked unflushed, those startup items are never sent under their normal request types after a successful start; agents/backends that rely on those payloads will lose dependency and integration data. The extended-heartbeat resend needs its own payload/success handling instead of draining these queues for AppStarted.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
The whole point is to send integrations/deps on app-started rather than the subsequent events.
Also, the last sentence is completely unsubstantiated -- doesn't explain why its own payload/success handling would be needed. Given that the messages have the same shape and AppExtendedHeartbeat literally wraps data::AppStarted, I see no reason why that would be the case.
Clippy Allow Annotation ReportComparing clippy allow annotations between branches:
Summary by Rule
Annotation Counts by File
Annotation Stats by Crate
About This ReportThis report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality. |
cataphract
changed the title
cataphract
force-pushed
the
glopes/fix-extended-hearbeat
branch
from
c8ebfa9 to
a918d31
Compare
…-heartbeat Per the instrumentation-telemetry-api-docs schema, app-extended-heartbeat must carry the full state — configuration, dependencies, and integrations — so the agent can reconstruct application records on data loss. dd-trace-go and dd-trace-dotnet both ship the full triple. The Rust worker, however, defines AppStarted as a configuration-only struct and reuses it for app-extended-heartbeat, so dependencies and integrations are not included in the heartbeat payload. The ExtendedHeartbeat handler does call unflush_stored() on all three collectors, evidently with the intent of re-emitting the full state. Because the heartbeat payload omits the re-queued dependencies and integrations and app_started_sent_success only pops configurations from unflushed, the re-queued items remain in unflushed and are sent on the next FlushData as a duplicate app-integrations-change / app-dependencies-loaded. Updating the shared AppStarted struct, build_app_started, and app_started_sent_success addresses both Lifecycle(Start) and Lifecycle(ExtendedHeartbeat) call sites. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
cataphract
force-pushed
the
glopes/fix-extended-hearbeat
branch
from
a918d31 to
f483992
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1962 +/- ##
==========================================
- Coverage 71.79% 71.68% -0.12%
==========================================
Files 434 437 +3
Lines 70598 71164 +566
==========================================
+ Hits 50687 51014 +327
- Misses 19911 20150 +239
🚀 New features to boost your workflow:
|
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: f483992 | Docs | Datadog PR Page | Give us feedback! |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
gh-worker-dd-mergequeue-cf854d
Bot
deleted the
glopes/fix-extended-hearbeat
branch
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
3 participants
Per the instrumentation-telemetry-api-docs schema, app-extended-heartbeat must carry the full state — configuration, dependencies, and integrations — so the agent can reconstruct application records on data loss. dd-trace-go and dd-trace-dotnet both ship the full triple. The Rust worker, however, defines AppStarted as a configuration-only struct and reuses it for app-extended-heartbeat, so dependencies and integrations are not included in the heartbeat payload.
The ExtendedHeartbeat handler does call unflush_stored() on all three collectors, evidently with the intent of re-emitting the full state. Because the heartbeat payload omits the re-queued dependencies and integrations and app_started_sent_success only pops configurations from unflushed, the re-queued items remain in unflushed and are sent on the next FlushData as a duplicate app-integrations-change / app-dependencies-loaded.
Updating the shared AppStarted struct, build_app_started, and app_started_sent_success addresses both Lifecycle(Start) and Lifecycle(ExtendedHeartbeat) call sites.
How to test the change?
Tested in DataDog/dd-trace-php#3865 . Fixes an integration test and adds a new one to validate the behavior more thoroughly.