ci: upload all 62 RUM variants on tag releases#365
Draft
pawelchcki wants to merge 1 commit into
Draft
Conversation
Hooks the existing build-nginx-rum-all matrix (every supported nginx version × amd64/arm64 = 62 jobs) into the snapshot-upload pipeline, so tag releases publish full-coverage snapshots to S3: s3://rum-auto-instrumentation/nginx/snapshots/pipeline-<id>/ s3://rum-auto-instrumentation/nginx/snapshots/latest/ Splits .upload-rum-snapshot-template (no needs) and a fast-specific .upload-rum-snapshot-fast variant so the all-pipeline jobs can rely on stage ordering (the 62-entry matrix exceeds GitLab's 50-need limit, same workaround already used by ssi-build-all).
There was a problem hiding this comment.
Pull request overview
This PR updates the GitLab CI configuration so that tag releases (vX.Y.Z) upload RUM-enabled nginx module snapshot artifacts for the full 62-variant matrix, while keeping the existing “fast” snapshot uploads for branch/default-branch pipelines.
Changes:
- Refactors the RUM snapshot upload job template into a transport-only template plus a “fast” variant that adds the
needs:wiring. - Adds tag-only (
vX.Y.Z) “all variants” snapshot upload jobs that rely on stage ordering instead ofneeds:to avoid GitLab’s 50-needs limit. - Reuses the existing upload script/template across both fast and all pipelines.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.gitlab/build-and-test-fast.yml |
Splits the upload template and reattaches needs: only for the fast snapshot upload jobs. |
.gitlab/build-and-test-all.yml |
Adds tag-only snapshot upload jobs for the full 62-entry build-nginx-rum-all matrix, using stage ordering instead of needs:. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| .upload-rum-snapshot-all: | ||
| extends: | ||
| - .build-and-test-all | ||
| - .upload-rum-snapshot-template |
🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: bc4d0dc | Docs | Datadog PR Page | Give us feedback! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #363.
Summary
build-nginx-rum-allmatrix into the snapshot upload pipeline so tag releases publish RUM modules for every supported nginx version × arch..upload-rum-snapshot-template(transport only) and.upload-rum-snapshot-fast(adds fast-specificneeds:); the new all-pipeline jobs rely on stage ordering instead, matching the existingssi-build-allworkaround for GitLab's 50-need limit.What runs where
upload-rum-branch-snapshots(fast)nginx/branch-snapshots/pipeline-<id>/upload-rum-snapshots,upload-rum-snapshots-latest(fast)nginx/snapshots/pipeline-<id>/,nginx/snapshots/latest/upload-rum-snapshots-all,upload-rum-snapshots-latest-allnginx/snapshots/pipeline-<id>/,nginx/snapshots/latest/Test plan
nginx/snapshots/pipeline-<id>/andnginx/snapshots/latest/