Skip to content

Fix yaml syntax for threshold with warning_range#383

Merged
xlamorlette-datadog merged 1 commit into
masterfrom
xlamorlette/fix-check-slo-breaches
May 19, 2026
Merged

Fix yaml syntax for threshold with warning_range#383
xlamorlette-datadog merged 1 commit into
masterfrom
xlamorlette/fix-check-slo-breaches

Conversation

@xlamorlette-datadog

@xlamorlette-datadog xlamorlette-datadog commented May 19, 2026

Copy link
Copy Markdown
Contributor

As stated in IDMPL-457 Nginx: master CI: check-slo-breaches broken, since April 16, the check-slo-breaches CI job used to fail.
This was due to an invalid yaml syntax when using a pre-threshold warning_range.

Example of failure before the fix:

$ bp-runner $SLO_FILE
Running on a Linux distro
bp-runner v2026.5.5
mapping values are not allowed here
  in ".gitlab/bp-runner.fail-on-breach.yml", line 17, column 30
2026-05-19 08:26:43,139 [ERROR] bp-runner.src.execution.runner - 'NoneType' object has no attribute 'setup'

Success in the benchmark pipeline manually triggered in this PR:

$ bp-runner $SLO_FILE
Running on a Linux distro
bp-runner v2026.5.5
2026-05-19 12:16:52,851 [INFO] bp-runner.src.templates.fail_on_breach - Generating Markdown threshold comparison report for CI logs...
Benchmark execution time: 2026-05-19 12:16:54
Comparing candidate commit 50bd3ca156cea2e081e58acc9207df9e06e154cf in branch `xlamorlette/fix-check-slo-breaches` with performance thresholds.
#### high_load--only-tracing
- 🟩 `throughput` seen in benchmark [3979.843op/s; 4084.471op/s]; SLO is > 3700.000op/s
#### normal_operation--only-tracing
- 🟨 `agg_http_req_duration_p50` seen in benchmark [114.488µs; 114.730µs]; SLO is < 116.000µs (warning threshold is 113.680µs)

@datadog-prod-us1-5

datadog-prod-us1-5 Bot commented May 19, 2026

Copy link
Copy Markdown

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 67.62% (+0.00%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 50bd3ca | Docs | Datadog PR Page | Give us feedback!

@xlamorlette-datadog xlamorlette-datadog force-pushed the xlamorlette/fix-check-slo-breaches branch from 1d49f1b to 50bd3ca Compare May 19, 2026 11:59
@xlamorlette-datadog xlamorlette-datadog changed the title fix yaml syntax for threshold with warning_range Fix yaml syntax for threshold with warning_range May 19, 2026
@xlamorlette-datadog xlamorlette-datadog marked this pull request as ready for review May 19, 2026 12:45
@xlamorlette-datadog xlamorlette-datadog requested a review from a team as a code owner May 19, 2026 12:45
@xlamorlette-datadog xlamorlette-datadog merged commit 30d84cc into master May 19, 2026
179 checks passed
@xlamorlette-datadog xlamorlette-datadog deleted the xlamorlette/fix-check-slo-breaches branch May 19, 2026 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants