[PROF-13798] Add quota-exceeded to profiling error_reason#382
Draft
thomasbertet wants to merge 1 commit into
Draft
[PROF-13798] Add quota-exceeded to profiling error_reason#382thomasbertet wants to merge 1 commit into
thomasbertet wants to merge 1 commit into
Conversation
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The browser profiler SDK now stops profiling when the quota admission API returns HTTP 429, and sets
_dd.profiling.error_reason: 'quota-exceeded'on RUM events.Related SDK PR: DataDog/browser-sdk#4514
Ticket: PROF-13798
Changes
schemas/rum/_profiling-internal-context-schema.json: addsquota-exceededto theerror_reasonenum; updates the description to clarify thaterror_reasoncan also be set whenstatus === 'stopped'(not onlyerror).lib/cjs/generated/rum.d.ts,lib/esm/generated/rum.d.ts: regenerated —error_reasonunion now includes'quota-exceeded'.Follow-up in browser-sdk
Once this PR is merged,
browser-sdkneedsyarn json-schemas:syncto pull in the updated types.