Add websocket resource type#388
Draft
bdibon wants to merge 1 commit into
Draft
Conversation
bdibon
force-pushed
the
boris.dibon/add-websocket-resource-type-01
branch
2 times, most recently
from
5fc8d13 to
e239431
Compare
This comment has been minimized.
This comment has been minimized.
Add websocket setup_duration field Co-authored-by: Cursor <cursoragent@cursor.com> Update websocket fields
bdibon
force-pushed
the
boris.dibon/add-websocket-resource-type-01
branch
from
a597e6d to
94d4261
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Define the
websocketresource type and the nestedresource.websocketobject so the browser RUM SDK can emit a singleRumResourceEventper WebSocket lifetime.This is part of a prototype WebSocket instrumentation on the browser SDK, the format of WebSocket resources is still experimental.
Changes
"websocket"to theresource.typeenum inschemas/rum/resource-schema.json.resource.websocketobject underresource.properties, with fields covering connection identity, closure, aggregated message stats and the negotiated sub-protocol.Test instructions
yarn validate— all RUM/session-replay/telemetry samples must validate against the updated schema (no sample uses the new fields yet, so this only confirms backward compatibility).Checklist
yarn validate).