chore: fix cargo audit errors and warnings, cargo clippy warnings#117
Open
duncanpharvey wants to merge 3 commits intomainfrom
Open
chore: fix cargo audit errors and warnings, cargo clippy warnings#117duncanpharvey wants to merge 3 commits intomainfrom
duncanpharvey wants to merge 3 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Rust dependencies and applies small code cleanups to address cargo audit findings and cargo clippy warnings in the datadog-trace-agent crate.
Changes:
- Bumped
rustls-webpki(via lockfile) to a patched version and refreshed the lockfile. - Updated the
duplicatedev-dependency to avoidproc-macro-errorand refreshed 3rd-party license entries. - Fixed clippy warnings in
mini_agent.rs(unused import, collapsibleif).
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| crates/datadog-trace-agent/src/mini_agent.rs | Removes unused warn import and collapses nested if when creating the Lambda Lite sentinel directory. |
| crates/datadog-trace-agent/Cargo.toml | Updates duplicate dev-dependency version. |
| LICENSE-3rdparty.csv | Removes obsolete/duplicate license entries aligned with the updated dependency set. |
| Cargo.lock | Updates locked dependency graph to pull in patched/unmaintained replacements (incl. rustls-webpki), and removes proc-macro-error. |
Comment on lines
192
to
193
| // SAFETY: LAMBDA_LITE_SENTINEL_PATH is a hard-coded absolute path, | ||
| // so .parent() always returns Some. |
There was a problem hiding this comment.
The // SAFETY: note here is misleading: this block contains no unsafe, and the code now explicitly handles the None case via if let Some(parent) = .... Consider changing the comment to a non-"SAFETY" phrasing (e.g., // NOTE:) and/or making the code match the claim by using expect/unwrap with a clear message if .parent() is ever None.
Suggested change
| // SAFETY: LAMBDA_LITE_SENTINEL_PATH is a hard-coded absolute path, | |
| // so .parent() always returns Some. | |
| // NOTE: LAMBDA_LITE_SENTINEL_PATH is expected to be a hard-coded | |
| // absolute path; use `if let Some(...)` here to handle the parent | |
| // directory defensively. |
kathiehuang
approved these changes
Apr 17, 2026
duncanista
approved these changes
Apr 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
cargo audit
cargo clippy
Additional Notes
Describe how to test/QA your changes
Unit and integration tests