chore: remove monitors test from pr workflow (#695)

* chore: remove monitors test from pr workflow

* rename integration_tests to snapshot_tests

Author: ava-silver

.github/workflows/integration_tests.yml .github/workflows/snapshot_tests.yml.github/workflows/integration_tests.yml renamed to .github/workflows/snapshot_tests.yml

@@ -1,12 +1,12 @@
-name: integration-tests
+name: snapshot-tests
 
 on:
   push:
     branches: [main]
   pull_request:
 
 jobs:
-  integration-tests:
+  snapshot-tests:
     runs-on: ubuntu-latest
 
     steps:
@@ -35,10 +35,5 @@ jobs:
         env:
           AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
           AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
-        run: ./scripts/run_integration_tests.sh
+        run: ./scripts/run_snapshot_tests.sh
 
-      - name: Test getting recommended monitors
-        env:
-          DD_API_KEY: ${{ secrets.DD_API_KEY }}
-          DD_APP_KEY: ${{ secrets.DD_APP_KEY }}
-        run: npm run test:integration

jest.config.js

@@ -10,5 +10,5 @@ module.exports = {
   clearMocks: true,
   collectCoverageFrom: ["src/**/*.ts"],
   testRegex: "(src\\/).*(\\.spec\\.ts)$",
-  testPathIgnorePatterns: ["\\.snap$", "<rootDir>/node_modules/", "integration_tests/"],
+  testPathIgnorePatterns: ["\\.snap$", "<rootDir>/node_modules/", "snapshot_tests/"],
 };

jest.integration.config.js

@@ -9,5 +9,5 @@ module.exports = {
   testEnvironment: "<rootDir>/testEnvironment.js",
   clearMocks: true,
   collectCoverageFrom: ["src/**/*.ts"],
-  testRegex: ["(integration_tests\\/).*(\\.spec\\.ts)$"],
+  testRegex: ["(snapshot_tests\\/).*(\\.spec\\.ts)$"],
 };

package.json

@@ -10,7 +10,7 @@
     "prebuild": "./scripts/check_layers_json.sh",
     "build": "tsc",
     "test": "jest --config jest.config.js",
-    "test:integration": "jest ./integration_tests --config jest.integration.config.js",
+    "test:integration": "jest ./snapshot_tests --config jest.integration.config.js",
     "test:watch": "jest --watch",
     "coverage": "jest --coverage",
     "lint": "tslint --project tsconfig.json",

scripts/run_integration_tests.sh scripts/run_snapshot_tests.shscripts/run_integration_tests.sh renamed to scripts/run_snapshot_tests.sh

@@ -2,13 +2,13 @@
 
 # Usage - run commands from repo root:
 # To check if new changes to the plugin cause changes to any snapshots:
-#   ./scripts/run_integration_tests.sh
+#   ./scripts/run_snapshot_tests.sh
 # To regenerate snapshots:
-#   UPDATE_SNAPSHOTS=true ./scripts/run_integration_tests.sh
+#   UPDATE_SNAPSHOTS=true ./scripts/run_snapshot_tests.sh
 
 set -e
 
-# To add new tests create a new yml file in the 'integration_tests' directory, append it to the SERVERLESS_CONFIGS array as well as creating a name for the
+# To add new tests create a new yml file in the 'snapshot_tests' directory, append it to the SERVERLESS_CONFIGS array as well as creating a name for the
 # snapshots that will be compared in your test. Add those snapshot names to the TEST_SNAPSHOTS and CORRECT_SNAPSHOTS arrays.
 # Note: Each yml config, test, and correct snapshot file should be at the same index in their own array. e.g. All the files for the forwarder test are at index 0.
 #       In order for this script to work correctly these arrays should have the same amount of elements.
@@ -25,7 +25,7 @@ if [[ "$root_dir" =~ .*"serverless-plugin-datadog/scripts".* ]]; then
     exit 1
 fi
 
-integration_tests_dir="$root_dir/integration_tests"
+snapshot_tests_dir="$root_dir/snapshot_tests"
 if [ "$UPDATE_SNAPSHOTS" = "true" ]; then
     echo "Overwriting snapshots in this execution"
 fi
@@ -36,7 +36,7 @@ yarn build
 echo "Serverless Framework version:"
 serverless --version
 
-cd $integration_tests_dir
+cd $snapshot_tests_dir
 RAW_CFN_TEMPLATE=".serverless/cloudformation-template-update-stack.json"
 for ((i = 0; i < ${#SERVERLESS_CONFIGS[@]}; i++)); do
     echo "Running 'sls package' with ${SERVERLESS_CONFIGS[i]}"
@@ -68,17 +68,17 @@ for ((i = 0; i < ${#SERVERLESS_CONFIGS[@]}; i++)); do
     set +e # Dont exit right away if there is a diff in snapshots
     cd ..
 
-    python $scripts_dir/compare_snapshots.py $integration_tests_dir/${TEST_SNAPSHOTS[i]} $integration_tests_dir/${CORRECT_SNAPSHOTS[i]}
+    python $scripts_dir/compare_snapshots.py $snapshot_tests_dir/${TEST_SNAPSHOTS[i]} $snapshot_tests_dir/${CORRECT_SNAPSHOTS[i]}
     return_code=$?
     set -e
     if [ $return_code -eq 0 ]; then
         echo "SUCCESS: There were no differences between the ${TEST_SNAPSHOTS[i]} and ${CORRECT_SNAPSHOTS[i]}"
     else
         echo "FAILURE: There were differences between the ${TEST_SNAPSHOTS[i]} and ${CORRECT_SNAPSHOTS[i]}. Review the diff output above."
-        echo "If you expected the ${TEST_SNAPSHOTS[i]} to be different generate new snapshots by running this command from a development branch on your local repository: 'UPDATE_SNAPSHOTS=true ./scripts/run_integration_tests.sh'"
+        echo "If you expected the ${TEST_SNAPSHOTS[i]} to be different generate new snapshots by running this command from a development branch on your local repository: 'UPDATE_SNAPSHOTS=true ./scripts/run_snapshot_tests.sh'"
         exit 1
     fi
-    cd $integration_tests_dir
+    cd $snapshot_tests_dir
     echo "===================================="
 done
 exit 0