-
Notifications
You must be signed in to change notification settings - Fork 15
Expand file tree
/
Copy pathtest_span_sampling.py
More file actions
906 lines (818 loc) · 42.2 KB
/
test_span_sampling.py
File metadata and controls
906 lines (818 loc) · 42.2 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
import time
import json
import pytest
from utils.docker_fixtures.spec.trace import SAMPLING_PRIORITY_KEY
from utils.docker_fixtures.spec.trace import SINGLE_SPAN_SAMPLING_MAX_PER_SEC
from utils.docker_fixtures.spec.trace import SINGLE_SPAN_SAMPLING_MECHANISM
from utils.docker_fixtures.spec.trace import SINGLE_SPAN_SAMPLING_MECHANISM_VALUE
from utils.docker_fixtures.spec.trace import SINGLE_SPAN_SAMPLING_RATE
from utils.docker_fixtures.spec.trace import MANUAL_DROP_KEY
from utils.docker_fixtures.spec.trace import USER_KEEP
from utils.docker_fixtures.spec.trace import (
find_span_in_traces,
find_trace,
find_span,
find_first_span_in_trace_payload,
)
from utils import context, scenarios, features
from utils.docker_fixtures import TestAgentAPI
from .conftest import APMLibrary
@features.single_span_sampling
@scenarios.parametric
class Test_Span_Sampling:
@pytest.mark.parametrize(
"library_env",
[
{
"DD_SPAN_SAMPLING_RULES": json.dumps([{"service": "webserver", "name": "web.request"}]),
"DD_TRACE_SAMPLE_RATE": 0,
"DD_TRACE_SAMPLING_RULES": '[{"sample_rate":0}]',
}
],
)
def test_single_rule_match_span_sampling_sss001(self, test_agent: TestAgentAPI, test_library: APMLibrary):
"""Test that span sampling tags are added when both:
1. a span sampling rule matches
2. tracer is set to drop the trace manually
"""
with test_library, test_library.dd_start_span(name="web.request", service="webserver") as main_span:
pass
span = find_span_in_traces(test_agent.wait_for_num_traces(1), main_span.trace_id, main_span.span_id)
assert span["metrics"].get(SINGLE_SPAN_SAMPLING_RATE) == 1.0
assert span["metrics"].get(SINGLE_SPAN_SAMPLING_MECHANISM) == SINGLE_SPAN_SAMPLING_MECHANISM_VALUE
assert span["metrics"].get(SINGLE_SPAN_SAMPLING_MAX_PER_SEC) is None
@pytest.mark.parametrize(
"library_env",
[
{
"DD_SPAN_SAMPLING_RULES": json.dumps([{"service": "webse*", "name": "web.re?uest"}]),
"DD_TRACE_SAMPLE_RATE": 0,
"DD_TRACE_SAMPLING_RULES": '[{"sample_rate":0}]',
}
],
)
def test_special_glob_characters_span_sampling_sss002(self, test_agent: TestAgentAPI, test_library: APMLibrary):
"""Test span sampling tags are added when a rule with glob patterns with special characters * and ? match"""
with test_library, test_library.dd_start_span(name="web.request", service="webserver") as main_span:
pass
span = find_span_in_traces(test_agent.wait_for_num_traces(1), main_span.trace_id, main_span.span_id)
assert span["metrics"].get(SINGLE_SPAN_SAMPLING_RATE) == 1.0
assert span["metrics"].get(SINGLE_SPAN_SAMPLING_MECHANISM) == SINGLE_SPAN_SAMPLING_MECHANISM_VALUE
assert span["metrics"].get(SINGLE_SPAN_SAMPLING_MAX_PER_SEC) is None
@pytest.mark.parametrize(
"library_env",
[
{
"DD_SPAN_SAMPLING_RULES": json.dumps([{"service": "notmatching", "name": "notmatching"}]),
"DD_TRACE_SAMPLE_RATE": 0,
"DD_TRACE_SAMPLING_RULES": '[{"sample_rate":0}]',
"DD_TRACE_STATS_COMPUTATION_ENABLED": "false",
}
],
)
def test_single_rule_no_match_span_sampling_sss003(self, test_agent: TestAgentAPI, test_library: APMLibrary):
"""Test span sampling tags are not added when both:
1. a basic span sampling rule does not match
2. the tracer is set to drop the span manually
"""
with test_library, test_library.dd_start_span(name="web.request", service="webserver") as main_span:
pass
span = find_span_in_traces(test_agent.wait_for_num_traces(1), main_span.trace_id, main_span.span_id)
assert span["metrics"].get(SINGLE_SPAN_SAMPLING_RATE) is None
assert span["metrics"].get(SINGLE_SPAN_SAMPLING_MECHANISM) is None
assert span["metrics"].get(SINGLE_SPAN_SAMPLING_MAX_PER_SEC) is None
@pytest.mark.parametrize(
"library_env",
[
{
"DD_SPAN_SAMPLING_RULES": json.dumps([{"service": "webserver"}]),
"DD_TRACE_SAMPLE_RATE": 0,
"DD_TRACE_SAMPLING_RULES": '[{"sample_rate":0}]',
}
],
)
def test_single_rule_only_service_pattern_match_span_sampling_sss004(
self, test_agent: TestAgentAPI, test_library: APMLibrary
):
"""Test span sampling tags are added when both:
1. a span sampling rule that only has a service pattern matches
2. the tracer is set to drop the span manually
"""
with test_library, test_library.dd_start_span(name="web.request", service="webserver") as main_span:
pass
span = find_span_in_traces(test_agent.wait_for_num_traces(1), main_span.trace_id, main_span.span_id)
assert span["metrics"].get(SINGLE_SPAN_SAMPLING_RATE) == 1.0
assert span["metrics"].get(SINGLE_SPAN_SAMPLING_MECHANISM) == SINGLE_SPAN_SAMPLING_MECHANISM_VALUE
assert span["metrics"].get(SINGLE_SPAN_SAMPLING_MAX_PER_SEC) is None
@pytest.mark.parametrize(
"library_env",
[
{
"DD_SPAN_SAMPLING_RULES": json.dumps([{"name": "no_match"}]),
"DD_TRACE_SAMPLE_RATE": 0,
"DD_TRACE_SAMPLING_RULES": '[{"sample_rate":0}]',
"DD_TRACE_STATS_COMPUTATION_ENABLED": "false",
}
],
)
def test_single_rule_only_name_pattern_no_match_span_sampling_sss005(
self, test_agent: TestAgentAPI, test_library: APMLibrary
):
"""Test span sampling tags are not added when:
1. a span sampling rule that only has a name pattern does not match
2. the tracer is set to drop the span manually
"""
with test_library, test_library.dd_start_span(name="web.request", service="webserver") as main_span:
pass
span = find_span_in_traces(test_agent.wait_for_num_traces(1), main_span.trace_id, main_span.span_id)
assert span["metrics"].get(SINGLE_SPAN_SAMPLING_RATE) is None
assert span["metrics"].get(SINGLE_SPAN_SAMPLING_MECHANISM) is None
assert span["metrics"].get(SINGLE_SPAN_SAMPLING_MAX_PER_SEC) is None
@pytest.mark.parametrize(
"library_env",
[
{
"DD_SPAN_SAMPLING_RULES": json.dumps(
[
{"service": "webserver", "name": "web.request"},
{
"service": "webserver",
"name": "web.request",
"sample_rate": 0,
},
]
),
"DD_TRACE_SAMPLE_RATE": 0,
"DD_TRACE_SAMPLING_RULES": '[{"sample_rate":0}]',
}
],
)
def test_multi_rule_keep_drop_span_sampling_sss006(self, test_agent: TestAgentAPI, test_library: APMLibrary):
"""Test span sampling tags are added when the following are true:
1. the first span sampling rule matches and keeps
2. the second rule matches and drops due to sample rate
3. the tracer is set to drop the span manually
We're essentially testing that:
1. rules are assessed in order of their listing
2. that once a rule is matched, we do not try to match against further rules. We do this by assuming that the "sample_rate": 0 of the second rule, if matched against would cause the span to not have span sampling tags.
"""
with test_library, test_library.dd_start_span(name="web.request", service="webserver") as main_span:
pass
span = find_span_in_traces(test_agent.wait_for_num_traces(1), main_span.trace_id, main_span.span_id)
assert span["metrics"].get(SINGLE_SPAN_SAMPLING_RATE) == 1.0
assert span["metrics"].get(SINGLE_SPAN_SAMPLING_MECHANISM) == SINGLE_SPAN_SAMPLING_MECHANISM_VALUE
assert span["metrics"].get(SINGLE_SPAN_SAMPLING_MAX_PER_SEC) is None
@pytest.mark.parametrize(
"library_env",
[
{
"DD_SPAN_SAMPLING_RULES": json.dumps(
[
{
"service": "webserver",
"name": "web.request",
"sample_rate": 0,
},
{"service": "webserver", "name": "web.request"},
]
),
"DD_TRACE_SAMPLE_RATE": 0,
"DD_TRACE_SAMPLING_RULES": '[{"sample_rate":0}]',
"DD_TRACE_STATS_COMPUTATION_ENABLED": "false",
}
],
)
def test_multi_rule_drop_keep_span_sampling_sss007(self, test_agent: TestAgentAPI, test_library: APMLibrary):
"""Test span sampling tags are not added when both:
1. the first span sampling rule matches and drops due to sample rate
2. the second rule matches and keeps
3. the tracer is set to drop the span manually
We're essentially testing that:
1. rules are assessed in order of their listing
2. that once a rule is matched, we do not try to match against further rules. We do this by assuming that the "sample_rate": 0 of the first rule, will cause the span to not have span sampling tags.
"""
with test_library, test_library.dd_start_span(name="web.request", service="webserver") as main_span:
pass
span = find_span_in_traces(test_agent.wait_for_num_traces(1), main_span.trace_id, main_span.span_id)
assert span["metrics"].get(SINGLE_SPAN_SAMPLING_RATE) is None
assert span["metrics"].get(SINGLE_SPAN_SAMPLING_MECHANISM) is None
assert span["metrics"].get(SINGLE_SPAN_SAMPLING_MAX_PER_SEC) is None
@pytest.mark.parametrize(
"library_env",
[
{
"DD_SPAN_SAMPLING_RULES": json.dumps(
[
{
"service": "webserver",
"name": "web.request",
"max_per_second": 2,
}
]
),
"DD_TRACE_SAMPLE_RATE": 0,
"DD_TRACE_SAMPLING_RULES": '[{"sample_rate":0}]',
"DD_TRACE_STATS_COMPUTATION_ENABLED": "false",
}
],
)
def test_single_rule_rate_limiter_span_sampling_sss008(self, test_agent: TestAgentAPI, test_library: APMLibrary):
"""Test span sampling tags are added until rate limit hit, then need to wait for tokens to reset"""
# generate three traces before requesting them to avoid timing issues
trace_span_ids = []
with test_library:
for _ in range(6):
with test_library.dd_start_span(name="web.request", service="webserver") as s1:
pass
trace_span_ids.append((s1.trace_id, s1.span_id))
traces = test_agent.wait_for_num_traces(6, clear=True)
# expect first and second traces sampled
span = find_span_in_traces(traces[:1], trace_span_ids[0][0], trace_span_ids[0][1])
assert span["metrics"].get(SINGLE_SPAN_SAMPLING_RATE) == 1.0
assert span["metrics"].get(SINGLE_SPAN_SAMPLING_MECHANISM) == 8
assert span["metrics"].get(SINGLE_SPAN_SAMPLING_MAX_PER_SEC) == 2
span = find_span_in_traces(traces[1:2], trace_span_ids[1][0], trace_span_ids[1][1])
assert span["metrics"].get(SINGLE_SPAN_SAMPLING_MECHANISM) == 8
assert span["metrics"].get(SINGLE_SPAN_SAMPLING_MAX_PER_SEC) == 2
# Some issues related with timming. It's difficult to be so accurate and it can cause flakiness
# For example code in the Java tracer starts the clock as soon as the limiter is created.
# This means that even though all traces happen within ~59 ms, they could straddle two token buckets and hence all be allowed to pass
# Given 6 traces, at least the last two traces are unsampled because of rate limiters
span = find_span_in_traces(traces[5:6], trace_span_ids[5][0], trace_span_ids[5][1])
assert span["metrics"].get(SINGLE_SPAN_SAMPLING_RATE) is None
assert span["metrics"].get(SINGLE_SPAN_SAMPLING_MECHANISM) is None
assert span["metrics"].get(SINGLE_SPAN_SAMPLING_MAX_PER_SEC) is None
# wait a second for rate limiter tokens to replenish
time.sleep(2)
# now span should be kept by rule
with test_library, test_library.dd_start_span(name="web.request", service="webserver") as s2:
pass
span = find_span_in_traces(test_agent.wait_for_num_traces(1, clear=True), s2.trace_id, s2.span_id)
assert span["metrics"].get(SINGLE_SPAN_SAMPLING_RATE) == 1.0
assert span["metrics"].get(SINGLE_SPAN_SAMPLING_MECHANISM) == 8
assert span["metrics"].get(SINGLE_SPAN_SAMPLING_MAX_PER_SEC) == 2
@pytest.mark.parametrize(
"library_env",
[
{
"DD_SPAN_SAMPLING_RULES": json.dumps(
[
{
"service": "webserver",
"name": "web.request",
"sample_rate": 0.5,
}
]
),
"DD_TRACE_SAMPLE_RATE": 0,
"DD_TRACE_SAMPLING_RULES": '[{"sample_rate":0}]',
"DD_TRACE_STATS_COMPUTATION_ENABLED": "false",
}
],
)
def test_sampling_rate_not_absolute_value_sss009(self, test_agent: TestAgentAPI, test_library: APMLibrary):
"""Test sample rate comes close to expected number of spans sampled. We do this by setting the
sample_rate to 0.5, and then making sure that about half of the spans have span sampling tags and
half do not.
With 200 traces and a 0.5 sample rate, the expected number of sampled spans is 100
(std dev ~7.07). The acceptable range [60, 140] is ~5.7 standard deviations from the
mean, giving a theoretical failure probability of ~1 in 85 million.
"""
# make 200 new traces, each with one span
for _ in range(200):
with test_library, test_library.dd_start_span(name="web.request", service="webserver"):
pass
traces = test_agent.wait_for_num_traces(num=200)
assert len(traces) == 200
sampled = []
unsampled = []
for trace in traces:
span = find_first_span_in_trace_payload(trace)
if span["metrics"].get(SINGLE_SPAN_SAMPLING_MECHANISM) == SINGLE_SPAN_SAMPLING_MECHANISM_VALUE:
sampled.append(trace)
else:
unsampled.append(trace)
assert len(sampled) in range(60, 141)
assert len(unsampled) in range(60, 141)
@pytest.mark.parametrize(
"library_env",
[
{
"DD_SPAN_SAMPLING_RULES": json.dumps([{"service": "webserver", "name": "web.request"}]),
"DD_TRACE_SAMPLE_RATE": 0,
"DD_TRACE_SAMPLING_RULES": '[{"sample_rate":0}]',
"DD_TRACE_STATS_COMPUTATION_ENABLED": "True",
}
],
)
def test_keep_span_with_stats_computation_sss010(self, test_agent: TestAgentAPI, test_library: APMLibrary):
"""Test when stats computation is enabled and span sampling applied, spans have manual_keep and still sent."""
with test_library, test_library.dd_start_span(name="web.request", service="webserver") as s1:
pass
span = find_span_in_traces(test_agent.wait_for_num_traces(1), s1.trace_id, s1.span_id)
assert span["metrics"].get(SINGLE_SPAN_SAMPLING_RATE) == 1.0
assert span["metrics"].get(SINGLE_SPAN_SAMPLING_MECHANISM) == SINGLE_SPAN_SAMPLING_MECHANISM_VALUE
assert span["metrics"].get(SINGLE_SPAN_SAMPLING_MAX_PER_SEC) is None
# We should be setting sampling priority to manual keep so the agent sampler won't be affected
# TODO: we need a way to check that the chunk that contains the span was associated with USER_KEEP priority,
# the below does not apply to all agent APIs
assert span["metrics"].get(SAMPLING_PRIORITY_KEY) == USER_KEEP
@pytest.mark.parametrize(
"library_env",
[
{
"DD_SPAN_SAMPLING_RULES": json.dumps(
[
{
"service": "webserver",
"name": "web.request",
"sample_rate": 1.0,
}
]
),
"DD_TRACE_SAMPLE_RATE": 1.0,
"DD_TRACE_SAMPLING_RULES": '[{"sample_rate":1.0}]',
}
],
)
def test_single_rule_always_keep_span_sampling_sss011(self, test_agent: TestAgentAPI, test_library: APMLibrary):
"""Test that spans are always kept when the sampling rule matches and has sample_rate:1.0 regardless of tracer decision.
Basically, if we have a rule for spans with sample_rate:1.0 we should always keep those spans, either due to trace sampling or span sampling
"""
# This span is set to be dropped by the tracer/user, however it is kept by span sampling
with test_library, test_library.dd_start_span(name="web.request", service="webserver") as s1:
s1.set_meta(MANUAL_DROP_KEY, "1")
span = find_span_in_traces(test_agent.wait_for_num_traces(1, clear=True), s1.trace_id, s1.span_id)
assert span["metrics"].get(SINGLE_SPAN_SAMPLING_RATE) == 1.0
assert span["metrics"].get(SINGLE_SPAN_SAMPLING_MECHANISM) == SINGLE_SPAN_SAMPLING_MECHANISM_VALUE
assert span["metrics"].get(SINGLE_SPAN_SAMPLING_MAX_PER_SEC) is None
# This span is sampled by the tracer, not span sampling.
# Therefore it won't have the span sampling tags, but rather the trace sampling tags.
with test_library, test_library.dd_start_span(name="web.request", service="webserver") as s2:
pass
span = find_span_in_traces(test_agent.wait_for_num_traces(1, clear=True), s2.trace_id, s2.span_id)
assert span["metrics"].get(SINGLE_SPAN_SAMPLING_RATE) is None
assert span["metrics"].get(SINGLE_SPAN_SAMPLING_MECHANISM) is None
assert span["metrics"].get(SINGLE_SPAN_SAMPLING_MAX_PER_SEC) is None
assert span["metrics"].get(SAMPLING_PRIORITY_KEY) > 0
@pytest.mark.parametrize(
"library_env",
[
{
"DD_SPAN_SAMPLING_RULES": json.dumps(
[{"service": "webserver", "name": "web.request", "sample_rate": 0}]
),
"DD_TRACE_SAMPLE_RATE": 1.0,
"DD_TRACE_SAMPLING_RULES": '[{"sample_rate":1.0}]',
}
],
)
def test_single_rule_tracer_always_keep_span_sampling_sss012(
self, test_agent: TestAgentAPI, test_library: APMLibrary
):
"""Test spans are always kept when tracer keeps, regardless of span sampling rule set to drop.
We're essentially testing to make sure that the span sampling rule cannot control the fate of the span if the span is already being kept by trace sampling.
"""
# This span is sampled by the tracer, not span sampling, which would try to drop the span, so it's still kept because "_sampling_priority_v1" > 0
# When the trace is kept by trace sampling, span rules are not applied
with test_library, test_library.dd_start_span(name="web.request", service="webserver") as s1:
pass
span = find_span_in_traces(test_agent.wait_for_num_traces(1), s1.trace_id, s1.span_id)
assert span["metrics"].get(SINGLE_SPAN_SAMPLING_RATE) is None
assert span["metrics"].get(SINGLE_SPAN_SAMPLING_MECHANISM) is None
assert span["metrics"].get(SINGLE_SPAN_SAMPLING_MAX_PER_SEC) is None
assert span["metrics"].get(SAMPLING_PRIORITY_KEY) > 0
@pytest.mark.parametrize(
"library_env",
[
{
"DD_SPAN_SAMPLING_RULES": json.dumps(
[
{
"service": "webserver",
"name": "web.request",
"max_per_second": 1,
},
{
"service": "webserver2",
"name": "web.request2",
"max_per_second": 2,
},
]
),
"DD_TRACE_SAMPLE_RATE": 0,
"DD_TRACE_SAMPLING_RULES": '[{"sample_rate":0}]',
"DD_TRACE_STATS_COMPUTATION_ENABLED": "false",
}
],
)
def test_multi_rule_independent_rate_limiters_sss013(self, test_agent: TestAgentAPI, test_library: APMLibrary):
"""Span rule rate limiters are per-rule. So, spans that match different rules don't share a limiter, but
multiple traces whose spans match the same rule do share a limiter.
"""
# generate spans before requesting them to avoid timing issues
trace_and_span_ids = []
with test_library:
for _ in range(4):
with test_library.dd_start_span(name="web.request", service="webserver") as s1:
pass
trace_and_span_ids.append((s1.trace_id, s1.span_id))
for _ in range(6):
with test_library.dd_start_span(name="web.request2", service="webserver2") as s2:
pass
trace_and_span_ids.append((s2.trace_id, s2.span_id))
traces = test_agent.wait_for_num_traces(10, clear=True)
# Some issues related with timing. It's difficult to be so accurate and it can cause flakiness
# We check at least last trace is unsampled
span = find_span_in_traces(traces[:1], trace_and_span_ids[0][0], trace_and_span_ids[0][1])
assert span["metrics"].get(SINGLE_SPAN_SAMPLING_RATE) == 1.0
assert span["metrics"].get(SINGLE_SPAN_SAMPLING_MECHANISM) == SINGLE_SPAN_SAMPLING_MECHANISM_VALUE
assert span["metrics"].get(SINGLE_SPAN_SAMPLING_MAX_PER_SEC) == 1
span = find_span_in_traces(traces[3:4], trace_and_span_ids[3][0], trace_and_span_ids[3][1])
assert span["metrics"].get(SINGLE_SPAN_SAMPLING_RATE) is None
assert span["metrics"].get(SINGLE_SPAN_SAMPLING_MECHANISM) is None
assert span["metrics"].get(SINGLE_SPAN_SAMPLING_MAX_PER_SEC) is None
# for trace in traces[4:10]:
span = find_span_in_traces(traces[4:5], trace_and_span_ids[4][0], trace_and_span_ids[4][1])
assert span["metrics"].get(SINGLE_SPAN_SAMPLING_RATE) == 1.0
assert span["metrics"].get(SINGLE_SPAN_SAMPLING_MECHANISM) == SINGLE_SPAN_SAMPLING_MECHANISM_VALUE
assert span["metrics"].get(SINGLE_SPAN_SAMPLING_MAX_PER_SEC) == 2
span = find_span_in_traces(traces[5:6], trace_and_span_ids[5][0], trace_and_span_ids[5][1])
assert span["metrics"].get(SINGLE_SPAN_SAMPLING_RATE) == 1.0
assert span["metrics"].get(SINGLE_SPAN_SAMPLING_MECHANISM) == SINGLE_SPAN_SAMPLING_MECHANISM_VALUE
assert span["metrics"].get(SINGLE_SPAN_SAMPLING_MAX_PER_SEC) == 2
span = find_span_in_traces(traces[8:9], trace_and_span_ids[8][0], trace_and_span_ids[8][1])
assert span["metrics"].get(SINGLE_SPAN_SAMPLING_RATE) is None
assert span["metrics"].get(SINGLE_SPAN_SAMPLING_MECHANISM) is None
assert span["metrics"].get(SINGLE_SPAN_SAMPLING_MAX_PER_SEC) is None
# wait a couple of seconds for rate limiter tokens
time.sleep(2)
# Now span should be kept by first rule
with test_library, test_library.dd_start_span(name="web.request", service="webserver") as s3:
pass
span = find_span_in_traces(test_agent.wait_for_num_traces(1), s3.trace_id, s3.span_id)
assert span["metrics"].get(SINGLE_SPAN_SAMPLING_MAX_PER_SEC) == 1
@pytest.mark.parametrize(
"library_env",
[
{
"DD_SPAN_SAMPLING_RULES": json.dumps(
[
{
"service": "webserver",
"name": "parent",
"sample_rate": 1.0,
"max_per_second": 50,
}
]
),
"DD_TRACE_SAMPLE_RATE": 0,
"DD_TRACE_SAMPLING_RULES": '[{"sample_rate":0}]',
"DD_TRACE_STATS_COMPUTATION_ENABLED": "false",
}
],
)
def test_root_span_selected_by_sss014(self, test_agent: TestAgentAPI, test_library: APMLibrary):
"""Single spans selected by SSS must be kept and shouldn't affect child span sampling priority.
We're essentially testing to make sure that the span sampling rule keeps selected spans regardless of the trace sampling decision
and doesn't affect child spans that are dropped by the tracer sampling mechanism.
"""
with (
test_library,
test_library.dd_start_span(name="parent", service="webserver") as ps,
test_library.dd_start_span(name="child", service="webserver", parent_id=ps.span_id) as cs,
):
pass
traces = test_agent.wait_for_num_spans(2, clear=True)
parent_span = find_span_in_traces(traces, ps.trace_id, ps.span_id)
child_span = find_span_in_traces(traces, cs.trace_id, cs.span_id)
# the trace should be dropped, so the parent span priority is set to -1
assert parent_span["metrics"].get(SAMPLING_PRIORITY_KEY) == -1
assert parent_span["metrics"].get(SINGLE_SPAN_SAMPLING_RATE) == 1.0
assert parent_span["metrics"].get(SINGLE_SPAN_SAMPLING_MECHANISM) == SINGLE_SPAN_SAMPLING_MECHANISM_VALUE
assert parent_span["metrics"].get(SINGLE_SPAN_SAMPLING_MAX_PER_SEC) == 50
# child span should be dropped by defined trace sampling rules
if "metrics" in child_span:
assert child_span["metrics"].get(SINGLE_SPAN_SAMPLING_RATE) is None
assert child_span["metrics"].get(SINGLE_SPAN_SAMPLING_MECHANISM) is None
assert child_span["metrics"].get(SINGLE_SPAN_SAMPLING_MAX_PER_SEC) is None
if "meta" in child_span:
assert child_span["meta"].get("_dd.p.dm") is None
@pytest.mark.parametrize(
"library_env",
[
{
"DD_SPAN_SAMPLING_RULES": json.dumps(
[
{
"service": "webserver",
"name": "child",
"sample_rate": 1.0,
"max_per_second": 50,
}
]
),
"DD_TRACE_SAMPLE_RATE": 0,
"DD_TRACE_SAMPLING_RULES": '[{"sample_rate":0}]',
"DD_TRACE_STATS_COMPUTATION_ENABLED": "false",
}
],
)
def test_child_span_selected_by_sss015(self, test_agent: TestAgentAPI, test_library: APMLibrary):
"""Single spans selected by SSS must be kept even if its parent has been dropped.
We're essentially testing to make sure that the span sampling rule keeps selected spans despite of the trace sampling decision
and doesn't affect parent spans that are dropped by the tracer sampling mechanism.
"""
with (
test_library,
test_library.dd_start_span(name="parent", service="webserver") as ps,
test_library.dd_start_span(name="child", service="webserver", parent_id=ps.span_id) as cs,
):
pass
traces = test_agent.wait_for_num_spans(2, clear=True)
parent_span = find_span_in_traces(traces, ps.trace_id, ps.span_id)
child_span = find_span_in_traces(traces, cs.trace_id, cs.span_id)
# root span should be dropped by defined trace sampling rules
assert parent_span["metrics"].get(SAMPLING_PRIORITY_KEY) == -1
assert parent_span["metrics"].get(SINGLE_SPAN_SAMPLING_RATE) is None
assert parent_span["metrics"].get(SINGLE_SPAN_SAMPLING_MECHANISM) is None
assert parent_span["metrics"].get(SINGLE_SPAN_SAMPLING_MAX_PER_SEC) is None
# child span should be kept by defined the SSS rules
assert child_span["metrics"].get(SINGLE_SPAN_SAMPLING_RATE) == 1.0
assert child_span["metrics"].get(SINGLE_SPAN_SAMPLING_MECHANISM) == SINGLE_SPAN_SAMPLING_MECHANISM_VALUE
assert child_span["metrics"].get(SINGLE_SPAN_SAMPLING_MAX_PER_SEC) == 50
@pytest.mark.parametrize(
"library_env",
[
{
"DD_SPAN_SAMPLING_RULES": json.dumps(
[
{
"service": "webserver",
"name": "parent",
"sample_rate": 1.0,
"max_per_second": 50,
}
]
),
"DD_TRACE_SAMPLE_RATE": 0,
"DD_TRACE_SAMPLING_RULES": '[{"sample_rate":0}]',
"DD_TRACE_TRACER_METRICS_ENABLED": "true", # This activates dropping policy for Java Tracer
"DD_TRACE_FEATURES": "discovery", # This activates dropping policy for Go Tracer
}
],
)
@pytest.mark.parametrize("agent_env", [{"TEST_AGENT_VERSION": "7.65.0"}])
def test_root_span_selected_and_child_dropped_by_sss_when_dropping_policy_is_active016(
self, test_agent: TestAgentAPI, test_library: APMLibrary
):
"""Single spans selected by SSS must be kept and other spans expected to be dropped on the tracer side when
dropping policy is active when tracer metrics enabled.
We're essentially testing to make sure that the child unsampled span is dropped on the tracer side because of
the activate dropping policy.
"""
assert test_agent.info()["client_drop_p0s"] is True, "Client drop p0s expected to be enabled"
with test_library, test_library.dd_start_span(name="parent", service="webserver"):
pass
# expect the first trace kept by the tracer despite of the active dropping policy because of SSS
test_agent.wait_for_num_traces(1, clear=True)
# the second similar trace is expected to be sampled by SSS and the child span is expected to be dropped on the Tracer side
with (
test_library,
test_library.dd_start_span(name="parent", service="webserver") as s2,
test_library.dd_start_span(name="child", service="webserver", parent_id=s2.span_id),
):
pass
traces = test_agent.wait_for_num_traces(1, clear=True, sort_by_start=False)
trace2 = find_trace(traces, s2.trace_id)
assert len(trace2) == 1, "only the root span is expected to be sent to the test agent"
chunk_root = trace2[0]
# the trace should be dropped, so the parent span priority is set to -1
assert chunk_root["name"] == "parent"
assert chunk_root["metrics"].get(SAMPLING_PRIORITY_KEY) == -1
assert chunk_root["metrics"].get(SINGLE_SPAN_SAMPLING_RATE) == 1.0
assert chunk_root["metrics"].get(SINGLE_SPAN_SAMPLING_MECHANISM) == SINGLE_SPAN_SAMPLING_MECHANISM_VALUE
assert chunk_root["metrics"].get(SINGLE_SPAN_SAMPLING_MAX_PER_SEC) == 50
@pytest.mark.parametrize(
"library_env",
[
{
"DD_SPAN_SAMPLING_RULES": json.dumps(
[
{
"service": "webserver",
"name": "child",
"sample_rate": 1.0,
"max_per_second": 50,
}
]
),
"DD_TRACE_SAMPLE_RATE": 0,
"DD_TRACE_SAMPLING_RULES": '[{"sample_rate":0}]',
"DD_TRACE_TRACER_METRICS_ENABLED": "true", # This activates dropping policy for Java Tracer
"DD_TRACE_FEATURES": "discovery", # This activates dropping policy for Go Tracer
}
],
)
@pytest.mark.parametrize("agent_env", [{"TEST_AGENT_VERSION": "7.65.0"}])
def test_child_span_selected_and_root_dropped_by_sss_when_dropping_policy_is_active017(
self, test_agent: TestAgentAPI, test_library: APMLibrary
):
"""Single spans selected by SSS must be kept and other spans expected to be dropped on the tracer side when
dropping policy is active when tracer metrics enabled.
We're essentially testing to make sure that the root unsampled span is dropped on the tracer side because of
the activate dropping policy.
"""
assert test_agent.info()["client_drop_p0s"] is True, "Client drop p0s expected to be enabled"
with (
test_library,
test_library.dd_start_span(name="parent", service="webserver") as ps1,
test_library.dd_start_span(name="child", service="webserver", parent_id=ps1.span_id),
):
pass
# expect the first trace kept by the tracer despite of the active dropping policy because of SSS
test_agent.wait_for_num_traces(1, clear=True)
# the second similar trace is expected to be sampled by SSS and the child span is expected to be dropped on the Tracer side
with (
test_library,
test_library.dd_start_span(name="parent", service="webserver") as ps2,
test_library.dd_start_span(name="child", service="webserver", parent_id=ps2.span_id) as cs2,
):
pass
traces = test_agent.wait_for_num_traces(1, clear=True)
trace = find_trace(traces, ps2.trace_id)
assert len(trace) == 1, "only the child span is expected to be sent to the test agent"
child_span = find_span(trace, cs2.span_id)
# the trace should be dropped, so the parent span priority is set to -1
assert child_span["name"] == "child"
assert child_span["metrics"].get(SAMPLING_PRIORITY_KEY) == -1
assert child_span["metrics"].get(SINGLE_SPAN_SAMPLING_RATE) == 1.0
assert child_span["metrics"].get(SINGLE_SPAN_SAMPLING_MECHANISM) == SINGLE_SPAN_SAMPLING_MECHANISM_VALUE
assert child_span["metrics"].get(SINGLE_SPAN_SAMPLING_MAX_PER_SEC) == 50
@pytest.mark.parametrize(
"library_env",
[
{
"DD_TRACE_SAMPLE_RATE": 0,
"DD_TRACE_SAMPLING_RULES": '[{"sample_rate":0}]',
"DD_TRACE_TRACER_METRICS_ENABLED": "true", # This activates dropping policy for Java Tracer
"DD_TRACE_FEATURES": "discovery", # This activates dropping policy for Go Tracer
}
],
)
@pytest.mark.parametrize("agent_env", [{"TEST_AGENT_VERSION": "7.65.0"}])
def test_entire_trace_dropped_when_dropping_policy_is_active018(
self, test_agent: TestAgentAPI, test_library: APMLibrary
):
"""The entire dropped span expected to be dropped on the tracer side when
dropping policy is active, which is the case when tracer metrics enabled.
We're essentially testing to make sure that the entire unsampled trace is dropped on the tracer side because of
the activate dropping policy.
"""
assert test_agent.info()["client_drop_p0s"] is True, "Client drop p0s expected to be enabled"
with test_library, test_library.dd_start_span(name="parent", service="webserver"):
pass
if context.library.name == "java" and context.library.version <= "1.54":
# before 1.55.0 java was keeping the first seen span
test_agent.wait_for_num_traces(1, clear=True)
else:
test_agent.wait_for_num_traces(0, clear=True)
# the second similar trace is expected to be dropped on the Tracer side
with (
test_library,
test_library.dd_start_span(name="parent", service="webserver") as ps,
test_library.dd_start_span(name="child", service="webserver", parent_id=ps.span_id),
):
pass
traces = test_agent.wait_for_num_traces(0, clear=True)
assert len(traces) == 0
@pytest.mark.parametrize(
"library_env",
[
{
"DD_TRACE_PROPAGATION_STYLE": "datadog",
"DD_SPAN_SAMPLING_RULES": json.dumps([{"name": "web.request", "sample_rate": 1.0}]),
"DD_TRACE_SAMPLING_RULES": json.dumps([{"name": "web.request", "sample_rate": 1.0}]),
}
],
)
def test_single_rule_with_head_and_rule_trace_sampling_keep_019(
self, test_agent: TestAgentAPI, test_library: APMLibrary
):
"""Test that head sampling, single span rules and trace rules work well together when the rules are to keep.
Test that:
1. Single span should not apply when the trace is kept by the head sampling.
2. Trace sampling rule is not applied when there is a head sampling decision.
3. Spans are flagged with the correct tags and sampling mechanism.
"""
with test_library.dd_extract_headers_and_make_child_span(
"web.request",
[
("x-datadog-trace-id", "12345678901"),
("x-datadog-parent-id", "98765432101"),
("x-datadog-sampling-priority", "1"),
("x-datadog-origin", "rum"),
],
) as s1:
pass
with test_library.dd_extract_headers_and_make_child_span(
"web.request",
[
("x-datadog-trace-id", "12345678902"),
("x-datadog-parent-id", "98765432102"),
("x-datadog-sampling-priority", "0"),
("x-datadog-origin", "rum"),
],
) as s2:
pass
test_library.dd_flush()
traces = test_agent.wait_for_num_traces(2)
case1 = find_span_in_traces(traces, s1.trace_id, s1.span_id)
# Assert the RUM origin is set
assert case1["meta"]["_dd.origin"] == "rum"
# Assert the propagated sampling priority is unaffected
assert case1["metrics"].get(SAMPLING_PRIORITY_KEY) == 1
# Assert that there is no trace sampling happening
assert "_dd.p.dm" not in case1["meta"]
assert "_dd.rule_psr" not in case1["meta"]
# Assert that there is no single span sampling happening
assert SINGLE_SPAN_SAMPLING_MECHANISM not in case1["metrics"]
assert SINGLE_SPAN_SAMPLING_RATE not in case1["metrics"]
assert SINGLE_SPAN_SAMPLING_MAX_PER_SEC not in case1["metrics"]
case2 = find_span_in_traces(traces, s2.trace_id, s2.span_id)
# Assert the RUM origin is set
assert case2["meta"]["_dd.origin"] == "rum"
# Assert the propagated sampling priority is unaffected
assert case2["metrics"].get(SAMPLING_PRIORITY_KEY) == 0
# Assert that there is no trace sampling happening
assert "_dd.p.dm" not in case2["meta"]
assert "_dd.rule_psr" not in case2["meta"]
# Assert single span sampling applied
assert case2["metrics"].get(SINGLE_SPAN_SAMPLING_MECHANISM) == 8
assert case2["metrics"].get(SINGLE_SPAN_SAMPLING_RATE) == 1
@pytest.mark.parametrize(
"library_env",
[
{
"DD_TRACE_PROPAGATION_STYLE": "datadog",
"DD_SPAN_SAMPLING_RULES": json.dumps([{"name": "web.request", "sample_rate": 0.0}]),
"DD_TRACE_SAMPLING_RULES": json.dumps([{"name": "web.request", "sample_rate": 0.0}]),
"DD_TRACE_STATS_COMPUTATION_ENABLED": "false", # Disable stats computation to send P0s
}
],
)
def test_single_rule_with_head_and_rule_trace_sampling_drop_020(
self, test_agent: TestAgentAPI, test_library: APMLibrary
):
"""Test that head sampling, single span rules and trace rules work well together when the rules are to drop.
Test that:
1. Single span should not drop spans kept by head sampling.
2. Trace sampling rule is not applied when there is a head sampling decision.
3. Spans are flagged with the correct tags and sampling mechanism.
"""
with test_library.dd_extract_headers_and_make_child_span(
"web.request",
[
("x-datadog-trace-id", "12345678901"),
("x-datadog-parent-id", "98765432101"),
("x-datadog-sampling-priority", "1"),
("x-datadog-origin", "rum"),
],
) as s1:
pass
with test_library.dd_extract_headers_and_make_child_span(
"web.request",
[
("x-datadog-trace-id", "12345678902"),
("x-datadog-parent-id", "98765432102"),
("x-datadog-sampling-priority", "0"),
("x-datadog-origin", "rum"),
],
) as s2:
pass
test_library.dd_flush()
traces = test_agent.wait_for_num_traces(2)
case1 = find_span_in_traces(traces, s1.trace_id, s1.span_id)
# Assert the RUM origin is set
assert case1["meta"]["_dd.origin"] == "rum"
# Assert the propagated sampling priority is unaffected
assert case1["metrics"].get(SAMPLING_PRIORITY_KEY) == 1
# Assert that there is no trace sampling happening
assert "_dd.p.dm" not in case1["meta"]
assert "_dd.rule_psr" not in case1["meta"]
# Assert that there is no single span sampling happening
assert SINGLE_SPAN_SAMPLING_MECHANISM not in case1["metrics"]
assert SINGLE_SPAN_SAMPLING_RATE not in case1["metrics"]
assert SINGLE_SPAN_SAMPLING_MAX_PER_SEC not in case1["metrics"]
case2 = find_span_in_traces(traces, s2.trace_id, s2.span_id)
# Assert the RUM origin is set
assert case2["meta"]["_dd.origin"] == "rum"
# Assert the propagated sampling priority is unaffected
assert case2["metrics"].get(SAMPLING_PRIORITY_KEY) == 0
# Assert that there is no trace sampling happening
assert "_dd.p.dm" not in case2["meta"]
assert "_dd.rule_psr" not in case2["meta"]
# Assert that there is no single span sampling happening
assert SINGLE_SPAN_SAMPLING_MECHANISM not in case1["metrics"]
assert SINGLE_SPAN_SAMPLING_RATE not in case1["metrics"]
assert SINGLE_SPAN_SAMPLING_MAX_PER_SEC not in case1["metrics"]