Commit 13dd2ee
test(otel): fix server.port DB test to be a proper rename test (meta-or-metrics)
Running OTEL_SEMANTICS_DB against dd-trace-js master revealed test_server_port xpassed:
the previous version only checked `out.port` absent, but dd-trace-js puts the port in
`metrics[network.destination.port]` (=5433), so "out.port absent" was trivially true and
the test passed even though no OTel rename occurred.
Fix: require server.port present (the postgres port is non-default, so the spec expects it),
read it from meta OR metrics, and assert both legacy port names (out.port,
network.destination.port) are absent. Now all 7 rename tests xfail correctly when the
feature is unimplemented.
Finding: dd-trace-js master does NOT implement OTel DB semantics — its postgres SQL span
emits Datadog names (db.name, db.type=postgres, out.host, network.destination.port) and none
of the OTel names. Confirms the suite's all-gated (missing_feature) status.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>1 parent ec9bece commit 13dd2ee
1 file changed
Lines changed: 14 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
85 | 85 | | |
86 | 86 | | |
87 | 87 | | |
88 | | - | |
89 | | - | |
90 | | - | |
91 | | - | |
92 | | - | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
0 commit comments