Skip to content

Commit d0050bf

Browse files
wantsuitlhunter
andauthored
Enable Process Discovery tests for Node.js (#6638)
Co-authored-by: Thomas Hunter II <tlhunter@datadog.com>
1 parent bfc6145 commit d0050bf

2 files changed

Lines changed: 5 additions & 1 deletion

File tree

manifests/nodejs.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2057,7 +2057,7 @@ manifest:
20572057
tests/parametric/test_parametric_endpoints.py::Test_Parametric_Otel_Current_Span: incomplete_test_app (otel current_span endpoint is not supported)
20582058
tests/parametric/test_parametric_endpoints.py::Test_Parametric_Write_Log: *ref_5_72_0
20592059
tests/parametric/test_partial_flushing.py::Test_Partial_Flushing: bug (APMLP-270)
2060-
tests/parametric/test_process_discovery.py: missing_feature
2060+
tests/parametric/test_process_discovery.py::Test_ProcessDiscovery: v5.93.0
20612061
tests/parametric/test_sampling_manual.py::Test_Manual_Sampling: bug (APMAPI-1720) # Manual keep did not override the upstream drop decision
20622062
tests/parametric/test_sampling_span_tags.py::Test_Knuth_Sample_Rate: missing_feature
20632063
tests/parametric/test_sampling_span_tags.py::Test_Sampling_Span_Tags::test_tags_appsec_enabled_sst011: bug (APMAPI-737)

tests/parametric/test_process_discovery.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,10 @@ def assert_metadata_content(test_library: APMLibrary, library_env: dict[str, str
8686
rc, out = test_library.container_exec_run("pidof java")
8787
assert rc
8888
pid = int(out)
89+
elif context.library.name == "nodejs":
90+
rc, out = test_library.container_exec_run("pidof node")
91+
assert rc
92+
pid = int(out)
8993
memfds = find_dd_memfds(test_library, pid)
9094
assert len(memfds) == 1
9195
rc, tracer_metadata = read_memfd(test_library, memfds[0])

0 commit comments

Comments
 (0)