Skip to content

Re-enable Otel_Drop_In test for Java#6433

Merged
mcculls merged 1 commit intomainfrom
mcculls/APMAPI-1863
Mar 4, 2026
Merged

Re-enable Otel_Drop_In test for Java#6433
mcculls merged 1 commit intomainfrom
mcculls/APMAPI-1863

Conversation

@mcculls
Copy link
Copy Markdown
Contributor

@mcculls mcculls commented Mar 4, 2026

Motivation

The packaging issue that caused the OTel drop-in failure on Java has been fixed in DataDog/dd-trace-java#10738 and released as v1.60.1

Changes

Revert "Skip flaky test for APMAPI-1863 (#6428)"

This reverts commit 7b8fdff.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@mcculls mcculls requested review from a team as code owners March 4, 2026 19:37
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 4, 2026

CODEOWNERS have been resolved as:

manifests/java.yml                                                      @DataDog/asm-java @DataDog/apm-java

Comment thread manifests/java.yml
- weblog_declaration:
"*": missing_feature
spring-boot: v1.39.0
tests/integrations/test_otel_drop_in.py::Test_Otel_Drop_In::test_otel_drop_in_span_metrics:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, it would be ideal if we were able to specify "not X version". This is certainly fine though 👍🏼

Copy link
Copy Markdown
Collaborator

@cbeauchesne cbeauchesne Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's actually possible, since the component_version property is used a a trueish filter :

 - component_version: "1.60.0"
    declaration: flaky (APMAPI-1863)

@mcculls mcculls merged commit 0a55f2e into main Mar 4, 2026
189 of 194 checks passed
@mcculls mcculls deleted the mcculls/APMAPI-1863 branch March 4, 2026 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants