[Java] Disabling SSI Telemetry Test#6477
[Java] Disabling SSI Telemetry Test#6477gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits intomainfrom
Conversation
|
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 88300f9e24
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| - declaration: missing_feature (Not implemented yet) | ||
| component_version: <1.52.0 | ||
| tests/docker_ssi/test_docker_ssi_appsec.py::TestDockerSSIAppsecFeatures::test_telemetry_source_ssi: v1.59.0 | ||
| tests/docker_ssi/test_docker_ssi_appsec.py::TestDockerSSIAppsecFeatures::test_telemetry_source_ssi: missing_feature (Temporarily disabling until Java PR is updated) |
There was a problem hiding this comment.
Changing this entry from v1.59.0 to missing_feature (...) disables the telemetry test for all Java versions, not only the dd-trace-java change you referenced. Because this manifest applies to every Java run (including stable releases), this removes coverage and can hide regressions or restored behavior until someone manually re-enables it; use a version-constrained declaration so only impacted versions are deactivated.
Useful? React with 👍 / 👎.
gh-worker-dd-mergequeue-cf854d
bot
merged commit 879a4bb
into
main
gh-worker-dd-mergequeue-cf854d
bot
deleted the
mhlidd/disabling_telemetry_ssi_tests
branch
Co-authored-by: matthew.li <matthew.li@datadoghq.com>
Co-authored-by: matthew.li <matthew.li@datadoghq.com>
2 participants
Motivation
Temporarily disabling test to pass CI on this dd-trace-java change. A follow-up PR will update this test once the dd-trace-java PR is merged.
Changes
Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present