Merged
Conversation
Contributor
|
|
🎉 All green!❄️ No new flaky tests detected 🔗 Commit SHA: f74c21d | Docs | Datadog PR Page | Give us feedback! |
c2be460 to
483e4b9
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 483e4b93ab
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Add OTLP_RUNTIME_METRICS scenario that validates dd-trace libraries export runtime metrics via OTLP with OTel semantic convention names instead of DD-proprietary names. - New scenario routes OTLP metrics through proxy to agent using standard dd-otlp-path=agent header pattern - Test reads from interfaces.agent.get_metrics(), matching how RUNTIME_METRICS_ENABLED tests work - Expected metrics defined per language (dotnet, go, nodejs, java), all set to missing_feature until tracer PRs land - Registered in CI workflow and orchestrator - Fix parametric test_otel_metrics leaking runtime metrics by setting DD_RUNTIME_METRICS_ENABLED=false in DEFAULT_ENVVARS Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
483e4b9 to
f74c21d
Compare
cbeauchesne
reviewed
Apr 22, 2026
This was referenced Apr 22, 2026
cbeauchesne
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related One Pager: Sending Runtime Metrics via OTLP from dd-trace-*
OTLP_RUNTIME_METRICSend-to-end scenario and test for validating that dd-trace libraries export runtime metrics via OTLP using OTel semantic convention names (dotnet.*,jvm.*,go.*,v8js.*) instead of DD-proprietary names (runtime.dotnet.*,runtime.go.*, etc.)test_otel_metricstests leaking runtime metrics by explicitly settingDD_RUNTIME_METRICS_ENABLED=falsein test env varsHow it works
When
DD_RUNTIME_METRICS_ENABLED=true+DD_METRICS_OTEL_ENABLED=true, tracers should send runtime metrics via OTLP.The scenario routes OTLP metrics through the proxy to the agent using
OTEL_EXPORTER_OTLP_METRICS_HEADERS: "dd-protocol=otlp,dd-otlp-path=agent"(same pattern asotel_integrations), then validates metric names frominterfaces.agent.get_metrics()(same pattern asRUNTIME_METRICS_ENABLED).Test coverage
One test class (
Test_OtlpRuntimeMetrics) asserts:Expected metrics are defined per language (19 dotnet, 8 go, 13 nodejs, 18 java). All languages are
missing_featureuntil their respective tracer PRs land.Test plan
OTLP_RUNTIME_METRICSscenario build from dd-trace-dotnet#8457 passes in System Test CI #6797 Dev runRUNTIME_METRICS_ENABLEDscenario unaffectedtest_otel_metricsfailures fixed withDD_RUNTIME_METRICS_ENABLED=false🤖 Generated with Claude Code