Skip to content

test(java): activate type mismatch and parse error tests (dd-trace-java#11036)#6718

Closed
typotter wants to merge 1 commit into
typo/activate-java-eval-testsfrom
typo/activate-java-eval-type-mismatch-tests
Closed

test(java): activate type mismatch and parse error tests (dd-trace-java#11036)#6718
typotter wants to merge 1 commit into
typo/activate-java-eval-testsfrom
typo/activate-java-eval-type-mismatch-tests

Conversation

@typotter

@typotter typotter commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

Summary

This activates three tests that were previously marked as bug (FFL-1972) in manifests/java.yml:

  • tests/ffe/test_flag_eval_metrics.py::Test_FFE_Eval_Metric_Type_Mismatch::test_ffe_eval_metric_type_mismatch
  • tests/ffe/test_flag_eval_metrics.py::Test_FFE_Eval_Metric_Numeric_To_Integer::test_ffe_eval_metric_numeric_to_integer
  • tests/ffe/test_flag_eval_metrics.py::Test_FFE_Eval_Metric_Parse_Error_Variant_Type_Mismatch::test_ffe_eval_metric_parse_error_variant_type_mismatch

These tests cover type mismatch handling and parse error behavior (variant type mismatch) in flag evaluation metrics. They are fixed by DataDog/dd-trace-java#11036.

Dependencies

@github-actions

github-actions Bot commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

manifests/java.yml                                                      @DataDog/asm-java @DataDog/apm-java

@typotter
typotter force-pushed the typo/activate-java-eval-type-mismatch-tests branch from 8521fdc to fb662f3 Compare April 14, 2026 15:34
@typotter
typotter marked this pull request as ready for review April 14, 2026 15:34
@typotter
typotter requested review from a team as code owners April 14, 2026 15:34
@typotter
typotter force-pushed the typo/activate-java-eval-type-mismatch-tests branch from fb662f3 to 927f1a8 Compare April 14, 2026 19:19
@typotter
typotter marked this pull request as draft April 15, 2026 20:51
@typotter
typotter force-pushed the typo/activate-java-eval-tests branch from 918d3cd to 0240b32 Compare April 16, 2026 17:11
@typotter
typotter force-pushed the typo/activate-java-eval-type-mismatch-tests branch from 0c965e0 to 83ca2a3 Compare April 16, 2026 18:06
typotter added a commit that referenced this pull request Apr 16, 2026
Removes all remaining bug (FFL-1972) annotations. All 17 tests will
pass on v1.62.0 once the following dd-trace-java PRs ship:
- #11040: core eval metrics implementation (10 tests)
- #11037: STATIC/SPLIT reason (test_ffe_eval_metric_basic, test_ffe_eval_reason_split)
- #11036: type mismatch / parse error (3 tests)
- #11071: invalid regex parse error (1 test)
- #11072: metric count (1 test)

Supersedes #6717, #6718, #6723.
@typotter

Copy link
Copy Markdown
Contributor Author

Superseded by #6759 which consolidates all 17 FFE eval metric test activations into a single PR.

@typotter typotter closed this Apr 16, 2026
@cbeauchesne
cbeauchesne deleted the typo/activate-java-eval-type-mismatch-tests branch May 21, 2026 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant