Skip to content

feat(ci): use feature branch if specified [php@milan.garnier/publish-ci-builds]#7209

Draft
MilanGarnier wants to merge 1 commit into
mainfrom
milan.garnier/php-checkout
Draft

feat(ci): use feature branch if specified [php@milan.garnier/publish-ci-builds]#7209
MilanGarnier wants to merge 1 commit into
mainfrom
milan.garnier/php-checkout

Conversation

@MilanGarnier

Copy link
Copy Markdown
Contributor

Motivation

Currently, system-tests run on the latest stable version of dd-trace-php. If a feature branch is specified in the PR title it is silently discarded. This PRs fetches the appropriate build on github's container registry.
In dd-trace-php, a new job publishes builds to the registry, with :branchname. (DataDog/dd-trace-php#4013)

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@github-actions

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

utils/scripts/load-binary.sh                                            @DataDog/system-tests-core

@datadog-datadog-prod-us1-2

datadog-datadog-prod-us1-2 Bot commented Jun 24, 2026

Copy link
Copy Markdown

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 0f0b363 | Docs | Datadog PR Page | Give us feedback!

@MilanGarnier MilanGarnier changed the title feat(ci): use feature branch if specified feat(ci): use feature branch if specified [php@milan.garnier@publish-ci-builds] Jun 24, 2026
@MilanGarnier MilanGarnier changed the title feat(ci): use feature branch if specified [php@milan.garnier@publish-ci-builds] feat(ci): use feature branch if specified [php@milan.garnier/publish-ci-builds] Jun 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant