Skip to content

chore(ssi): move SSI tests to node 22#7271

Open
pabloerhard wants to merge 8 commits into
mainfrom
pabloerhard/nodejs-node22
Open

chore(ssi): move SSI tests to node 22#7271
pabloerhard wants to merge 8 commits into
mainfrom
pabloerhard/nodejs-node22

Conversation

@pabloerhard

@pabloerhard pabloerhard commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Motivation

dd-trace-js now requires Node.js 22+, but several SSI jobs were still provisioning Node 18/20 runtimes. This caused supported SSI scenarios to run an incompatible tracer/runtime combination and fail before traces reached the backend.

Changes

  • Updated supported AWS SSI Node.js weblogs to provision Node 22.
  • Updated Docker SSI Node.js expectations so v6+ tracers require Node 22, while older tracer majors keep the previous Node 17 floor. These will allow keeping support while the changes in the datadog-agent land and get released.
  • Kept older Node versions available for unsupported/runtime-compatibility coverage.
  • Bumped SSI dev/staging JS library override from major 6 to 7.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

tests/docker_ssi/test_docker_ssi.py                                     @DataDog/injection-platform
tests/docker_ssi/test_docker_ssi_appsec.py                              @DataDog/injection-platform
tests/docker_ssi/test_docker_ssi_crash.py                               @DataDog/injection-platform
utils/build/ssi/base/install_script_ssi.sh                              @DataDog/system-tests-core
utils/build/virtual_machine/provisions/auto-inject/auto-inject_installer_manual.yml  @DataDog/system-tests-core
utils/build/virtual_machine/provisions/auto-inject/repositories/autoinstall/execute_install_script.sh  @DataDog/system-tests-core
utils/build/virtual_machine/weblogs/nodejs/provision_test-app-nodejs-alpine.yml  @DataDog/system-tests-core
utils/build/virtual_machine/weblogs/nodejs/provision_test-app-nodejs-container.yml  @DataDog/system-tests-core
utils/build/virtual_machine/weblogs/nodejs/provision_test-app-nodejs-esm.yml  @DataDog/system-tests-core
utils/build/virtual_machine/weblogs/nodejs/provision_test-app-nodejs.yml  @DataDog/system-tests-core
utils/build/virtual_machine/weblogs/nodejs/test-app-nodejs-container/Dockerfile.template  @DataDog/system-tests-core
utils/build/virtual_machine/weblogs/nodejs/test-app-nodejs-esm/Dockerfile.node  @DataDog/system-tests-core
utils/build/virtual_machine/weblogs/nodejs/test-app-nodejs-esm/docker-compose.yml  @DataDog/system-tests-core
utils/build/virtual_machine/weblogs/nodejs/test-app-nodejs-esm/nginx.conf  @DataDog/system-tests-core
utils/build/virtual_machine/weblogs/nodejs/test-app-nodejs-esm/Dockerfile.node22  @DataDog/system-tests-core

@datadog-official

datadog-official Bot commented Jul 6, 2026

Copy link
Copy Markdown

Pipelines  Tests

Fix all issues with BitsAI

⚠️ Warnings

🚦 1 Pipeline job failed

DataDog/system-tests | mirror_images   View in Datadog   GitLab

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 5a1d4e3 | Docs | Datadog PR Page | Give us feedback!

@pabloerhard pabloerhard changed the title move SSI tests to node 22 chore(ssi): move SSI tests to node 22 Jul 6, 2026
@pabloerhard pabloerhard marked this pull request as ready for review July 6, 2026 20:57
@pabloerhard pabloerhard requested review from a team as code owners July 6, 2026 20:57

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1c7c9f91c3

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

# Special case for Node.js, the staging major version is 1 above the prod major (6 here)
export DD_INSTALLER_DEFAULT_PKG_VERSION_DATADOG_APM_LIBRARY_JS="6"
# Special case for Node.js, the staging major version is 1 above the prod major (7 here)
export DD_INSTALLER_DEFAULT_PKG_VERSION_DATADOG_APM_LIBRARY_JS="7"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are getting errors trying to install the nodejs library 7.X
failed to install package oci://install.datad0g.com/apm-library-js-package:7: could not download package: could not download package: could not download image from any registry: could not download image using install.datad0g.com/apm-library-js-package:7: GET

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: this will be added back once the installer is able to resolve to version 7

@CarlesDD CarlesDD left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from an AAP perspective.

@pabloerhard pabloerhard force-pushed the pabloerhard/nodejs-node22 branch from b09fa27 to dbd3fcc Compare July 7, 2026 14:21
@pabloerhard pabloerhard force-pushed the pabloerhard/nodejs-node22 branch from 76e5a85 to 5a1d4e3 Compare July 7, 2026 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants