chore(ssi): move SSI tests to node 22#7271
Conversation
|
|
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1c7c9f91c3
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| # Special case for Node.js, the staging major version is 1 above the prod major (6 here) | ||
| export DD_INSTALLER_DEFAULT_PKG_VERSION_DATADOG_APM_LIBRARY_JS="6" | ||
| # Special case for Node.js, the staging major version is 1 above the prod major (7 here) | ||
| export DD_INSTALLER_DEFAULT_PKG_VERSION_DATADOG_APM_LIBRARY_JS="7" |
There was a problem hiding this comment.
we are getting errors trying to install the nodejs library 7.X
failed to install package oci://install.datad0g.com/apm-library-js-package:7: could not download package: could not download package: could not download image from any registry: could not download image using install.datad0g.com/apm-library-js-package:7: GET
There was a problem hiding this comment.
Note: this will be added back once the installer is able to resolve to version 7
b09fa27 to
dbd3fcc
Compare
76e5a85 to
5a1d4e3
Compare
Motivation
dd-trace-js now requires Node.js 22+, but several SSI jobs were still provisioning Node 18/20 runtimes. This caused supported SSI scenarios to run an incompatible tracer/runtime combination and fail before traces reached the backend.
Changes
Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present