Cleanups on how matrix of scenario/weblog functions#7275
Conversation
|
|
🎉 All green!🧪 All tests passed 🔗 Commit SHA: b181cd7 | Docs | Datadog PR Page | Give us feedback! |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 554129c236
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 62395c8c44
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| return False | ||
|
|
||
| if scenario in ("GRAPHQL_APPSEC",): | ||
| if scenario_name in ("GRAPHQL_APPSEC",): |
There was a problem hiding this comment.
Include GraphQL error tracking in the whitelist
When compute-workflow-parameters is called with --groups graphql, GRAPHQL_ERROR_TRACKING is now selected by that group, but this whitelist still only treats GRAPHQL_APPSEC as a GraphQL scenario. The later GraphQL-weblog guard rejects gqlgen, graph-gophers, graphql-go, and graphql23 for GRAPHQL_ERROR_TRACKING, while unrelated weblogs can still be scheduled, so the new group does not run this GraphQL test on the apps it targets.
Useful? React with 👍 / 👎.
| super().__init__( | ||
| name, doc=doc, appsec_enabled=self.appsec_enabled, use_proxy_for_agent=False, use_proxy_for_weblog=False | ||
| ) | ||
| self.scenario_groups = [scenario_groups.exotics] |
There was a problem hiding this comment.
Keep performance group backrefs in sync
Assigning self.scenario_groups after EndToEndScenario.__init__ makes the ScenarioGroup reverse indexes inconsistent: the base Scenario.__init__ has already appended PERFORMANCES to all, end_to_end, and tracer_release, and this assignment never appends it to exotics. Any test using a @scenario_groups.<group> decorator will still see PERFORMANCES in the old groups and not in exotics, while CI selection reads the overwritten scenario.scenario_groups, so the two selection paths disagree.
Useful? React with 👍 / 👎.
9cd1a5c to
b181cd7
Compare
Motivation
Cleaner code, pave the way of moving this matrix parameters in weblog metadata yml files
Changes
Use objects, rather string identifier in
_is_supportedand all parent functions.How to test
comparizon in test optim
Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present