Temporarily disable Java FFE evaluation tests#7276
Draft
leoromanovsky wants to merge 1 commit into
Draft
Conversation
Contributor
|
|
9b58fef to
b6ccfa1
Compare
b6ccfa1 to
f03668a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Java FFE evaluation metrics system tests exercise flag allocations that include ISO8601
startAt/endAtwindow dates. The current Java tracer mainline still has a date-model/parsing mismatch for those allocation windows: system-tests provides ISO8601 strings, while Java needs theInstantallocation-window parsing/model change in DataDog/dd-trace-java#11535. Until that Java tracer PR lands, these evaluation metrics tests fail for a known tracer-sideInstantmismatch rather than a system-tests regression.This PR temporarily disables the Java evaluation metrics manifest entry so system-tests does not gate on that pending Java tracer fix. We will re-enable the entry once DataDog/dd-trace-java#11535 lands on main.
Changes and Decisions
This PR changes the Java manifest entry for
tests/ffe/test_flag_eval_metrics.pyfrom the spring-boot version gate tobug (FFL-2339). The file-level manifest rule matches all tests intest_flag_eval_metrics.py, including the metric-count child test, so this keeps the disablement scoped to Java FFE evaluation metrics and leaves the EVP manifest entry unchanged.Validation
./format.shprogressed through mypy, ruff, whitespace, yamlfmt, yamllint, manifest parser, and shellcheck checks; local Docker failed at the later Node lint stage with a containerd input/output error../venv/bin/yamlfmt -lint manifests/./venv/bin/yamllint -s manifests/./venv/bin/python utils/manifest/validate.pygit diff --checkbug (FFL-2339).