[golang] Activate CSS Test_Client_Stats_With_Client_Obfuscation#7282
Draft
ichinaski wants to merge 1 commit into
Draft
[golang] Activate CSS Test_Client_Stats_With_Client_Obfuscation#7282ichinaski wants to merge 1 commit into
ichinaski wants to merge 1 commit into
Conversation
…v2.9.1 dd-trace-go performs end-to-end client-side stats obfuscation negotiation; the test xpasses on the released tracer (v2.9.1) in the base TRACE_STATS_COMPUTATION scenario. Gate it at v2.9.1 instead of missing_feature. The _Disabled variant stays missing_feature (no client-obfuscation off switch). APMSP-3668
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
APMSP-3668. dd-trace-go performs end-to-end client-side stats obfuscation negotiation (version-negotiated, no dedicated flag).
Test_Client_Stats_With_Client_Obfuscationruns under the baseTRACE_STATS_COMPUTATIONscenario and already xpasses on the released tracer (observed on v2.9.1 in CI) while markedmissing_feature.Changes
Version-gate
tests/stats/test_stats.py::Test_Client_Stats_With_Client_Obfuscationatv2.9.1inmanifests/golang.yml(was an unconditionalmissing_feature). The_With_Client_Obfuscation_Disabledvariant staysmissing_feature(APMSP-3672) — Go, like dotnet, exposes no runtime switch to disable client obfuscation, so that scenario is not applicable.Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present