Filter job for auto_inject repo so system-tests specific jobs are excluded#7284
Conversation
|
|
🎉 All green!🧪 All tests passed 🔗 Commit SHA: cef6c05 | Docs | Datadog PR Page | Give us feedback! |
|
|
||
| if language and language in LANG_STAGES: | ||
| data = filter_yaml(data, language) | ||
| data = filter_yaml(data, language) |
There was a problem hiding this comment.
I wouldn’t remove this if. Take a look at the method comment: if it’s None or not a language, the pipeline will be generated for all languages.
Checking the usages: https://github.com/search?q=org%3ADataDog%20external_gitlab_pipeline.py&type=code
There was a problem hiding this comment.
I updated to condition I added to is_allowed_stage to match the old one. The only thing that should change is that jobs not related to SSI should no longer be included in the pipeline export.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d33d633881
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Test PR in auto_inject
Corresponding gitlab pipeline
Motivation
Changes
Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present