Skip to content

Filter job for auto_inject repo so system-tests specific jobs are excluded#7284

Merged
nccatoni merged 3 commits into
mainfrom
nccatoni/fix-auto-inject-ssi
Jul 9, 2026
Merged

Filter job for auto_inject repo so system-tests specific jobs are excluded#7284
nccatoni merged 3 commits into
mainfrom
nccatoni/fix-auto-inject-ssi

Conversation

@nccatoni

@nccatoni nccatoni commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

Test PR in auto_inject
Corresponding gitlab pipeline

Motivation

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

utils/scripts/ci_orchestrators/external_gitlab_pipeline.py              @DataDog/system-tests-core

@datadog-prod-us1-3

datadog-prod-us1-3 Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: cef6c05 | Docs | Datadog PR Page | Give us feedback!

@nccatoni nccatoni marked this pull request as ready for review July 8, 2026 16:51
@nccatoni nccatoni requested a review from a team as a code owner July 8, 2026 16:51

if language and language in LANG_STAGES:
data = filter_yaml(data, language)
data = filter_yaml(data, language)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn’t remove this if. Take a look at the method comment: if it’s None or not a language, the pipeline will be generated for all languages.

Checking the usages: https://github.com/search?q=org%3ADataDog%20external_gitlab_pipeline.py&type=code

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated to condition I added to is_allowed_stage to match the old one. The only thing that should change is that jobs not related to SSI should no longer be included in the pipeline export.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d33d633881

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread utils/scripts/ci_orchestrators/external_gitlab_pipeline.py Outdated
Comment thread utils/scripts/ci_orchestrators/external_gitlab_pipeline.py
@nccatoni nccatoni merged commit 138789b into main Jul 9, 2026
2066 checks passed
@nccatoni nccatoni deleted the nccatoni/fix-auto-inject-ssi branch July 9, 2026 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants