Dudik/debugger/guardrails tests#7287
Draft
dudikeleti wants to merge 4 commits into
Draft
Conversation
…reasons and evaluation timeout behavior, with new rows disabled in manifests until tracer support is ready.
…re timeout reporting. 1MB snapshot cap and notCapturedReason=timeout behavior.
…ves the setup-time negative snapshot wait so evaluation-timeout assertions rely on collected scenario output instead of a fixed sleep.
Contributor
|
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Add focused system-test coverage for the debugger guardrails required for GA.
Changes
Test_Debugger_Evaluation_Timeout: expensivewhenevaluation (ReDoS regex, large collection filter) must be aborted and surfaced as an evaluation-error snapshot (populatedevaluationErrors[], no captured data), not a normal snapshot.Test_Debugger_Snapshot_Guardrails: completed snapshots are trimmed to ≤1 MB, and capture exceeding the time budget reportsnotCapturedReason=timeout.test_default_max_lengthto assertnotCapturedReason=stringLength, completing default capture-limit reason coverage.captures_contain_datahelper intodebugger.utils(reused by the condition-error tests).missing_featureacross every tracer; enable per-language as support lands. The regex fixture only exercises backtracking engines (linear engines like Go stay disabled via manifests).Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present