Skip to content

fix exception replay snapshot#7317

Merged
jpbempel merged 1 commit into
mainfrom
jpbempel/fix-exception-replay-locals
Jul 17, 2026
Merged

fix exception replay snapshot#7317
jpbempel merged 1 commit into
mainfrom
jpbempel/fix-exception-replay-locals

Conversation

@jpbempel

Copy link
Copy Markdown
Member

Motivation

hoisted local var are now captured

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@github-actions

github-actions Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

manifests/java.yml                                                      @DataDog/asm-java @DataDog/apm-java
tests/debugger/utils/approvals/java/1.5.0/exception_replay_inner_snapshots_expected.json  @DataDog/debugger @DataDog/system-tests-core

@datadog-official

datadog-official Bot commented Jul 16, 2026

Copy link
Copy Markdown

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 2e2de7a | Docs | Datadog PR Page | Give us feedback!

@datadog-official

datadog-official Bot commented Jul 16, 2026

Copy link
Copy Markdown

View session in Datadog

Bits Code status: ✅ Done

Comment @DataDog to request changes

@jpbempel
jpbempel force-pushed the jpbempel/fix-exception-replay-locals branch 2 times, most recently from a1fe226 to 3e34e14 Compare July 16, 2026 07:39
hoisted local var are now captured
@jpbempel
jpbempel force-pushed the jpbempel/fix-exception-replay-locals branch from 3e34e14 to 2e2de7a Compare July 16, 2026 09:35
@jpbempel
jpbempel marked this pull request as ready for review July 16, 2026 13:01
@jpbempel
jpbempel requested review from a team as code owners July 16, 2026 13:01

@datadog-official datadog-official Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

PR updates exception replay test approvals to capture hoisted local variables that the Java tracer now properly includes in snapshots. JSON and YAML are valid; the exception variable ex contains all required fields (type, status, reason, stackTrace, depth). Test fixture changes only — no production code modified.

Was this helpful? React 👍 or 👎

📊 Validated against 5 scenarios · Open Bits AI session

🤖 Datadog Autotest · Commit 2e2de7a · What is Autotest? · Any feedback? Reach out in #autotest

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2e2de7ab1d

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread manifests/java.yml
spring-boot-openliberty: missing_feature
spring-boot-jetty: missing_feature
spring-boot-payara: missing_feature
tests/debugger/test_debugger_exception_replay.py::Test_Debugger_Exception_Replay::test_exception_replay_inner: bug (DEBUG-5838)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep the snapshot test runnable

This simple bug marker applies to every Java version/weblog, and Test_Debugger_Exception_Replay is @slow, so conftest converts the resulting xfail declaration into an unconditional skip. In Java DEBUGGER_EXCEPTION_REPLAY runs, the updated exception_replay_inner approval added by this commit will therefore never be exercised, masking the snapshot check instead of fixing it; scope the DEBUG-5838 declaration to the affected versions/weblogs or remove it if the approval update resolves the failure.

Useful? React with 👍 / 👎.

@jpbempel
jpbempel merged commit 79ac210 into main Jul 17, 2026
780 of 825 checks passed
@jpbempel
jpbempel deleted the jpbempel/fix-exception-replay-locals branch July 17, 2026 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants