fix exception replay snapshot#7317
Conversation
|
|
🎉 All green!🧪 All tests passed 🔗 Commit SHA: 2e2de7a | Docs | Datadog PR Page | Give us feedback! |
|
Bits Code status: ✅ Done Comment @DataDog to request changes |
a1fe226 to
3e34e14
Compare
hoisted local var are now captured
3e34e14 to
2e2de7a
Compare
There was a problem hiding this comment.
More details
PR updates exception replay test approvals to capture hoisted local variables that the Java tracer now properly includes in snapshots. JSON and YAML are valid; the exception variable ex contains all required fields (type, status, reason, stackTrace, depth). Test fixture changes only — no production code modified.
📊 Validated against 5 scenarios · Open Bits AI session
🤖 Datadog Autotest · Commit 2e2de7a · What is Autotest? · Any feedback? Reach out in #autotest
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2e2de7ab1d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| spring-boot-openliberty: missing_feature | ||
| spring-boot-jetty: missing_feature | ||
| spring-boot-payara: missing_feature | ||
| tests/debugger/test_debugger_exception_replay.py::Test_Debugger_Exception_Replay::test_exception_replay_inner: bug (DEBUG-5838) |
There was a problem hiding this comment.
Keep the snapshot test runnable
This simple bug marker applies to every Java version/weblog, and Test_Debugger_Exception_Replay is @slow, so conftest converts the resulting xfail declaration into an unconditional skip. In Java DEBUGGER_EXCEPTION_REPLAY runs, the updated exception_replay_inner approval added by this commit will therefore never be exercised, masking the snapshot check instead of fixing it; scope the DEBUG-5838 declaration to the affected versions/weblogs or remove it if the approval update resolves the failure.
Useful? React with 👍 / 👎.
Motivation
hoisted local var are now captured
Changes
Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present