Skip to content

fix exception replay snapshot #7317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jpbempel merged 1 commit into from
Jul 17, 2026
+192 −10
Merged

fix exception replay snapshot #7317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions manifests/java.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2981,15 +2981,15 @@ manifest:
- declaration: bug (DEBUG-3285)
component_version: <1.46.0
tests/debugger/test_debugger_exception_replay.py::Test_Debugger_Exception_Replay::test_exception_replay_firsthit: missing_feature (Implemented only for dotnet)
tests/debugger/test_debugger_exception_replay.py::Test_Debugger_Exception_Replay::test_exception_replay_inner:
- declaration: bug (DEBUG-3285)
component_version: <1.46.0
# Added by easy win activation script
- weblog_declaration:
spring-boot-undertow: missing_feature
spring-boot-openliberty: missing_feature
spring-boot-jetty: missing_feature
spring-boot-payara: missing_feature
tests/debugger/test_debugger_exception_replay.py::Test_Debugger_Exception_Replay::test_exception_replay_inner: bug (DEBUG-5838)

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 16, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep the snapshot test runnable

This simple bug marker applies to every Java version/weblog, and Test_Debugger_Exception_Replay is @slow, so conftest converts the resulting xfail declaration into an unconditional skip. In Java DEBUGGER_EXCEPTION_REPLAY runs, the updated exception_replay_inner approval added by this commit will therefore never be exercised, masking the snapshot check instead of fixing it; scope the DEBUG-5838 declaration to the affected versions/weblogs or remove it if the approval update resolves the failure.

Useful? React with 👍 / 👎.

# - declaration: bug (DEBUG-3285)
# component_version: <1.46.0
# Added by easy win activation script
# - weblog_declaration:
# spring-boot-undertow: missing_feature
# spring-boot-openliberty: missing_feature
# spring-boot-jetty: missing_feature
# spring-boot-payara: missing_feature
tests/debugger/test_debugger_exception_replay.py::Test_Debugger_Exception_Replay::test_exception_replay_multiframe:
- declaration: bug (DEBUG-3285)
component_version: <1.46.0
Expand Down
184 changes: 183 additions & 1 deletion tests/debugger/utils/approvals/java/1.5.0/exception_replay_inner_snapshots_expected.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,189 @@
"fields": {}
}
},
"locals": {},
"locals": {
"ex": {
"type": "org.springframework.web.server.ResponseStatusException",
"fields": {
"status": {
"type": "int",
"value": "500"
},
"reason": {
"type": "java.lang.String",
"value": "Inner exception"
},
"backtrace": {
"type": "java.lang.Object[]",
"elements": [
{
"type": "short[]",
"elements": "<scrubbed>",
"size": "32"
},
{
"type": "int[]",
"elements": "<scrubbed>",
"size": "32"
},
{
"type": "java.lang.Object[]",
"elements": [
{
"type": "java.lang.Class",
"value": "com.datadoghq.system_tests.springboot.debugger.ExceptionReplayController"
},
{
"<runtime>": "<scrubbed>"
}
],
"size": "32"
},
{
"type": "long[]",
"elements": "<scrubbed>",
"size": "32"
},
{
"type": "java.lang.Object[]",
"elements": [
{
"type": "short[]",
"notCapturedReason": "depth"
},
{
"type": "int[]",
"notCapturedReason": "depth"
},
{
"type": "java.lang.Object[]",
"notCapturedReason": "depth"
},
{
"type": "long[]",
"notCapturedReason": "depth"
},
{
"type": "java.lang.Object[]",
"notCapturedReason": "depth"
},
{
"<runtime>": "<scrubbed>"
}
],
"size": "5"
},
{
"<runtime>": "<scrubbed>"
}
],
"size": "5"
},
"detailMessage": {
"type": "java.lang.String",
"isNull": true
},
"cause": {
"type": "java.lang.Throwable",
"isNull": true
},
"stackTrace": {
"type": "java.lang.StackTraceElement[]",
"elements": [
{
"type": "java.lang.StackTraceElement",
"fields": {
"declaringClassObject": {
"type": "java.lang.Class",
"isNull": true
},
"classLoaderName": {
"type": "java.lang.String",
"isNull": true
},
"moduleName": {
"type": "java.lang.String",
"isNull": true
},
"moduleVersion": "<scrubbed>",
"declaringClass": {
"type": "java.lang.String",
"value": "com.datadoghq.system_tests.springboot.debugger.ExceptionReplayController"
},
"methodName": {
"type": "java.lang.String",
"value": "exceptionReplayInner"
},
"fileName": {
"type": "java.lang.String",
"value": "ExceptionReplayController.java"
},
"lineNumber": {
"type": "java.lang.Integer",
"value": "32"
},
"format": {
"type": "byte",
"value": "0"
}
}
},
{
"type": "java.lang.StackTraceElement",
"fields": {
"declaringClassObject": {
"type": "java.lang.Class",
"isNull": true
},
"classLoaderName": {
"type": "java.lang.String",
"isNull": true
},
"moduleName": {
"type": "java.lang.String",
"isNull": true
},
"moduleVersion": "<scrubbed>",
"declaringClass": {
"type": "java.lang.String",
"value": "datadog.trace.instrumentation.springweb.HandlerMappingResourceNameFilter"
},
"methodName": {
"type": "java.lang.String",
"value": "doFilterInternal"
},
"fileName": {
"type": "java.lang.String",
"value": "HandlerMappingResourceNameFilter.java"
},
"lineNumber": {
"type": "java.lang.Integer",
"value": "57"
},
"format": {
"type": "byte",
"value": "0"
}
}
},
{
"<runtime>": "<scrubbed>"
}
],
"size": "94"
},
"depth": {
"type": "int",
"value": "94"
},
"suppressedExceptions": {
"type": "java.lang.Throwable[]",
"elements": [],
"size": "0"
}
}
}
},
"staticFields": {},
"throwable": {
"type": "org.springframework.web.server.ResponseStatusException",
Expand Down
Loading