fix: remove cross-variable validation that broke tonumber("latest")#43
Merged
Merged
Conversation
…tonumber("latest")
Terraform does not short-circuit &&/|| in validation conditions, so the
bare tonumber(var.layer_version) call outside can() fails when
layer_version is "latest" (the default). This broke all users after
v1.3.1, not just SQS users.
Remove the cross-variable validation entirely — the layer version
requirement is already documented in the variable description and now
also in the README.
Fixes #40
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
RaphaelAllier
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #40 — since v1.3.1, all Terraform plans fail with
Invalid function argumentbecause Terraform does not short-circuit&&/||in validation conditions. The baretonumber(var.layer_version)outsidecan()blows up whenlayer_versionis"latest"(the default), breaking all users — not just SQS users.Changes
variables.tf— Remove the cross-variable validation block ondd_sqs_queue_urlthat checkedlayer_version >= 97. The layer version requirement remains documented in the variable description.README.md— Add "requires layer version >= 97" to thedd_sqs_queue_urldescription in the inputs table.tests/sqs_failed_events.tftest.hcl— Removesqs_with_old_layer_version_failsandsqs_with_layer_version_97test cases that asserted on the deleted validation.