fix[datadog_metric_active_tags_and_aggregations]: protect against incorrect empty results#3782
Open
mdb wants to merge 1 commit into
Open
fix[datadog_metric_active_tags_and_aggregations]: protect against incorrect empty results#3782mdb wants to merge 1 commit into
mdb wants to merge 1 commit into
Conversation
…w/ quotes
The Read function called ListActiveMetricConfigurations with
state.Metric.String(). On a plugin-framework types.String, .String()
returns the Go-fmt'd representation (fmt.Sprintf("%q", ...)), wrapping
the value in literal double-quotes. A metric like foo.bar reached the
API as "\"foo.bar\"", which the API treats as a non-existent metric
and returns an empty body without erroring, so the data source
silently returned empty active_tags and active_aggregations for every
metric. The correct accessor is .ValueString(), used by every sibling
metric data source in this package.
Also drop the dereference of data.Id (typed *string,omitempty in the
SDK), which would panic on a response missing an id, and set the
resource ID from state.Metric.ValueString() — the value the API
returns today and the convention used elsewhere.
The existing cassette was recorded against the buggy path and encoded
the quoted form in both the request URL and the response id field;
updated to the unquoted form so the existing assertions catch a
regression.
Signed-off-by: Mike Ball <mikedball@gmail.com>
mdb
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3791 to ensure
datadog_metric_active_tags_and_aggregationsdoes not incorrectly return empty results.The Read function called ListActiveMetricConfigurations with state.Metric.String(). On a plugin-framework types.String, .String() returns the Go-fmt'd representation (fmt.Sprintf("%q", ...)), wrapping the value in literal double-quotes. A metric like foo.bar reached the API as ""foo.bar"", which the API treats as a non-existent metric and returns an empty body without erroring, so the data source silently returned empty active_tags and active_aggregations for every metric. The correct accessor is .ValueString(), used by every sibling metric data source in this package.
Also drop the dereference of data.Id (typed *string,omitempty in the SDK), which would panic on a response missing an id, and set the resource ID from state.Metric.ValueString() — the value the API returns today and the convention used elsewhere.
The existing cassette was recorded against the buggy path and encoded the quoted form in both the request URL and the response id field; updated to the unquoted form so the existing assertions catch a regression.