Add slo_query support to datadog_slo_correction#3827
Open
peachprosecutor wants to merge 4 commits into
Open
Conversation
|
- Pin datadog-api-client-go to the merged slo_query commit (v2.60.1-0.20260604185809-a1941aed2f41) so the provider builds against the new SLOCorrection slo_query fields ahead of a tagged client release. - Add recorded TestAccDatadogSloCorrection_SloQuery cassette (recorded against staging, host normalized to api.datadoghq.com); replays green offline. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See API spec PR: https://github.com/DataDog/datadog-api-spec/pull/5816
Updates SLO Correction resource in the datadog provider to support
slo_query, which is used for defining global corrections.slo_queryis an optional, nullable field that is used in place ofslo_id(which targets a single correction). Because of this,slo_idis no longer required and can benullin response payloads for SLO Corrections defined withslo_query.