[TFgen] Phase 1 Setup CLI#3842
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Supam
approved these changes
Jun 2, 2026
42fc65d to
1e28a40
Compare
This was referenced Jun 2, 2026
Member
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
1e28a40 to
6421244
Compare
2 tasks
This was referenced Jun 3, 2026
This was referenced Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

APIR-2491
What this does
Phase 1 scaffolding for the new generator (tfgen): build, CI, and test-fixture
plumbing so later phases have a consistent place to land. No generator logic
yet. Targets the
generator-v2branch, which already has the stubs and deps.Changes
CI workflow (
.github/workflows/tfgen.yml): runsgo buildandgo vetagainst the generator on any PR that touches
.generator-v2/internal/**,.generator-v2/cmd/tfgen/**, or the workflow file. Build and vet only fornow. Unit tests, e2e, coverage, and the
generate --check/verify --strictgates come in later phases.
Make targets:
make tfgen-buildbuilds the binary tobin/tfgen,make tfgen-testrunsgo test ./internal/... ./cmd/tfgen/.... Both runinside the
.generator-v2module and honor aGO=override.Fixture catalogue (
.generator-v2/internal/testdata/fixtures/README.md):documents the per-fixture layout (input
openapi.yaml, committed goldenout/, optional README) so e2e fixtures get added consistently. No fixturesincluded here.
Testing
make tfgen-buildproducesbin/tfgen.make tfgen-testexits 0 (no test files yet).