Skip to content

[TFgen] Phase 1 Setup CLI#3842

Merged
j10czar merged 5 commits into
generator-v2from
jason.tenczar/generator-v2/CLI-setup
Jun 2, 2026
Merged

[TFgen] Phase 1 Setup CLI#3842
j10czar merged 5 commits into
generator-v2from
jason.tenczar/generator-v2/CLI-setup

Conversation

@j10czar
Copy link
Copy Markdown

@j10czar j10czar commented Jun 1, 2026

APIR-2491

What this does

Phase 1 scaffolding for the new generator (tfgen): build, CI, and test-fixture
plumbing so later phases have a consistent place to land. No generator logic
yet. Targets the generator-v2 branch, which already has the stubs and deps.

Changes

  • CI workflow (.github/workflows/tfgen.yml): runs go build and go vet
    against the generator on any PR that touches .generator-v2/internal/**,
    .generator-v2/cmd/tfgen/**, or the workflow file. Build and vet only for
    now. Unit tests, e2e, coverage, and the generate --check / verify --strict
    gates come in later phases.

  • Make targets: make tfgen-build builds the binary to bin/tfgen,
    make tfgen-test runs go test ./internal/... ./cmd/tfgen/.... Both run
    inside the .generator-v2 module and honor a GO= override.

  • Fixture catalogue (.generator-v2/internal/testdata/fixtures/README.md):
    documents the per-fixture layout (input openapi.yaml, committed golden
    out/, optional README) so e2e fixtures get added consistently. No fixtures
    included here.

Testing

  • make tfgen-build produces bin/tfgen.
  • make tfgen-test exits 0 (no test files yet).
  • Workflow runs build + vet clean.

@j10czar j10czar requested a review from a team as a code owner June 1, 2026 18:46
@datadog-datadog-prod-us1-2

This comment has been minimized.

@j10czar j10czar changed the title [Phase 1] Setup CLI [TFgen] Phase 1 Setup CLI Jun 1, 2026
Copy link
Copy Markdown
Member

Supam commented Jun 2, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@j10czar j10czar force-pushed the jason.tenczar/generator-v2/CLI-setup branch from 1e28a40 to 6421244 Compare June 2, 2026 15:14
@j10czar j10czar merged commit 022f705 into generator-v2 Jun 2, 2026
7 of 8 checks passed
@j10czar j10czar deleted the jason.tenczar/generator-v2/CLI-setup branch June 2, 2026 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants