Updated Notebooks - DatasetAPI & Bucket-Join#212
Open
uditgt wants to merge 4 commits intoDataExpert-io:mainfrom
Open
Updated Notebooks - DatasetAPI & Bucket-Join#212uditgt wants to merge 4 commits intoDataExpert-io:mainfrom
uditgt wants to merge 4 commits intoDataExpert-io:mainfrom
Conversation
Fixes issues with DatasetAPI notebook preventing it from executing. And using batch processing in Bucket-Join-In-Iceberg notebook to prevent OOM error.
Corrected 'current_year' filter in the query and cast it as BIGINT instead of INTEGER
Corrected schema and expected dataframe
Author
|
pytest ran successfully on |
Added a step for creating a user and database in Postgres before loading data.
EcZachly
approved these changes
Aug 6, 2025
Member
EcZachly
left a comment
EcZachly
left a comment
There was a problem hiding this comment.
The updates in Notebook regarding DatasetAPI and batch processing improvements enhance the workbook's execution efficiency and prevent errors, like OOM.
Recommendation: Approve for Merge
EcZachly
requested changes
Aug 6, 2025
Member
EcZachly
left a comment
EcZachly
left a comment
There was a problem hiding this comment.
Revoke previous approval due to changes needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issues with DatasetAPI notebook preventing it from executing. And using batch processing in Bucket-Join-In-Iceberg notebook to prevent OOM error.