Fix: Incorrect table name in do_team_vertex_transformation's write operation#288
Open
PrinceSajjadHussain wants to merge 1 commit intoDataExpert-io:mainfrom
Open
Fix: Incorrect table name in do_team_vertex_transformation's write operation#288PrinceSajjadHussain wants to merge 1 commit intoDataExpert-io:mainfrom
do_team_vertex_transformation's write operation#288PrinceSajjadHussain wants to merge 1 commit intoDataExpert-io:mainfrom
Conversation
EcZachly
approved these changes
Aug 6, 2025
Member
EcZachly
left a comment
EcZachly
left a comment
There was a problem hiding this comment.
The fix for the table name in do_team_vertex_transformation is necessary to prevent errors and ensure data is written to the correct table. This correction aligns with the intended job functionality.
Recommendation: Approve for Merge
EcZachly
requested changes
Aug 6, 2025
Member
EcZachly
left a comment
EcZachly
left a comment
There was a problem hiding this comment.
Revoke previous approval due to changes needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the
team_vertex_job.pyfile, themainfunction incorrectly attempts to write the output DataFrame into a table named"players_scd", which is likely meant for the players SCD job. This will cause an error if the table does not exist or write data to the wrong table.Fix:
--- a/bootcamp/materials/3-spark-fundamentals/src/jobs/team_vertex_job.py
+++ b/bootcamp/materials/3-spark-fundamentals/src/jobs/team_vertex_job.py
@@ -42,4 +42,4 @@
.appName("players_scd")
.getOrCreate()
output_df = do_team_vertex_transformation(spark, spark.table("players"))