Skip to content

Commit 48fc2c3

Browse files
aarthy-dkclaude
andcommitted
fix(test-definitions): import Tooltip in Link and drop external-URL underline
Address review feedback on the click-through link: - Link referenced Tooltip without importing it, so any Link given a `tooltip` (the test-results external-link cell) threw at render. Import it from tooltip.js. - In the result test-definition summary, the external URL used `underline` plus a full-width link, so the hover underline spanned the panel and read as a divider. Drop the underline (the open_in_new icon is enough affordance) and size the link to content (max-width instead of width) so long URLs still wrap. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
1 parent a66c85f commit 48fc2c3

2 files changed

Lines changed: 1 addition & 2 deletions

File tree

testgen/ui/components/frontend/js/pages/test_definition_summary.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,6 @@ const TestDefinitionSummary = (props) => {
126126
href: testDefinition.external_url.trim(),
127127
label: testDefinition.external_url.trim(),
128128
open_new: true,
129-
underline: true,
130129
right_icon: 'open_in_new',
131130
right_icon_size: 16,
132131
})
@@ -174,7 +173,6 @@ stylesheet.replace(`
174173
overflow-wrap: anywhere;
175174
}
176175
.external-url-attribute .tg-link {
177-
width: 100%;
178176
max-width: 100%;
179177
}
180178
.external-url-attribute .tg-link--wrapper {

testgen/ui/static/js/components/link.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
* @property {((event: any) => void)?} onClick
2121
*/
2222
import { getValue, loadStylesheet } from '../utils.js';
23+
import { Tooltip } from './tooltip.js';
2324
import van from '../van.min.js';
2425

2526
const { a, div, i, span } = van.tags;

0 commit comments

Comments
 (0)