Merge branch 'qa-fixes' into 'enterprise'

fix: misc qa fixes

See merge request dkinternal/testgen/dataops-testgen!579

Author: ci bot

testgen/common/monitor_forecast.py

@@ -120,11 +120,16 @@ def gated_forecast_prediction(
     # typed throughout (baseline is already a float).
     lower_tol = float(definition.lower_tolerance) if definition.lower_tolerance is not None else None
     upper_tol = float(definition.upper_tolerance) if definition.upper_tolerance is not None else None
+    # The band carries the next-refresh tolerance across the whole forecast, flat anchor included.
+    # Anchoring the band to the tolerance — rather than collapsing it to the baseline at the flat
+    # anchor — keeps it a continuous width that connects to the historical band and avoids a
+    # zero-width pinch (which renders as an hourglass for a future window, or a band detached from
+    # history for an imminent one). The mean line still holds flat at baseline, then steps.
     return {
         "method": "predict",
         "mean": {flat_anchor: baseline, window_end: next_refresh_mean},
-        "lower_tolerance": {flat_anchor: baseline, window_end: lower_tol},
-        "upper_tolerance": {flat_anchor: baseline, window_end: upper_tol},
+        "lower_tolerance": {flat_anchor: lower_tol, window_end: lower_tol},
+        "upper_tolerance": {flat_anchor: upper_tol, window_end: upper_tol},
     }
 
 

testgen/template/dbsetup_test_types/test_types_Valid_Characters.yaml

@@ -21,7 +21,8 @@ test_types:
   default_parm_columns: threshold_value
   default_parm_values: |-
     0
-  default_parm_prompts: null
+  default_parm_prompts: |-
+    Threshold Invalid Value Count
   default_parm_help: |-
     The acceptable number of records with invalid character values present.
   default_severity: Warning

testgen/template/dbsetup_test_types/test_types_Valid_US_Zip.yaml

@@ -21,7 +21,8 @@ test_types:
   default_parm_columns: threshold_value
   default_parm_values: |-
     0
-  default_parm_prompts: null
+  default_parm_prompts: |-
+    Threshold Invalid Value Count
   default_parm_help: null
   default_severity: Warning
   run_type: CAT

testgen/template/dbsetup_test_types/test_types_Valid_US_Zip3.yaml

@@ -21,7 +21,8 @@ test_types:
   default_parm_columns: threshold_value
   default_parm_values: |-
     0
-  default_parm_prompts: null
+  default_parm_prompts: |-
+    Threshold Invalid Value Count
   default_parm_help: null
   default_severity: Warning
   run_type: CAT

testgen/ui/components/frontend/js/data_profiling/metadata_tags.js

@@ -100,6 +100,7 @@ const MetadataTagsCard = (props, item) => {
             help: TAG_HELP[key],
             label: key === 'pii_flag' ? 'PII Data' : capitalize(key.replaceAll('_', ' ')),
             state: van.state(value),
+            initialValue: value,
             inheritTableGroup: item[`table_group_${key}`] ?? null, // Table group values inherited by table or column
             inheritTable: item[`table_${key}`] ?? null, // Table values inherited by column
         };
@@ -198,13 +199,15 @@ const MetadataTagsCard = (props, item) => {
             content, editingContent,
             onSave: () => {
                 const items = [{ type: item.type, id: item.id }];
-                const tags = attributes.reduce((object, { key, state }) => {
-                    object[key] = state.rawVal;
+                const tags = attributes.reduce((object, { key, state, initialValue }) => {
+                    if (state.rawVal !== initialValue) {
+                        object[key] = state.rawVal;
+                    }
                     return object;
                 }, {});
 
-                warnCde.val = props.autoflagSettings.profile_flag_cdes && tags.critical_data_element !== item.critical_data_element;
-                warnPii.val = props.autoflagSettings.profile_flag_pii && tags.pii_flag !== item.pii_flag;
+                warnCde.val = props.autoflagSettings.profile_flag_cdes && 'critical_data_element' in tags;
+                warnPii.val = props.autoflagSettings.profile_flag_pii && 'pii_flag' in tags;
 
                 if (warnCde.val || warnPii.val) {
                     const disableFlags = [];
@@ -221,8 +224,8 @@ const MetadataTagsCard = (props, item) => {
                 } 
             },
             // Reset states to original values on cancel
-            onCancel: () => attributes.forEach(({ key, state }) => state.val = item[key]),
-            hasChanges: () => attributes.some(({ key, state }) => state.val !== item[key]),
+            onCancel: () => attributes.forEach(({ state, initialValue }) => state.val = initialValue),
+            hasChanges: () => attributes.some(({ state, initialValue }) => state.val !== initialValue),
         }),
         WarningDialog(warningDialogOpen, pendingSaveAction, warnCde, warnPii),
     );

testgen/ui/components/frontend/js/pages/test_definitions.js

@@ -21,6 +21,7 @@ import { ProfilingResultsDialog } from '../shared/profiling_results_dialog.js';
 import { AXES, FACET_AXES, GROUP_BY_AXES, EMPTY, appliesToSelectedColumn } from '/app/static/js/components/test_picker_taxonomy.js';
 import { enterPage, exitPage, getPageSignal } from '/app/static/js/page_lifecycle.js';
 import { jsonObject, maxLength } from '/app/static/js/form_validators.js';
+import { capitalize } from '/app/static/js/display_utils.js';
 
 const { button: btn, div, i: icon, span, strong } = van.tags;
 
@@ -820,6 +821,8 @@ const DetailPanel = (row) => {
     const paramCols = row.default_parm_columns
         ? row.default_parm_columns.split(',').map(c => c.trim()).filter(Boolean)
         : [];
+    const paramLabels = (row.default_parm_prompts || '').split(',').map(v => v.trim());
+    const paramHelp = (row.default_parm_help || '').split('|').map(v => v.trim());
 
     return div(
         { class: 'flex-column fx-gap-3 border border-radius-1 p-4 mt-2' },
@@ -836,7 +839,11 @@ const DetailPanel = (row) => {
                 Attribute({ label: 'Lock Refresh', value: row.lock_refresh_display }),
                 Attribute({ label: 'Urgency', value: row.urgency }),
                 Attribute({ label: 'Export to Observability', value: row.export_to_observability_display }),
-                ...paramCols.map(col => Attribute({ label: col, value: String(row[col] ?? '') })),
+                ...paramCols.map((col, index) => Attribute({
+                    label: paramLabels[index] || capitalize(col.replaceAll('_', ' ')),
+                    help: paramHelp[index] || null,
+                    value: String(row[col] ?? ''),
+                })),
             ),
             div(
                 { class: 'flex-column fx-flex fx-gap-3' },

testgen/ui/static/js/components/test_definition_form.js

@@ -73,6 +73,7 @@ import { Textarea } from './textarea.js';
 import { RadioGroup } from './radio_group.js';
 import { Caption } from './caption.js';
 import { numberBetween, required } from '../form_validators.js';
+import { capitalize } from '../display_utils.js';
 
 const { div, span } = van.tags;
 
@@ -108,7 +109,7 @@ const TestDefinitionForm = (/** @type Properties */ props) => {
         .map((column, index) => ({
             ...(PARAMETER_CONFIG[column] || { type: 'text' }),
             column,
-            label: paramLabels[index] || column.replaceAll('_', ' '),
+            label: paramLabels[index] || capitalize(column.replaceAll('_', ' ')),
             help: paramHelp[index] || null,
             validators: paramRequired[index] ? [required] : undefined,
         }))

tests/unit/ui/test_monitors_dashboard.py

@@ -135,10 +135,12 @@ def test_gated_prediction_anchors_at_now_when_window_started():
     mean = {str(NOW_MS + 3 * HOUR): 1200.0, str(NOW_MS + 27 * HOUR): 1300.0}
     result = gated_forecast_prediction(_gated_def(mean=mean), window, LAST_RUN)
     assert result["method"] == "predict"
+    # mean holds flat at baseline then steps to the next-refresh forecast
     assert result["mean"] == {NOW_MS: 1000.0, NOW_MS + 3 * HOUR: 1200.0}
-    # tolerances coerced from VARCHAR to float
-    assert result["lower_tolerance"] == {NOW_MS: 1000.0, NOW_MS + 3 * HOUR: 950.0}
-    assert result["upper_tolerance"] == {NOW_MS: 1000.0, NOW_MS + 3 * HOUR: 1400.0}
+    # band carries the next-refresh tolerance across the whole forecast (continuous width, no
+    # zero-width pinch at the flat anchor); coerced from VARCHAR to float
+    assert result["lower_tolerance"] == {NOW_MS: 950.0, NOW_MS + 3 * HOUR: 950.0}
+    assert result["upper_tolerance"] == {NOW_MS: 1400.0, NOW_MS + 3 * HOUR: 1400.0}
 
 
 def test_gated_prediction_anchors_at_window_start_when_future():