Merge branch 'aarthy/text-fixes' into 'enterprise'

fix(monitors): misc style and quick start updates

See merge request dkinternal/testgen/dataops-testgen!399

Author: ci bot

testgen/commands/run_quick_start.py

@@ -1,4 +1,5 @@
 import logging
+import math
 import random
 from datetime import datetime
 from typing import Any
@@ -116,6 +117,19 @@ def _get_quick_start_params_mapping(iteration: int = 0) -> dict:
     }
 
 
+def _metric_cumulative_shift(iteration: int) -> tuple[float, float]:
+    """Compute cumulative metric shifts at a given iteration for Metric_Trend monitors.
+
+    Returns (discount_shift, price_shift) — the total shift from baseline
+    that should be applied to the underlying data at this iteration.
+    Uses composite sine waves for organic-looking oscillation patterns.
+    """
+    i = iteration
+    discount = -1.0 + 1.8 * math.sin(2 * math.pi * i / 14 + math.pi) + 0.7 * math.sin(2 * math.pi * i / 6 + math.pi + 0.5)
+    price = 80 * math.sin(2 * math.pi * i / 16) + 40 * math.sin(2 * math.pi * i / 7 + 0.3) + 100
+    return discount, price
+
+
 def _get_monitor_params_mapping(run_date: datetime, iteration: int = 0) -> dict:
     # Volume: linear growth with jitter, spike at specific iteration for anomaly
     if iteration == 37:
@@ -126,6 +140,12 @@ def _get_monitor_params_mapping(run_date: datetime, iteration: int = 0) -> dict:
     # Freshness: update every other iteration, late update for anomaly
     is_update_suppliers_iter = (iteration % 2 == 0 and iteration != 38) or iteration == 39
 
+    # Metrics: compute deltas for discount and price shifts
+    curr_discount, curr_price = _metric_cumulative_shift(iteration)
+    prev_discount, prev_price = _metric_cumulative_shift(iteration - 1) if iteration > 1 else (0.0, 0.0)
+    discount_delta = round(curr_discount - prev_discount, 3)
+    price_delta = round(curr_price - prev_price, 2)
+
     return {
         **_get_settings_params_mapping(),
         "ITERATION_NUMBER": iteration,
@@ -137,6 +157,8 @@ def _get_monitor_params_mapping(run_date: datetime, iteration: int = 0) -> dict:
         "IS_CREATE_RETURNS_TABLE_ITER": iteration == 32,
         "IS_DELETE_CUSTOMER_ITER": iteration in (18, 22, 34),
         "IS_UPDATE_SUPPLIERS_ITER": is_update_suppliers_iter,
+        "DISCOUNT_DELTA": discount_delta,
+        "PRICE_DELTA": price_delta,
     }
 
 

testgen/template/dbsetup_test_types/test_types_Aggregate_Balance.yaml

@@ -4,7 +4,7 @@ test_types:
   test_name_short: Aggregate Balance
   test_name_long: Aggregate values per group match reference
   test_description: |-
-    Tests for exact match in aggregate values for each set of column values vs. reference dataset
+    Tests for exact match in aggregate measure for each set of column values compared to reference dataset.
   except_message: |-
     Aggregate measure per set of column values does not exactly match reference dataset.
   measure_uom: Mismatched measures

testgen/template/dbsetup_test_types/test_types_Aggregate_Balance_Percent.yaml

@@ -4,7 +4,7 @@ test_types:
   test_name_short: Aggregate Balance Percent
   test_name_long: Aggregate measure per group within percent of reference
   test_description: |-
-    Tests that aggregate measure for each set of column values fall within a percent range above or below the measure for reference dataset
+    Tests that aggregate measure for each set of column values falls within a percent range above or below the measure for reference dataset.
   except_message: |-
     Aggregate measure per set of column values is outside percent range of reference dataset.
   measure_uom: Mismatched measures

testgen/template/dbsetup_test_types/test_types_Aggregate_Balance_Range.yaml

@@ -4,7 +4,7 @@ test_types:
   test_name_short: Aggregate Balance Range
   test_name_long: Aggregate measure per group within hard range of reference
   test_description: |-
-    Tests that aggregate measure for each set of column values fall within a hard range above or below the measure for reference dataset
+    Tests that aggregate measure for each set of column values falls within a hard range above or below the measure for reference dataset.
   except_message: |-
     Aggregate measure per set of column values is outside expected range of reference dataset.
   measure_uom: Mismatched measures

testgen/template/dbsetup_test_types/test_types_Aggregate_Minimum.yaml

@@ -4,7 +4,7 @@ test_types:
   test_name_short: Aggregate Minimum
   test_name_long: Aggregate values per group are at or above reference
   test_description: |-
-    Tests that aggregate values for each set of column values are at least the same as reference dataset
+    Tests that aggregate values for each set of column values are at least the same as reference dataset.
   except_message: |-
     Aggregate measure per set of column values is not at least the same as reference dataset.
   measure_uom: Mismatched measures

testgen/template/dbsetup_test_types/test_types_Alpha_Trunc.yaml

@@ -4,9 +4,9 @@ test_types:
   test_name_short: Alpha Truncation
   test_name_long: Maximum character count consistent
   test_description: |-
-    Tests that the maximum count of characters in a column value has not dropped vs. baseline data
+    Tests that maximum count of characters in column values has not dropped compared to baseline data.
   except_message: |-
-    Maximum length of values has dropped from prior expected length.
+    Maximum length of values has dropped compared to baseline.
   measure_uom: Values over max
   measure_uom_description: null
   selection_criteria: |-

testgen/template/dbsetup_test_types/test_types_Avg_Shift.yaml

@@ -4,7 +4,7 @@ test_types:
   test_name_short: Average Shift
   test_name_long: Column mean is consistent with reference
   test_description: |-
-    Tests for statistically-significant shift in mean value for column from average calculated at baseline.
+    Tests for statistically significant shift in mean value for column from average calculated at baseline.
   except_message: |-
     Standardized difference between averages is over the selected threshold level.
   measure_uom: Difference Measure

testgen/template/dbsetup_test_types/test_types_CUSTOM.yaml

@@ -4,7 +4,7 @@ test_types:
   test_name_short: Custom Test
   test_name_long: Custom-defined business rule
   test_description: |-
-    Custom SQL Query Test
+    Custom SQL Query Test. A highly flexible business-rule test covering any error state that can be expressed by a SQL query against one or more tables in the database.
   except_message: |-
     Errors were detected according to test definition.
   measure_uom: Errors found

testgen/template/dbsetup_test_types/test_types_Combo_Match.yaml

@@ -4,7 +4,7 @@ test_types:
   test_name_short: Reference Match
   test_name_long: Column values or combinations found in reference
   test_description: |-
-    Tests for the presence of one or a set of column values in a reference table
+    Tests for the presence of one or a set of column values in reference dataset.
   except_message: |-
     Column value combinations are not found in reference table values.
   measure_uom: Missing values

testgen/template/dbsetup_test_types/test_types_Condition_Flag.yaml

@@ -4,9 +4,9 @@ test_types:
   test_name_short: Custom Condition
   test_name_long: Column values match pre-defined condition
   test_description: |-
-    Tests that each record in the table matches a pre-defined, custom condition
+    Tests that each record in the table matches a predefined custom condition.
   except_message: |-
-    Value(s) found not matching defined condition.
+    Values found not matching defined condition.
   measure_uom: Values Failing
   measure_uom_description: null
   selection_criteria: null