Skip to content

Commit b2f0381

Browse files
committed
fix(ui): misc changes to hygiene issues and test results
1 parent 80d40e4 commit b2f0381

4 files changed

Lines changed: 15 additions & 15 deletions

File tree

testgen/ui/pdf/hygiene_issue_report.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ def build_summary_table(document, hi_data):
108108
),
109109

110110
("Profiling Date", profiling_timestamp, "Table Group", hi_data["table_groups_name"]),
111-
("Database/Schema", hi_data["schema_name"], "Disposition", hi_data["disposition"] or "No Decision"),
111+
("Database/Schema", hi_data["schema_name"], "Action", hi_data["disposition"] or "No Decision"),
112112
("Table", hi_data["table_name"], "Data Type", hi_data["db_data_type"]),
113113
("Column", hi_data["column_name"], "Semantic Data Type", hi_data["functional_data_type"]),
114114
(

testgen/ui/pdf/test_result_report.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ def build_summary_table(document, tr_data):
123123
("Test Run Date", test_timestamp, None, "Test Suite", tr_data["test_suite"]),
124124
("Database/Schema", tr_data["schema_name"], None, "Table Group", tr_data["table_groups_name"]),
125125
("Table", tr_data["table_name"], None, "Data Quality Dimension", tr_data["dq_dimension"]),
126-
("Column", tr_data["column_names"], None, "Disposition", tr_data["disposition"] or "No Decision"),
126+
("Column", tr_data["column_names"], None, "Action", tr_data["disposition"] or "No Decision"),
127127
(
128128
"Column Tags",
129129
(

testgen/ui/views/hygiene_issues.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -468,11 +468,6 @@ def source_data_dialog(selected_row):
468468
st.markdown("#### Hygiene Issue Detail")
469469
st.caption(selected_row["detail"])
470470

471-
st.markdown("#### SQL Query")
472-
query = get_hygiene_issue_source_query(selected_row)
473-
if query:
474-
st.code(query, language="sql", wrap_lines=True, height=100)
475-
476471
with st.spinner("Retrieving source data..."):
477472
bad_data_status, bad_data_msg, _, df_bad = get_hygiene_issue_source_data(selected_row, limit=500)
478473
if bad_data_status in {"ND", "NA"}:
@@ -492,6 +487,11 @@ def source_data_dialog(selected_row):
492487
# Display the dataframe
493488
st.dataframe(df_bad, width=1050, hide_index=True)
494489

490+
st.markdown("#### SQL Query")
491+
query = get_hygiene_issue_source_query(selected_row)
492+
if query:
493+
st.code(query, language="sql", wrap_lines=True, height=100)
494+
495495

496496
def do_disposition_update(selected, str_new_status):
497497
str_result = None

testgen/ui/views/test_results.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -825,14 +825,6 @@ def source_data_dialog(selected_row):
825825
st.markdown("#### Result Detail")
826826
st.caption(selected_row["result_message"].replace("*", "\\*"))
827827

828-
st.markdown("#### SQL Query")
829-
if selected_row["test_type"] == "CUSTOM":
830-
query = get_test_issue_source_query_custom(selected_row)
831-
else:
832-
query = get_test_issue_source_query(selected_row)
833-
if query:
834-
st.code(query, language="sql", wrap_lines=True, height=100)
835-
836828
with st.spinner("Retrieving source data..."):
837829
if selected_row["test_type"] == "CUSTOM":
838830
bad_data_status, bad_data_msg, _, df_bad = get_test_issue_source_data_custom(selected_row, limit=500)
@@ -855,6 +847,14 @@ def source_data_dialog(selected_row):
855847
# Display the dataframe
856848
st.dataframe(df_bad, width=1050, hide_index=True)
857849

850+
st.markdown("#### SQL Query")
851+
if selected_row["test_type"] == "CUSTOM":
852+
query = get_test_issue_source_query_custom(selected_row)
853+
else:
854+
query = get_test_issue_source_query(selected_row)
855+
if query:
856+
st.code(query, language="sql", wrap_lines=True, height=100)
857+
858858

859859
def view_edit_test(button_container, test_definition_id):
860860
if test_definition_id:

0 commit comments

Comments
 (0)