Merge branch 'feat/TG-982-unit-test-improvements' into 'enterprise'

test(TG-982): improve unit test suite

See merge request dkinternal/testgen/dataops-testgen!408

Author: ci bot

testgen/common/notifications/monitor_run.py

@@ -4,7 +4,6 @@
 from testgen.common.models.notification_settings import (
     MonitorNotificationSettings,
     MonitorNotificationTrigger,
-    NotificationEvent,
 )
 from testgen.common.models.project import Project
 from testgen.common.models.settings import PersistedSetting
@@ -174,7 +173,6 @@ def send_monitor_notifications(test_run: TestRun, result_list_ct=20):
     notifications = list(MonitorNotificationSettings.select(
         enabled=True,
         test_suite_id=test_run.test_suite_id,
-        event=NotificationEvent.monitor_run,
     ))
     if not notifications:
         return

testgen/common/notifications/test_run.py

@@ -4,7 +4,6 @@
 
 from testgen.common.models import get_current_session, with_database_session
 from testgen.common.models.notification_settings import (
-    NotificationEvent,
     TestRunNotificationSettings,
     TestRunNotificationTrigger,
 )
@@ -249,7 +248,6 @@ def send_test_run_notifications(test_run: TestRun, result_list_ct=20, result_sta
     notifications = list(TestRunNotificationSettings.select(
       enabled=True,
       test_suite_id=test_run.test_suite_id,
-      event=NotificationEvent.test_run,
     ))
     if not notifications:
         return

…ts/unit/test_refresh_data_chars_query.py …queries/test_refresh_data_chars_query.pytests/unit/test_refresh_data_chars_query.py renamed to tests/unit/commands/queries/test_refresh_data_chars_query.py tests/unit/test_refresh_data_chars_query.py renamed to tests/unit/commands/queries/test_refresh_data_chars_query.py

@@ -4,8 +4,9 @@
 from testgen.common.models.connection import Connection
 from testgen.common.models.table_group import TableGroup
 
+pytestmark = pytest.mark.unit
+
 
-@pytest.mark.unit
 def test_include_exclude_mask_basic():
     connection = Connection(sql_flavor="postgresql")
     table_group = TableGroup(
@@ -26,7 +27,6 @@ def test_include_exclude_mask_basic():
             )""" in query
 
 
-@pytest.mark.unit
 @pytest.mark.parametrize("mask", ("", None))
 def test_include_empty_exclude_mask(mask):
     connection = Connection(sql_flavor="snowflake")
@@ -44,7 +44,6 @@ def test_include_empty_exclude_mask(mask):
             )""" in query
 
 
-@pytest.mark.unit
 @pytest.mark.parametrize("mask", ("", None))
 def test_include_empty_include_mask(mask):
     connection = Connection(sql_flavor="mssql")
@@ -60,3 +59,51 @@ def test_include_empty_include_mask(mask):
     assert r"""AND (
                 (c.table_name LIKE 'important%' ) OR (c.table_name LIKE '%useful[_]%' )
             )""" in query
+
+
+def test_table_set_only():
+    connection = Connection(sql_flavor="postgresql")
+    table_group = TableGroup(
+        table_group_schema="test_schema",
+        profiling_table_set="users, orders, products",
+        profiling_include_mask="",
+        profiling_exclude_mask="",
+    )
+    sql_generator = RefreshDataCharsSQL(connection, table_group)
+    criteria = sql_generator._get_table_criteria()
+
+    assert "IN ('users','orders','products')" in criteria
+    assert "LIKE" not in criteria
+
+
+@pytest.mark.parametrize("include", ("", None))
+@pytest.mark.parametrize("exclude", ("", None))
+def test_no_filters(include, exclude):
+    connection = Connection(sql_flavor="postgresql")
+    table_group = TableGroup(
+        table_group_schema="test_schema",
+        profiling_table_set="",
+        profiling_include_mask=include,
+        profiling_exclude_mask=exclude,
+    )
+    sql_generator = RefreshDataCharsSQL(connection, table_group)
+    criteria = sql_generator._get_table_criteria()
+
+    assert criteria == ""
+
+
+def test_table_set_with_include_exclude():
+    connection = Connection(sql_flavor="postgresql")
+    table_group = TableGroup(
+        table_group_schema="test_schema",
+        profiling_table_set="users, orders",
+        profiling_include_mask="important%",
+        profiling_exclude_mask="temp%",
+    )
+    sql_generator = RefreshDataCharsSQL(connection, table_group)
+    criteria = sql_generator._get_table_criteria()
+
+    assert "IN ('users','orders')" in criteria
+    assert "LIKE 'important%'" in criteria
+    assert "AND NOT" in criteria
+    assert "LIKE 'temp%'" in criteria

…/unit/test_run_observability_exporter.py …mands/test_run_observability_exporter.pytests/unit/test_run_observability_exporter.py renamed to tests/unit/commands/test_run_observability_exporter.py tests/unit/test_run_observability_exporter.py renamed to tests/unit/commands/test_run_observability_exporter.py

@@ -6,6 +6,8 @@
     calculate_chunk_size,
 )
 
+pytestmark = pytest.mark.unit
+
 
 @pytest.fixture()
 def test_outcome():
@@ -22,7 +24,6 @@ def test_outcome():
     }
 
 
-@pytest.mark.unit
 @pytest.mark.parametrize(
     "test_outcomes_length",
     [1, 100, 10000],
@@ -40,7 +41,6 @@ def test_calculate_chunk_size(test_outcome, test_outcomes_length):
     assert 100 < chunk_size < 500
 
 
-@pytest.mark.unit
 @pytest.mark.parametrize(
     "profiling_table_set, expected_outcome",
     (
@@ -54,7 +54,6 @@ def test_get_processed_profiling_table_set(profiling_table_set, expected_outcome
     assert expected_outcome == actual_outcome
 
 
-@pytest.mark.unit
 @pytest.mark.parametrize(
     "input_parameters, expected_outcome",
     (

tests/unit/common/models/test_custom_types.py

@@ -0,0 +1,132 @@
+from datetime import UTC, datetime
+from unittest.mock import patch
+
+import pytest
+
+from testgen.common.models.custom_types import (
+    EncryptedBytea,
+    EncryptedJson,
+    NullIfEmptyString,
+    UpdateTimestamp,
+    YNString,
+    ZeroIfEmptyInteger,
+)
+
+pytestmark = pytest.mark.unit
+
+
+# --- NullIfEmptyString ---
+
+@pytest.mark.parametrize(
+    "value, expected",
+    [
+        ("", None),
+        ("hello", "hello"),
+        (None, None),
+    ],
+)
+def test_null_if_empty_string(value, expected):
+    t = NullIfEmptyString()
+    assert t.process_bind_param(value, None) == expected
+
+
+# --- YNString ---
+
+@pytest.mark.parametrize(
+    "value, expected",
+    [
+        (True, "Y"),
+        (False, "N"),
+        ("Y", "Y"),
+        ("N", "N"),
+        (None, None),
+    ],
+)
+def test_yn_string_bind(value, expected):
+    t = YNString()
+    assert t.process_bind_param(value, None) == expected
+
+
+@pytest.mark.parametrize(
+    "value, expected",
+    [
+        ("Y", True),
+        ("N", False),
+        (None, None),
+    ],
+)
+def test_yn_string_result(value, expected):
+    t = YNString()
+    assert t.process_result_value(value, None) == expected
+
+
+# --- ZeroIfEmptyInteger ---
+
+@pytest.mark.parametrize(
+    "value, expected",
+    [
+        (5, 5),
+        (0, 0),
+        ("", 0),
+        (None, 0),
+    ],
+)
+def test_zero_if_empty_integer(value, expected):
+    t = ZeroIfEmptyInteger()
+    assert t.process_bind_param(value, None) == expected
+
+
+# --- UpdateTimestamp ---
+
+def test_update_timestamp():
+    t = UpdateTimestamp()
+    before = datetime.now(UTC)
+    result = t.process_bind_param("ignored", None)
+    after = datetime.now(UTC)
+    assert before <= result <= after
+
+
+# --- EncryptedBytea roundtrip ---
+
+@patch("testgen.common.encrypt.settings")
+def test_encrypted_bytea_roundtrip(mock_settings):
+    mock_settings.APP_ENCRYPTION_SALT = "testsalt12345678"
+    mock_settings.APP_ENCRYPTION_SECRET = "testsecret123456"  # noqa: S105
+
+    t = EncryptedBytea()
+    original = "sensitive data"
+
+    encrypted = t.process_bind_param(original, None)
+    assert encrypted != original.encode()
+
+    decrypted = t.process_result_value(encrypted, None)
+    assert decrypted == original
+
+
+@patch("testgen.common.encrypt.settings")
+def test_encrypted_bytea_none(mock_settings):
+    t = EncryptedBytea()
+    assert t.process_bind_param(None, None) is None
+    assert t.process_result_value(None, None) is None
+
+
+# --- EncryptedJson roundtrip ---
+
+@patch("testgen.common.encrypt.settings")
+def test_encrypted_json_roundtrip(mock_settings):
+    mock_settings.APP_ENCRYPTION_SALT = "testsalt12345678"
+    mock_settings.APP_ENCRYPTION_SECRET = "testsecret123456"  # noqa: S105
+
+    t = EncryptedJson()
+    original = {"key": "value", "num": 42, "list": [1, 2, 3]}
+
+    encrypted = t.process_bind_param(original, None)
+    decrypted = t.process_result_value(encrypted, None)
+    assert decrypted == original
+
+
+@patch("testgen.common.encrypt.settings")
+def test_encrypted_json_none(mock_settings):
+    t = EncryptedJson()
+    assert t.process_bind_param(None, None) is None
+    assert t.process_result_value(None, None) is None

tests/unit/test_common_email.py …ommon/notifications/test_common_email.pytests/unit/test_common_email.py renamed to tests/unit/common/notifications/test_common_email.py tests/unit/test_common_email.py renamed to tests/unit/common/notifications/test_common_email.py

@@ -4,6 +4,8 @@
 
 from testgen.common.notifications.base import BaseEmailTemplate, EmailTemplateException
 
+pytestmark = pytest.mark.unit
+
 
 class TestEmailTemplate(BaseEmailTemplate):