Merge branch 'fix/TG-1135-mcp-qa-fixes' into 'enterprise'

fix(mcp): list_table_groups 500, profiling-run PII counts, schedule id display

See merge request dkinternal/testgen/dataops-testgen!580

Author: ci bot

testgen/common/models/table_group.py

@@ -583,7 +583,7 @@ def _list_with_activity(
         latest_profile AS (
             SELECT pr.table_groups_id, MAX(je.started_at) AS started_at
             FROM profiling_runs pr
-                LEFT JOIN job_executions je ON je.id = pr.job_execution_id
+                LEFT JOIN job_executions je ON je.id = pr.id
             GROUP BY pr.table_groups_id
         ),
         latest_test AS (

testgen/mcp/tools/profiling.py

@@ -14,6 +14,7 @@
     DataColumnChars,
 )
 from testgen.common.models.data_table import DataTable
+from testgen.common.models.hygiene_issue import HygieneIssue
 from testgen.common.models.job_execution import JobExecution
 from testgen.common.models.profile_result import ProfileResult
 from testgen.common.models.profiling_run import ProfilingRun, ProfilingRunSummary
@@ -543,13 +544,19 @@ def get_profiling_run(job_execution_id: str) -> str:
         doc.field("Columns profiled", summary.column_ct or 0)
         if summary.record_ct is not None:
             doc.field("Records", summary.record_ct)
-        doc.field(
-            "Hygiene issues (confirmed)",
-            f"{(summary.anomalies_definite_ct or 0) + (summary.anomalies_likely_ct or 0) + (summary.anomalies_possible_ct or 0)} total "
-            f"— {summary.anomalies_definite_ct or 0} definite, "
-            f"{summary.anomalies_likely_ct or 0} likely, "
-            f"{summary.anomalies_possible_ct or 0} possible",
-        )
+        if summary.profiling_run_id:
+            # Count from the canonical source so likelihood buckets and Potential PII
+            # stay separate (matches the REST profiling-run issue_counts).
+            counts = HygieneIssue.count_for_run(summary.profiling_run_id)
+            hygiene = counts.hygiene_issues
+            doc.field(
+                "Hygiene issues (confirmed)",
+                f"{hygiene.definite + hygiene.likely + hygiene.possible} total "
+                f"— {hygiene.definite} definite, {hygiene.likely} likely, {hygiene.possible} possible",
+            )
+            pii = counts.potential_pii
+            if pii.high or pii.moderate:
+                doc.field("Potential PII", f"{pii.high} high, {pii.moderate} moderate")
         if summary.dq_score_profiling is not None:
             doc.field("Profiling Score", friendly_score(summary.dq_score_profiling))
 

testgen/mcp/tools/schedules.py

@@ -205,6 +205,7 @@ def create_profiling_schedule(
         active=active,
     )
     sched.save()
+    get_current_session().flush()  # populate the default-generated id before rendering
 
     doc = MdDoc()
     doc.heading(1, f"Profiling schedule created for `{table_group.table_groups_name}`")
@@ -239,6 +240,7 @@ def create_test_run_schedule(
         active=active,
     )
     sched.save()
+    get_current_session().flush()  # populate the default-generated id before rendering
 
     doc = MdDoc()
     doc.heading(1, f"Test run schedule created for `{suite.test_suite}`")

tests/unit/mcp/test_tools_profiling.py

@@ -5,6 +5,7 @@
 import pytest
 
 from testgen.common.models.data_column import ColumnProfileDetail, ColumnProfileSummary, DataColumnChars
+from testgen.common.models.hygiene_issue import HygieneIssueCounts, IssueCounts, PotentialPiiCounts
 from testgen.common.pii_masking import PII_REDACTED
 from testgen.mcp.exceptions import MCPResourceNotAccessible, MCPUserError
 from testgen.mcp.permissions import ProjectPermissions
@@ -635,15 +636,21 @@ def test_list_profiling_runs_malformed_schedule_raises(mock_tg_cls, mock_run_cls
 # ----------------------------------------------------------------------
 
 
+@patch("testgen.mcp.tools.profiling.HygieneIssue")
 @patch("testgen.mcp.tools.profiling.ProfilingRun")
-def test_get_profiling_run_returns_detail(mock_run_cls, db_session_mock):
+def test_get_profiling_run_returns_detail(mock_run_cls, mock_hygiene_cls, db_session_mock):
     summary = _mock_profiling_run()
     mock_run_cls.select_summary.return_value = ([summary], 1)
     mock_run = MagicMock(project_code="demo")
     mock_run_cls.get.return_value = mock_run
     mock_run_cls.select_table_breakdown.return_value = [
         MagicMock(schema_name="demo", table_name="orders", record_ct=1000, column_ct=5, anomaly_ct=2),
     ]
+    mock_hygiene_cls.count_for_run.return_value = IssueCounts(
+        hygiene_issues=HygieneIssueCounts(definite=2, likely=2, possible=4),
+        potential_pii=PotentialPiiCounts(high=0, moderate=8),
+        dismissed=0,
+    )
 
     with patch("testgen.mcp.permissions._compute_project_permissions") as mock_compute:
         mock_compute.return_value = ProjectPermissions(
@@ -659,6 +666,10 @@ def test_get_profiling_run_returns_detail(mock_run_cls, db_session_mock):
     assert "Completed" in result
     assert "Per-table breakdown" in result
     assert "orders" in result
+    # Hygiene breakdown comes from count_for_run, keeping Potential PII separate from "possible".
+    mock_hygiene_cls.count_for_run.assert_called_once_with(summary.profiling_run_id)
+    assert "8 total — 2 definite, 2 likely, 4 possible" in result
+    assert "Potential PII:** 0 high, 8 moderate" in result
 
 
 @patch("testgen.mcp.tools.profiling.ProfilingRun")