Skip to content

Commit fb96c0b

Browse files
author
ci bot
committed
Merge branch 'lazy-loaded-plugins' into 'enterprise'
fix(ui): lazy load plugin components See merge request dkinternal/testgen/dataops-testgen!397
2 parents 4aa0662 + a5f6203 commit fb96c0b

1 file changed

Lines changed: 4 additions & 8 deletions

File tree

  • testgen/ui/components/frontend/js

testgen/ui/components/frontend/js/main.js

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -50,11 +50,7 @@ const componentLoaders = {
5050
};
5151

5252
const TestGenComponent = async (/** @type {string} */ id, /** @type {object} */ props) => {
53-
if (Object.keys(window.testgen.plugins).includes(id)) {
54-
return window.testgen.plugins[id](props);
55-
}
56-
57-
const loader = componentLoaders[id];
53+
const loader = window.testgen.plugins[id] ?? componentLoaders[id];
5854
if (loader) {
5955
const Component = await loader();
6056
return Component(props);
@@ -141,10 +137,10 @@ async function loadPlugins() {
141137
try {
142138
const modules = await Promise.all(Object.values(pluginSpec).map(plugin => import(plugin.entrypoint)))
143139
for (const pluginModule of modules) {
144-
if (pluginModule && pluginModule.components) {
145-
Object.assign(window.testgen.plugins, pluginModule.components)
140+
if (pluginModule && pluginModule.componentLoaders) {
141+
Object.assign(window.testgen.plugins, pluginModule.componentLoaders)
146142
} else if (pluginModule) {
147-
console.warn(`Plugin '${pluginModule}' does not export a member 'components'.`);
143+
console.warn(`Plugin '${pluginModule}' does not export a member 'componentLoaders'.`);
148144
}
149145
}
150146
} catch (error) {

0 commit comments

Comments
 (0)