Skip to content

Commit a1576b2

Browse files
authored
[Fix-4338] Optimize the page rendering logic (#4339)
1 parent f800da4 commit a1576b2

4 files changed

Lines changed: 10 additions & 50 deletions

File tree

dinky-web/src/components/Modal/WsErrorShow/WsErrorShow.tsx

Lines changed: 0 additions & 33 deletions
This file was deleted.

dinky-web/src/models/UseWebSocketModel.tsx

Lines changed: 3 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -43,20 +43,13 @@ export type SubscriberData = {
4343
call: (data: WsData) => void;
4444
};
4545

46-
export type WsState = {
47-
wsOnReady: boolean;
48-
wsUrl: string;
49-
};
50-
5146
export default () => {
5247
const subscriberRef = useRef<SubscriberData[]>([]);
5348
const lastPongTimeRef = useRef<number>(new Date().getTime());
5449

5550
const protocol = window.location.protocol === 'https:' ? 'wss' : 'ws';
5651
const token = JSON.parse(localStorage.getItem(TOKEN_KEY) ?? '{}')?.tokenValue;
5752
const wsUrl = `${protocol}://${window.location.hostname}:${window.location.port}/api/ws/global/${token}`;
58-
const [wsState, setWsState] = useState<WsState>({ wsOnReady: true, wsUrl });
59-
6053
const ws = useRef<WebSocket>();
6154

6255
const reconnect = () => {
@@ -66,12 +59,9 @@ export default () => {
6659
ws.current = new WebSocket(wsUrl);
6760
ws.current.onopen = () => {
6861
lastPongTimeRef.current = new Date().getTime();
69-
setWsState({ wsOnReady: true, wsUrl });
7062
receiveMessage();
7163
subscribe();
7264
};
73-
ws.current.onerror = () => setWsState({ wsOnReady: false, wsUrl });
74-
ws.current.onclose = () => setWsState({ wsOnReady: false, wsUrl });
7565
};
7666

7767
const subscribe = () => {
@@ -91,7 +81,7 @@ export default () => {
9181
} else if (ws.current.readyState === WebSocket.OPEN) {
9282
ws.current.send(JSON.stringify({ topics, type: 'SUBSCRIBE' }));
9383
} else {
94-
//TODO do someting
84+
//TODO do something
9585
}
9686
};
9787

@@ -125,7 +115,7 @@ export default () => {
125115
ws.current.send(JSON.stringify({ type: 'PING' }));
126116
}
127117
}
128-
}, 2000);
118+
}, 10000);
129119
}, []);
130120

131121
const subscribeTopic = (topic: Topic, params: string[], onMessage: (data: WsData) => void) => {
@@ -141,7 +131,6 @@ export default () => {
141131

142132
return {
143133
subscribeTopic,
144-
reconnect,
145-
wsState
134+
reconnect
146135
};
147136
};

dinky-web/src/pages/DataStudio/CenterTabContent/SqlTask/index.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,8 @@ export const SqlTask = memo((props: FlinkSqlProps & any) => {
239239
});
240240
setOriginStatementValue(sqlConvertForm?.initSqlStatement ?? '');
241241
updateCenterTab({ ...props.tabData, params: newParams });
242-
if (params?.statement && params?.statement !== sqlConvertForm?.initSqlStatement) {
242+
if (params?.statement && !(params?.statement == sqlConvertForm?.initSqlStatement
243+
|| params?.statement == taskDetail?.statement)) {
243244
setDiff([
244245
{ key: 'statement', server: sqlConvertForm?.initSqlStatement, cache: params.statement }
245246
]);

dinky-web/src/pages/Other/Login/index.tsx

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,10 @@ const Login: React.FC = () => {
6161
}
6262
};
6363

64+
useEffect(() => {
65+
initSomeThing();
66+
}, []);
67+
6468
/**
6569
* When the token is expired, redirect to login
6670
*/
@@ -180,8 +184,7 @@ const Login: React.FC = () => {
180184
await handleChooseTenant(result);
181185
handleTenantVisible(false);
182186
};
183-
// 进入登录页初始化一些东西
184-
initSomeThing();
187+
185188
return (
186189
<div className={containerClassName}>
187190
<HelmetTitle />

0 commit comments

Comments
 (0)