Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ Configuration initConfiguration() {
if (StringUtils.isNotBlank(configDir)) {
log.info("Loading Flink configuration from '{}'", configDir);
conf = GlobalConfiguration.loadConfiguration(configDir);
resolveEnvVars(conf);
}

// Do not overwrite runtime given in YAML
Expand All @@ -102,6 +103,24 @@ Configuration initConfiguration() {
return conf;
}

/**
* Resolves {@code ${VAR}} placeholders in Flink configuration values from the environment, the
* same mechanism already applied to the SQL script and compiled plan. Lets secrets (e.g. the
* Iceberg maintenance lock JDBC credentials) be injected via env vars instead of landing in the
* plaintext config.yaml ConfigMap. {@link Configuration#toMap()} returns a copy, so mutating
* {@code conf} while iterating it is safe.
*/
Comment thread
ferenc-csaky marked this conversation as resolved.
Outdated
private void resolveEnvVars(Configuration conf) {
Comment thread
ferenc-csaky marked this conversation as resolved.
Outdated
conf.toMap()
.forEach(
(key, value) -> {
var resolved = resolver.resolve(value);
if (!resolved.equals(value)) {
conf.setString(key, resolved);
}
});
}

static String readTextFile(String path) throws IOException {
var f = new File(path);
if (!f.exists()) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
import java.io.IOException;
import java.nio.file.Files;
import java.nio.file.Path;
import java.util.Map;
import java.util.function.Supplier;
import org.apache.flink.api.common.RuntimeExecutionMode;
import org.apache.flink.configuration.ExecutionOptions;
Expand Down Expand Up @@ -171,4 +172,27 @@ void initConfiguration_shouldCreateNewConfigIfNoPathGiven(RuntimeExecutionMode m
assertThat(finalConf.keySet()).hasSize(1);
assertThat(finalConf.get(ExecutionOptions.RUNTIME_MODE)).isEqualTo(mode);
}

@Test
void initConfiguration_shouldResolveEnvVarPlaceholdersInConfig() throws IOException {
// Arrange — a secret injected via env var, e.g. the Iceberg maintenance lock password
Path configFile = tempDir.resolve("config.yaml");
Files.writeString(
configFile,
"flink-maintenance.lock.jdbc.password: ${ICEBERG_LOCK_PASSWORD}\ndummy.key: literal");

var resolver =
EnvVarResolver.builder().envVars(Map.of("ICEBERG_LOCK_PASSWORD", "s3cr3t")).build();
var cliRunner =
new CliRunner(
RuntimeExecutionMode.STREAMING, resolver, null, null, tempDir.toString(), null);

// Act
var finalConf = cliRunner.initConfiguration();

// Assert
assertThat(finalConf.toMap())
.containsEntry("flink-maintenance.lock.jdbc.password", "s3cr3t")
.containsEntry("dummy.key", "literal");
}
}
Loading