fix: Add localStorage fallback for storage when OfficeRuntime unavailable

- Enables taskpane to work outside Excel environment for testing
- Falls back to localStorage when OfficeRuntime.storage not available
- Fixes 'Storage not available' error in browser testing
- Maintains OfficeRuntime as primary storage method in Excel

Author: darshild1024-cpu

src/shared/storage.ts

@@ -11,42 +11,74 @@ export interface StoredKey {
 }
 
 export async function getStoredApiKey(): Promise<StoredKey> {
-  if (typeof OfficeRuntime === 'undefined' || !OfficeRuntime.storage) {
-    return { key: null, supported: false };
+  // Try OfficeRuntime first (Excel environment)
+  if (typeof OfficeRuntime !== 'undefined' && OfficeRuntime.storage) {
+    try {
+      const key = await OfficeRuntime.storage.getItem(STORAGE_KEY);
+      return { key: key ?? null, supported: true };
+    } catch (_err) {
+      return { key: null, supported: false };
+    }
   }
+  
+  // Fallback to localStorage for testing/development
   try {
-    const key = await OfficeRuntime.storage.getItem(STORAGE_KEY);
+    const key = localStorage.getItem(STORAGE_KEY);
     return { key: key ?? null, supported: true };
   } catch (_err) {
     return { key: null, supported: false };
   }
 }
 
 export async function setStoredApiKey(key: string): Promise<void> {
-  if (typeof OfficeRuntime === 'undefined' || !OfficeRuntime.storage) {
+  // Try OfficeRuntime first (Excel environment)
+  if (typeof OfficeRuntime !== 'undefined' && OfficeRuntime.storage) {
+    await OfficeRuntime.storage.setItem(STORAGE_KEY, key);
+    return;
+  }
+  
+  // Fallback to localStorage for testing/development
+  try {
+    localStorage.setItem(STORAGE_KEY, key);
+  } catch (_err) {
     throw new Error('Storage not available');
   }
-  await OfficeRuntime.storage.setItem(STORAGE_KEY, key);
 }
 
 export async function clearStoredApiKey(): Promise<void> {
-  if (typeof OfficeRuntime === 'undefined' || !OfficeRuntime.storage) {
+  // Try OfficeRuntime first (Excel environment)
+  if (typeof OfficeRuntime !== 'undefined' && OfficeRuntime.storage) {
+    try {
+      await OfficeRuntime.storage.removeItem(STORAGE_KEY);
+    } catch (_err) {
+      // ignore
+    }
     return;
   }
+  
+  // Fallback to localStorage for testing/development
   try {
-    await OfficeRuntime.storage.removeItem(STORAGE_KEY);
+    localStorage.removeItem(STORAGE_KEY);
   } catch (_err) {
     // ignore
   }
 }
 
 // Favorites management
 export async function getFavorites(): Promise<string[]> {
-  if (typeof OfficeRuntime === 'undefined' || !OfficeRuntime.storage) {
-    return [];
+  // Try OfficeRuntime first (Excel environment)
+  if (typeof OfficeRuntime !== 'undefined' && OfficeRuntime.storage) {
+    try {
+      const data = await OfficeRuntime.storage.getItem(FAVORITES_KEY);
+      return data ? JSON.parse(data) : [];
+    } catch (_err) {
+      return [];
+    }
   }
+  
+  // Fallback to localStorage for testing/development
   try {
-    const data = await OfficeRuntime.storage.getItem(FAVORITES_KEY);
+    const data = localStorage.getItem(FAVORITES_KEY);
     return data ? JSON.parse(data) : [];
   } catch (_err) {
     return [];
@@ -57,23 +89,45 @@ export async function addFavorite(seriesId: string): Promise<void> {
   const favorites = await getFavorites();
   if (!favorites.includes(seriesId)) {
     favorites.unshift(seriesId);
-    await OfficeRuntime.storage.setItem(FAVORITES_KEY, JSON.stringify(favorites.slice(0, 50)));
+    const updated = JSON.stringify(favorites.slice(0, 50));
+    
+    // Try OfficeRuntime first
+    if (typeof OfficeRuntime !== 'undefined' && OfficeRuntime.storage) {
+      await OfficeRuntime.storage.setItem(FAVORITES_KEY, updated);
+    } else {
+      localStorage.setItem(FAVORITES_KEY, updated);
+    }
   }
 }
 
 export async function removeFavorite(seriesId: string): Promise<void> {
   const favorites = await getFavorites();
   const filtered = favorites.filter(id => id !== seriesId);
-  await OfficeRuntime.storage.setItem(FAVORITES_KEY, JSON.stringify(filtered));
+  const updated = JSON.stringify(filtered);
+  
+  // Try OfficeRuntime first
+  if (typeof OfficeRuntime !== 'undefined' && OfficeRuntime.storage) {
+    await OfficeRuntime.storage.setItem(FAVORITES_KEY, updated);
+  } else {
+    localStorage.setItem(FAVORITES_KEY, updated);
+  }
 }
 
 // Recent series management
 export async function getRecent(): Promise<string[]> {
-  if (typeof OfficeRuntime === 'undefined' || !OfficeRuntime.storage) {
-    return [];
+  // Try OfficeRuntime first (Excel environment)
+  if (typeof OfficeRuntime !== 'undefined' && OfficeRuntime.storage) {
+    try {
+      const data = await OfficeRuntime.storage.getItem(RECENT_KEY);
+      return data ? JSON.parse(data) : [];
+    } catch (_err) {
+      return [];
+    }
   }
+  
+  // Fallback to localStorage for testing/development
   try {
-    const data = await OfficeRuntime.storage.getItem(RECENT_KEY);
+    const data = localStorage.getItem(RECENT_KEY);
     return data ? JSON.parse(data) : [];
   } catch (_err) {
     return [];
@@ -84,5 +138,12 @@ export async function addRecent(seriesId: string): Promise<void> {
   const recent = await getRecent();
   const filtered = recent.filter(id => id !== seriesId);
   filtered.unshift(seriesId);
-  await OfficeRuntime.storage.setItem(RECENT_KEY, JSON.stringify(filtered.slice(0, 20)));
+  const updated = JSON.stringify(filtered.slice(0, 20));
+  
+  // Try OfficeRuntime first
+  if (typeof OfficeRuntime !== 'undefined' && OfficeRuntime.storage) {
+    await OfficeRuntime.storage.setItem(RECENT_KEY, updated);
+  } else {
+    localStorage.setItem(RECENT_KEY, updated);
+  }
 }