Inline homework direct update fields

Author: alexeygrigorev

api/views/homework_upsert_save.py

@@ -66,7 +66,10 @@ def apply_homework_data(homework, data):
     if error:
         return error
 
-    apply_homework_direct_fields(homework, data)
+    for field in HOMEWORK_DIRECT_UPDATE_FIELDS:
+        if field not in data:
+            continue
+        setattr(homework, field, data[field])
     return None
 
 
@@ -117,10 +120,3 @@ def apply_homework_state(homework, data):
 
     homework.state = data["state"]
     return None
-
-
-def apply_homework_direct_fields(homework, data):
-    for field in HOMEWORK_DIRECT_UPDATE_FIELDS:
-        if field not in data:
-            continue
-        setattr(homework, field, data[field])

docs/refactoring-plan.md

@@ -2063,6 +2063,20 @@ Steps:
   `wide_positional_calls=0`, `wide_function_args=0`,
   `nested_wide_for_unpacking=0`, `range_len_loops=0`), and
   `git diff --check`.
+- [x] 2026-07-02: Removed the single-use homework-upsert direct-field helper.
+  The direct update loop now lives in `apply_homework_data` after validated
+  fields, keeping text, validated, and direct assignment steps visible in one
+  short function. Verification:
+  `uv run ruff check api/views/homework_upsert_save.py docs/refactoring-plan.md`,
+  `python -m py_compile api/views/homework_upsert_save.py`,
+  `uv run python manage.py test api.tests.test_homework_upserts api.tests.test_homework_mutations api.tests.test_homeworks`,
+  removed-helper reference scan, touched-function line-threshold scan,
+  `uvx pyrefly check`, repository AST cleanup scan excluding migrations
+  (`forbidden_comprehensions=0`, `threshold_violations=0`,
+  `append_constructed=0`, `wide_tuple_unpacking=0`,
+  `wide_positional_calls=0`, `wide_function_args=0`,
+  `nested_wide_for_unpacking=0`, `range_len_loops=0`), and
+  `git diff --check`.
 - [x] Replace deadline reminder spec factory functions with named static spec
   values and constants so reminder event planning no longer uses trivial
   pass-through factories or nine-field constructor calls. Verification: