Inline cadmin project score map

Author: alexeygrigorev

cadmin/views/project_submission_edit.py

@@ -52,16 +52,12 @@ def project_submission_edit_objects(
     )
 
 
-def project_evaluation_score_map(submission):
+def criteria_with_project_scores(review_criteria, submission):
+    evaluation_scores = {}
     scores = ProjectEvaluationScore.objects.filter(submission=submission)
-    score_map = {}
     for score in scores:
-        score_map[score.review_criteria_id] = score
-    return score_map
-
+        evaluation_scores[score.review_criteria_id] = score
 
-def criteria_with_project_scores(review_criteria, submission):
-    evaluation_scores = project_evaluation_score_map(submission)
     criteria_scores = []
     for criteria in review_criteria:
         evaluation_score = evaluation_scores.get(criteria.id)

docs/refactoring-plan.md

@@ -5154,6 +5154,20 @@ Steps:
   `wide_positional_calls=0`, `wide_function_args=0`,
   `nested_wide_for_unpacking=0`, `range_len_loops=0`), and
   `git diff --check`.
+- [x] 2026-07-02: Removed the single-use cadmin project edit evaluation-score
+  map helper. `criteria_with_project_scores` now builds the score map directly
+  from the submission before assembling per-criteria score records.
+  Verification:
+  `uv run ruff check cadmin/views/project_submission_edit.py docs/refactoring-plan.md`,
+  `python -m py_compile cadmin/views/project_submission_edit.py`,
+  `uv run python manage.py test cadmin.tests.test_project_submission_edit_views`,
+  removed-helper reference scan, touched-function line-threshold scan,
+  `uvx pyrefly check`, repository AST cleanup scan excluding migrations
+  (`forbidden_comprehensions=0`, `threshold_violations=0`,
+  `append_constructed=0`, `wide_tuple_unpacking=0`,
+  `wide_positional_calls=0`, `wide_function_args=0`,
+  `nested_wide_for_unpacking=0`, `range_len_loops=0`), and
+  `git diff --check`.
 - [x] 2026-07-02: Removed the single-use timezone preference save helper. The
   timezone update view now assigns and saves `user.preferred_timezone` directly
   in the successful update branch, while validation and response helpers remain