Inline homework question creation loop

Author: alexeygrigorev

api/views/homework_create.py

@@ -18,11 +18,6 @@ class HomeworkCreateInput:
     due_date_str: str
 
 
-def create_questions(homework, questions_data):
-    for question_data in questions_data:
-        create_question(homework, question_data)
-
-
 def homework_create_instructions_url(homework_data):
     instructions_url = homework_data.get("instructions_url")
     if not instructions_url:
@@ -108,7 +103,8 @@ def create_homework(course, homework_data):
     )
 
     questions_data = homework_data.get("questions", [])
-    create_questions(homework, questions_data)
+    for question_data in questions_data:
+        create_question(homework, question_data)
 
     homework_record = homework_to_dict(homework)
     return homework_record, None

docs/refactoring-plan.md

@@ -4684,6 +4684,20 @@ Steps:
   `wide_tuple_unpacking=0`, `wide_positional_calls=0`,
   `wide_function_args=0`, `nested_wide_for_unpacking=0`,
   `range_len_loops=0`), and `git diff --check`.
+- [x] 2026-07-02: Removed the single-use homework creation question-loop helper.
+  `create_homework` now iterates over submitted question payloads directly
+  after creating the homework, while `create_question` remains the named
+  boundary for question payload construction. Verification:
+  `uv run ruff check api/views/homework_create.py docs/refactoring-plan.md`,
+  `python -m py_compile api/views/homework_create.py`,
+  `uv run python manage.py test api.tests.test_homeworks api.tests.test_homework_mutations api.tests.test_homework_upserts`,
+  removed-helper reference scan, touched-function line-threshold scan,
+  `uvx pyrefly check`, repository AST cleanup scan excluding migrations
+  (`forbidden_comprehensions=0`, `threshold_violations=0`,
+  `append_constructed=0`, `wide_tuple_unpacking=0`,
+  `wide_positional_calls=0`, `wide_function_args=0`,
+  `nested_wide_for_unpacking=0`, `range_len_loops=0`), and
+  `git diff --check`.
 - [x] 2026-07-02: Named the E2E repository root and string path before adding
   it to `sys.path`, removing the last non-allowed nested-call site from the
   nested-call scan while leaving allowed `enumerate(zip(...))` test loops